Commit Graph

1408 Commits

Author SHA1 Message Date
David Heinemeier Hansson 5aa2b7da84 No need to cache individual reactions
Both because the reactions partial actually depends on multiple
variables but also because its just not worth it when we are caching the
comment.
2025-04-11 17:58:48 +02:00
David Heinemeier Hansson 7861b7c087 Just open one turbo stream per card
Per comment is excessive and needless
2025-04-11 17:58:11 +02:00
David Heinemeier Hansson 263b3336db Add missing CR 2025-04-11 17:50:53 +02:00
David Heinemeier Hansson 0954cfe008 Add CR 2025-04-11 17:48:01 +02:00
David Heinemeier Hansson 79700162fc Use correct stream name
comment, :comments makes no sense for a stream for the reactions
2025-04-11 17:47:35 +02:00
David Heinemeier Hansson eec76d0d4f Use modern params#expect 2025-04-11 17:43:31 +02:00
David Heinemeier Hansson f9bb779b61 Use local vars so ivar dependency is only from before actions 2025-04-11 17:42:30 +02:00
David Heinemeier Hansson 3ecf150636 Use proper access control
Otherwise you could react to any comment on the entire account. And then
you might as well just do Comment.find.
2025-04-11 17:41:28 +02:00
David Heinemeier Hansson dc4e50fba5 Move messages partial under cards 2025-04-11 17:34:49 +02:00
David Heinemeier Hansson 5084bbf3b7 Use modern params#expect syntax 2025-04-11 17:01:19 +02:00
David Heinemeier Hansson 8a4a087a00 Fine to let destroying something destroyed be a no-op
Would be an edge-casey race condition, but its possible
2025-04-11 17:00:08 +02:00
David Heinemeier Hansson 256d536009 Always use _path unless we are changing domains 2025-04-11 16:58:56 +02:00
David Heinemeier Hansson 16c1583133 Usually the order comes last 2025-04-11 16:58:47 +02:00
David Heinemeier Hansson 5ecf0ce3f6 Stick with one term 2025-04-11 16:57:03 +02:00
David Heinemeier Hansson a8aa2c4f80 Clean up the controller 2025-04-11 16:49:55 +02:00
David Heinemeier Hansson f4ce57e308 Move comments under cards 2025-04-11 16:21:44 +02:00
David Heinemeier Hansson 64b529ce94 Fix indention 2025-04-11 16:12:18 +02:00
Jorge Manrubia ba6eab509c Refresh timers when morphing happens 2025-04-11 13:26:01 +02:00
Jorge Manrubia 825bbf808e Extract helper for card articles, use classes to determine when to show golden status 2025-04-11 12:01:52 +02:00
Jorge Manrubia aef75feead Only consider golden those cards in "doing" 2025-04-11 11:49:52 +02:00
Jorge Manrubia 1275abd99e Fix recently completed order for good! 2025-04-11 11:37:02 +02:00
Jorge Manrubia 66b5732264 Place recently closed cards first 2025-04-11 11:27:38 +02:00
Jorge Manrubia 17aa9b97e9 Monkey patch a prepend_order method 2025-04-11 10:28:12 +02:00
Jorge Manrubia 4f3f322528 Rename inconsistency: go with goldness 2025-04-11 10:22:18 +02:00
Jorge Manrubia eae1669ac3 Touch 2025-04-11 10:20:30 +02:00
Jorge Manrubia 806609e77b Use gild/ungild 2025-04-11 10:20:06 +02:00
Jorge Manrubia b4297ab852 Format 2025-04-11 09:57:45 +02:00
Jorge Manrubia 492a42ba92 Not needed anymore 2025-04-11 09:57:45 +02:00
Jorge Manrubia 5360b4ccb4 Add comment 2025-04-11 09:57:45 +02:00
Jason Zimdars da7a30203c Style golden cards 2025-04-10 17:14:04 -05:00
Jason Zimdars 5560976091 Merge branch 'main' into gold-cards
* main:
  Try a segmented toggle for engagement
  Fix tests
  Rework min card design and meta section for all cards
  Move `title` to the `img` element so we get hover in both cases
  Remove sorting filter UI
  Sort Considering and Doing by `updated_at`
  Restore comment action icon
  Fix dot escaping container
  Seen cards should be flat
  Ensure overflow cards are hidden
  Arrow needs to match derived color
  Dialog target needs to be present
  This isn't necessary in the mini card template
  Revert "The button and dialog need not render in previews"
2025-04-10 16:42:45 -05:00
Jason Zimdars 0c107c5894 Fix that cards which were Drafted or in Considering were also being displayed in Doing
CC: @jorgemanrubia
2025-04-10 16:42:40 -05:00
Jason Zimdars 81ee2ab64d Try a segmented toggle for engagement 2025-04-10 16:06:35 -05:00
Jason Zimdars e4110734eb Rework min card design and meta section for all cards 2025-04-10 14:39:50 -05:00
Jason Zimdars 7fdf9ab2fd Move title to the img element so we get hover in both cases 2025-04-10 14:39:19 -05:00
Jason Zimdars 296ac0c8b5 Remove sorting filter UI 2025-04-10 11:07:22 -05:00
Jason Zimdars 1387ad2581 Sort Considering and Doing by updated_at 2025-04-10 11:06:55 -05:00
Jason Zimdars f3495fa731 Restore comment action icon 2025-04-10 10:41:26 -05:00
Jorge Manrubia fac2fce3d5 Rename scope 2025-04-10 17:18:02 +02:00
Jorge Manrubia 9747d590ea Not used 2025-04-10 17:16:36 +02:00
Jorge Manrubia 9029853bdf Only show the button when card is in "doing" 2025-04-10 17:11:00 +02:00
Jorge Manrubia 2e5b25a30c Always place golden cards first 2025-04-10 17:05:30 +02:00
Jason Zimdars b016c8a165 Fix dot escaping container 2025-04-10 09:58:11 -05:00
Jorge Manrubia 7406a1039f Add models to track gold cards and implement basic toggle behavior 2025-04-10 16:48:12 +02:00
Jason Zimdars e0a6549610 Seen cards should be flat 2025-04-10 09:45:18 -05:00
Jason Zimdars 84276e85ba Ensure overflow cards are hidden 2025-04-10 09:43:09 -05:00
Jason Zimdars 0a472f29d5 Arrow needs to match derived color 2025-04-10 09:16:30 -05:00
Jason Zimdars 6d610e6418 Dialog target needs to be present 2025-04-10 09:09:26 -05:00
Jason Zimdars 0746a63832 This isn't necessary in the mini card template 2025-04-10 09:09:16 -05:00
Jason Zimdars e3b071c603 Revert "The button and dialog need not render in previews"
This reverts commit 2c79ca09d7.
2025-04-10 08:45:43 -05:00