Commit Graph

40 Commits

Author SHA1 Message Date
Jay Ohms d273ab20a6 Merge branch 'main' into mobile-app/prepare-webviews
* main: (63 commits)
  Ignore hotkeys with modifiers
  Fix 1Password account ID (was user UUID) (#2278)
  Switch 1Password account to 37signals.1password.com (#2276)
  Remove CSS testing comments
  Max card count equals geared pagination size
  Block IPv4-compatible IPv6 addresses in SSRF protection (#2273)
  Only enable transitions on user interaction
  Don't update counter if value hasn't changed
  Add padding to upgrade message on larger screens
  Add test coverage for autolinking multiple URLs
  Add "noopener" to autolinks' rel attribute
  Avoid string manipulation when autolinking.
  Only bump z-index when nav is open
  Move nav and related elements above footer
  Delete Dockerfile.dev
  fix: use the right gh-cli arch package (#2232)
  Bump actions/attest-build-provenance from 3.0.0 to 3.1.0 (#2257)
  Bump docker/setup-buildx-action from 3.11.1 to 3.12.0 (#2256)
  Consider user avatars always public
  Implement authorization for Active Storage endpoints
  ...
2026-01-02 11:42:07 -05:00
Jason Zimdars 6e90a6dbfb Add hotkeys for triaging cards in columns
Hover to select items
2025-12-19 14:33:47 -06:00
Adrien Maston b49aa9cbf1 Don't load the navigable list controller on mobile 2025-12-19 12:16:04 +01:00
gijigae e03c002efd Fix Japanese IME input handling for tags and form fields
When typing in Japanese, the Enter key is used to confirm kanji conversion
during IME composition. Previously, pressing Enter would immediately save
the tag, which prevented users from completing the conversion.

Changes:
- Add isComposing check to navigable_list_controller.js Enter handler
- Add IME composition tracking to form_controller.js
- Add compositionstart/compositionend event handlers to tag, step, and
  reaction input fields
- Add preventComposingSubmit action to prevent form submission during
  composition

This fix supports all IME input methods (Japanese, Chinese, Korean, etc.)
using standard browser composition events.
2025-12-06 17:26:35 +09:00
Jorge Manrubia 0a0a8642c9 Fix: scrolling to parent navigable list despite of setting
We need to check the setting of the parent controller

https://app.fizzy.do/5986089/cards/3184
2025-11-27 18:04:38 +01:00
Jorge Manrubia ca10e4ba4e Prevent autoscroll to the root columns container to prevent jump on page load
https://app.fizzy.do/5986089/cards/3160
2025-11-25 21:01:18 +01:00
Jorge Manrubia 6daccc88ae Deselect column/card selection when clicking outside 2025-11-21 12:53:13 +01:00
Jorge Manrubia 6af9ab9b6d Make selection work when toggling columns 2025-11-21 12:28:37 +01:00
Jorge Manrubia 7c0fb3c79b Fix: activate only when the option is set 2025-11-20 14:13:59 +01:00
Jorge Manrubia ccfc1b6058 Support containing actionable items to focused items in the navigable list 2025-11-20 14:03:00 +01:00
Jorge Manrubia eb51edac1c Rename properties 2025-11-20 13:56:27 +01:00
Jorge Manrubia cc4f696a00 Remove trace 2025-11-20 13:46:57 +01:00
Jorge Manrubia c472825a55 Move comment 2025-11-20 13:42:33 +01:00
Jorge Manrubia 20a0e2be9b Extract method 2025-11-20 13:42:25 +01:00
Jorge Manrubia 3247841c2d Expanding columns and selection working 2025-11-20 13:00:59 +01:00
Jorge Manrubia 0726da2708 Things more or less working 2025-11-20 11:29:09 +01:00
Jorge Manrubia 3bfab09795 Add keyboard navigation support for board columns
- Add horizontal/vertical navigation configuration options to navigable_list controller
- Support nested navigation (columns contain lists of cards)
- Disable horizontal navigation within individual columns
- Enable horizontal navigation at the column level
- Refactor selection logic into reusable methods

This allows users to navigate between columns with left/right arrow keys
and between cards within a column using up/down arrow keys.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-20 09:34:08 +01:00
Andy Smith e033f71dee Cleanup 2025-11-10 14:44:14 -06:00
Andy Smith e2ac6c1d7e Keep selected item in view 2025-11-10 14:42:42 -06:00
Andy Smith 1b4dcee694 Add combobox role 2025-08-21 15:35:44 -05:00
Andy Smith 9139c1c56d Add activedescendant to filter input 2025-08-21 15:30:59 -05:00
Andy Smith 00c77bbdf5 Add unique IDs to all filter items 2025-08-21 14:44:17 -05:00
Andy Smith 389273072d Handle disabled switches 2025-08-13 12:30:12 -05:00
Jason Zimdars 6227cf9a8b Keyboard arrow through pins and notifications 2025-07-30 16:07:55 -05:00
Jorge Manrubia 939d68b941 Don't prevent default with light/right arrows since this prevents moving cursor on input fields 2025-07-01 11:38:44 +02:00
Jason Zimdars 37dc14c0c6 x interferes with string entry, try SHIFT+ENTER to toggle checkboxes 2025-06-03 16:35:55 -05:00
Jason Zimdars 9ebb1ffeb1 Use x to toggle filter checkboxes 2025-06-03 07:55:19 -05:00
Jorge Manrubia 651ee5f6fe Use CTRL-ENTER or CMD-ENTER to toggle, since space is a legit search character 2025-06-03 06:32:38 +02:00
Jorge Manrubia 55c1e53624 Skip if no checkbox 2025-06-03 06:06:51 +02:00
Jorge Manrubia e33dd22fad Toggle selected item with space 2025-06-03 06:05:15 +02:00
Jorge Manrubia 61fbad218b Make tag filters selectable/navigable too 2025-06-02 18:39:44 +02:00
Jorge Manrubia edf7153ced Remove trace 2025-06-02 14:59:04 +02:00
Jorge Manrubia 37fd2b248d Revamp filters menu (WIP)
- Make them navigable by keyboard (UP, DOWN, ENTER to activate option).
- Filter based on the actual text in the element, use containment condition instead of CSS selector on value prefix.
- Make all the elements in the filter searchable and reachable by keyboard.
2025-06-02 14:51:03 +02:00
Jorge Manrubia a3866348fd Aria selected is a better fit here 2025-06-02 13:37:29 +02:00
Jorge Manrubia 87b4643946 Fix: navigation not working after adding new commands 2025-05-16 13:29:18 +02:00
Jorge Manrubia 86db634f7f Fix: selected item not showing up in Safari
It also handles auto selecting when an element is focus. E.g: if you tabulate to the next control in the navigable list, you want selection to update accordingly.
2025-05-08 10:41:51 +02:00
Jorge Manrubia bfc89124cf Reorder 2025-05-07 13:55:28 +02:00
Jorge Manrubia b9875033bc Remove unused 2025-05-07 13:54:47 +02:00
Jorge Manrubia 87484dbca0 Add basic keyboard navigation support for the Fizzy do menu 2025-05-07 13:46:19 +02:00
Jorge Manrubia 0dcc6959da Extract constant to clarify regexp 2025-05-07 13:31:52 +02:00