2 Commits

Author	SHA1	Message	Date
Jeremy Daer	723c8180b4	Add JSON response format for full SDK/CLI coverage (#2675) ... * Add JSON response format to void-response controller actions Add respond_to blocks with JSON format to 14 controllers that previously only rendered HTML or Turbo Stream responses. JSON callers get head :no_content (or :created/:ok for push subscriptions, distinguishing new vs existing). Covers: board involvements, board/account entropies, column reordering, card readings, card publishing, user roles, user avatars, account settings, notification settings, join codes (with 422 error branch), and push subscriptions. * Add steps index endpoint with JSON view Add index action to Cards::StepsController so SDK/CLI callers can list all steps for a card. Reuses the existing _step.json partial. * Add JSON views for paginated card list endpoints Add show.json.jbuilder for stream, not-now, and closed column endpoints. No controller changes needed — set_page_and_extract_ portion_from and fresh_when already work format-agnostically. * Add JSON search endpoint with distinct-card pagination JSON search paginates distinct Card records (via the existing Card.mentioning scope with .distinct) rather than Search::Record objects. This ensures page boundaries, Link headers, and counts reflect unique cards — no short pages from post-pagination dedup. ID-match searches return a uniform single-element Card[] array through the same pagination path. * Add JSON views for settings and configuration endpoints Add show.json.jbuilder for account settings (name), join codes (code, usage_count, usage_limit, url, active), and notification settings (bundle_email_frequency). Tests for show and update were added in the void-response commit. * Add JSON response format to data exports Create returns 201 with export id, status, and created_at so callers can poll. Show returns any-status exports for JSON (not just completed) with a download_url when ready, or 404 for missing/other-user exports. * Extend access token JSON API Add index.json and _access_token.json partial for listing tokens. Add JSON format to destroy. Include id and created_at in the create response alongside the existing token/description/permission fields. * Fix ambiguous precedence warning in export JSON view * Assert X-Total-Count pagination header in streams JSON test * Address review feedback - Guard steps index against HTML requests (redirect to card) - Normalize created_at to UTC in access token and export JSON - Add deterministic ordering (.latest) to search JSON pagination * Return 406 for HTML requests to steps index instead of redirect * Add wrap_parameters for flat SDK JSON payload compatibility Five controllers infer the wrong wrapper key from their class name, so flat JSON bodies like {"role":"admin"} fail with 400. Add explicit wrap_parameters declarations: - Users::RolesController → :user - Notifications::SettingsController → :user_settings - Account::JoinCodesController → :account_join_code - Account::SettingsController → :account - Boards::EntropiesController → :board Add integration tests that send flat (unwrapped) JSON payloads for all seven param-bearing endpoints to prove SDK compatibility. * Address PR review feedback - Use 201 Created (not 204) for all create actions: publishes, readings, left/right positions, push subscriptions - Simplify push subscription to always return :created (no 200/201 variance) - Remove superfluous respond_to block from steps#index - Merge exports#show into single respond_to block - Move export download_url conditional out of inline args - Ensure join code active is explicitly boolean - Remove extra parens from search controller assignment - Add blank lines between format blocks for readability * Return JSON bodies on create actions Create actions for boards, cards, columns, comments, and steps now render the resource as JSON (via their show views) instead of returning empty 201 responses with only a Location header. SDKs expect a JSON body they can deserialize into the created resource. * Return JSON bodies on reaction create actions Card and comment reaction creates now render the reaction as JSON instead of returning empty 201 responses, consistent with the other resource-creating endpoints. * Allow access tokens API without account scope Access tokens are identity-level (not account-scoped), so the controller needs to work with bearer token auth and no account slug in the URL. Skip require_account so the bearer token auth path can proceed. Also fix involvement test to send params in JSON body (not query string) to match real SDK usage.	2026-03-09 11:39:49 -07:00
Mike Dalessio	cb61b36715	Allow boosts on cards (#2411) ... * Add reactions association to Card model Adds `has_many :reactions` to Card, matching the implementation in Comment. This allows cards to be reacted to directly with emoji reactions. The association: - Orders reactions chronologically - Uses polymorphic `:reactable` interface - Deletes reactions when card is destroyed Includes test coverage for the new association. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Add reactions UI to card detail view - Create Cards::ReactionsController with turbo stream responses - Add card reactions views (reactions list, new form, menu partial) - Position reaction button flush-right when no reactions exist - Show reactions on bottom-left when present, with button inline - Handle narrow viewports by flowing button below meta section - Add controller tests for card reactions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Add boost count to card preview Display reaction count alongside comment count on card tiles in board columns. Introduces a .card__counts wrapper to group both counts with proper positioning on all viewport sizes. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Consolidate reaction views for cards and comments Extract shared views to app/views/reactions/ using polymorphic routing. Both card and comment reactions now render the same partials, with a helper to compute the correct path prefix for nested routes. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Fix emoji picker width in card reactions Override .card .popup { inline-size: 260px } for the reaction popup so the emoji grid displays without horizontal scrollbar. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Hide boost count where comment count is hidden Add .card__boosts alongside .card__comments in: - Tray view (display: none) - Cards with background images (opacity toggle on hover) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Fix reactions button overlap with zoom button in card footer When a card has a background image, the footer contains both a reactions button and a zoom button. Previously they would overlap because the reactions button was absolutely positioned to the bottom-right. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Tighten up previews * Move card reactions from meta partial to container Fixes two issues: 1. Reactions were duplicated each time a card was assigned because the turbo stream replaced the meta div with the full perma/meta partial, which included reactions outside the replaced element. 2. Draft cards incorrectly showed the boost button because the meta partial was shared between published and draft containers. Moving reactions to _container.html.erb (published cards only) fixes both issues and keeps the meta partial focused on meta content. Fixes https://app.fizzy.do/5986089/cards/3837 Fixes https://app.fizzy.do/5986089/cards/3835 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * WIP adjust perma page * Position and style the footer * Render the stamp in the card body instead of the footer * Fix undefined local variable in public cards view Changed `card` to `@card` when rendering the stamp partial. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Preload card reactions to avoid N+1 queries Include reactions and their reacters in the preloaded scope, matching what we already do for comments. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Add model tests for card and comment reaction cleanup Test that: - Creating a card reaction touches the card's last_active_at - Reactions are deleted when their parent comment is destroyed - Reactions are deleted when their parent card is destroyed Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Minor improvements to reactions code - Use size instead of count in boosts partial to avoid extra SQL query on already-loaded collection - Add else clause to reaction_path_prefix_for to raise ArgumentError for unknown reactable types instead of silently returning nil Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Bump specificity of reaction popup in the card perma --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: Andy Smith <andy@37signals.com>	2026-01-23 13:25:55 -05:00