Commit Graph

211 Commits

Author SHA1 Message Date
Kevin McConnell ab154f2f35 Generate notification content in a helper 2025-01-14 13:08:12 +00:00
Kevin McConnell 30b58f716b Make title a notifier attribute 2025-01-14 10:21:47 +00:00
Jason Zimdars 5f88cd3900 Design for notifications 2025-01-13 20:46:51 -06:00
Kevin McConnell 196575c0a2 Use a job to generate notifications 2025-01-13 14:21:47 +00:00
Kevin McConnell c62e800b08 Notifications are all related to a Bubble 2025-01-13 14:21:47 +00:00
Kevin McConnell df1225e58d Style 2025-01-13 14:21:47 +00:00
Kevin McConnell 66d0f29d45 Notify on pop as well
And DRY up some duplication.
2025-01-13 14:21:47 +00:00
Kevin McConnell 58ce85ce36 Link comment notifications to the comment 2025-01-13 14:21:47 +00:00
Kevin McConnell 876083c697 Broadcast new notifications 2025-01-13 14:21:47 +00:00
Kevin McConnell 58d5ed07a5 Create notifications when tracking events 2025-01-13 14:21:47 +00:00
Kevin McConnell dc53a39b93 Update notification body 2025-01-13 14:21:47 +00:00
Kevin McConnell 8a51597408 Add direct linking to comments 2025-01-13 14:21:47 +00:00
Kevin McConnell af5ac65116 Make notification target polymorphic 2025-01-13 14:21:47 +00:00
Kevin McConnell 952895ae67 WIP: show notifications in a tray 2025-01-13 14:21:47 +00:00
Kevin McConnell 6b5e098407 Use a better return value 2025-01-13 14:21:47 +00:00
Kevin McConnell a082eb75f5 Track events for new comments too 2025-01-13 14:21:47 +00:00
Kevin McConnell 5a56c16029 Add a factory for creating notifications 2025-01-13 14:21:47 +00:00
Kevin McConnell d0ae5b4bdc Add notification model 2025-01-13 14:21:47 +00:00
Kevin McConnell e7bc04856f Broadcast bucket changes to index page
This will cause each filtered view to stay updated as the items in the
buckets change.

For filters that are specific to buckets, we listen to broadcasts on
those buckets; for filters on "All projects" we listen instead for
broadcasts on an account-specific channel. This is so that "All
projects" views will be aware of any new buckets that are added, while
also avoid unnecessary refreshes from buckets that are filtered out.
2025-01-09 09:14:22 +00:00
Kevin McConnell 22be073a92 Sanitize search terms 2025-01-08 16:49:40 +00:00
Jason Zimdars 0a6b5571c0 Merge pull request #167 from basecamp/users
Account users
2024-12-19 11:11:41 -06:00
Jose Farias 5b83d0b5b2 Filter#persist! -> Filter#remember 2024-12-18 18:34:47 -06:00
Jason Zimdars 295d8ce088 Upload user avatar 2024-12-18 14:44:05 -06:00
Jason Zimdars 592c88e639 Add session transfer feature 2024-12-18 12:38:53 -06:00
Jose Farias fdea6d4248 Merge branch 'main' into house
* main:
  Update test
  Wire up comment deletion
  Whitespace
  Wire up editing comments
  Open the title field for editing after creating a new bubble
2024-12-17 00:34:00 -06:00
Jason Zimdars 33d2d098f1 Wire up comment deletion 2024-12-16 17:46:01 -06:00
Jose Farias 326bdc74cf Merge branch 'main' into house
* main: (23 commits)
  Improve the flow for editing bubble titles
  Use path helpers in tests
  Revising access shouldn't do a replace turbo-action
  Split into new tests
  Update this test, too
  Adjust tests to match new behavior
  Reapply "Destroy equivalent filters upon resource removal"
  Revert "Destroy equivalent filters upon resource removal"
  Destroy equivalent filters upon resource removal
  Don't autocomplete
  Rework boosts form so you can enter any integer
  Pull out access_menu_tag
  Punt on removing filters for inaccessible buckets
  Can't see bubbles in buckets you've lost access to
  Users can remove themselves from buckets
  Fix redirect assertion
  Fix redirect assertion
  Submit form when toggling all-access + caching
  Unnecessary parens
  Can't revoke access to all-access bucket
  ...
2024-12-16 13:50:55 -06:00
Jose Farias d13d558a0b Merge branch 'main' into everyone
* main:
  Update this test, too
  Adjust tests to match new behavior
  Don't autocomplete
  Rework boosts form so you can enter any integer
2024-12-16 11:19:36 -06:00
Jose Farias aed33620ba Reapply "Destroy equivalent filters upon resource removal"
This reverts commit 5e09fddbe0.
2024-12-13 18:51:22 -06:00
Jose Farias 5e09fddbe0 Revert "Destroy equivalent filters upon resource removal"
This reverts commit 6c69bf7dc1.
2024-12-13 18:49:41 -06:00
Jose Farias 6c69bf7dc1 Destroy equivalent filters upon resource removal 2024-12-13 17:26:30 -06:00
Jason Zimdars 0b28a18c05 Rework boosts form so you can enter any integer 2024-12-13 16:54:11 -06:00
Jose Farias 4095eba266 Can't see bubbles in buckets you've lost access to 2024-12-13 14:37:19 -06:00
Jose Farias 065b73f889 Can't revoke access to all-access bucket 2024-12-12 19:08:36 -06:00
Jose Farias 688f812336 Unnecessary parens 2024-12-10 19:52:42 -06:00
Jose Farias 59c66923f0 Implement all_access buckets 2024-12-10 19:46:40 -06:00
Jose Farias 45e94e4484 Support search on markdown fields 2024-11-29 14:28:37 -06:00
Jose Farias d556e21287 Use House for MD comments 2024-11-27 18:59:15 -06:00
Jose Farias 3e1b2c74e4 Make one-way assignment and tagging methods private 2024-11-25 17:55:25 -06:00
Jose Farias a9f845ed47 Assigner is always Current.user 2024-11-25 17:51:20 -06:00
Jose Farias acac683b3e Do combobox filtering client-side 2024-11-25 16:25:42 -06:00
Jose Farias 5e09f5a9b9 Remove swapping 2024-11-25 16:17:44 -06:00
Jose Farias f266e46b57 Wire up comboboxes 2024-11-21 19:58:21 -06:00
Jose Farias e117f4e5af boost_count -> boosts_count
This aligns better with counter_cache conventions, in case we turn boosts into a model later
2024-11-19 14:22:51 -06:00
Jose Farias df746e5a64 Merge branch 'main' into activity-score
* main:
  Missed one
  Tighten up workflow panel
  Fix test
  Forget about the dividing line for now
  Add some structure to buckets index
  Adjust form
  Restore bucket settings link, adjust styles for filters
  No need for inline svg here anymore
2024-11-19 13:38:39 -06:00
Jose Farias 9ac136bace Rescore bubble from Message, not Comment 2024-11-19 13:27:09 -06:00
Jose Farias 2a9be42c4e Use count cache instead of counting comments in calculating score 2024-11-19 13:26:25 -06:00
Jose Farias 0c38699dec Merge branch 'main' into activity-score
* main: (22 commits)
  Fix layout issue that caused comment form to be unselectable
  Stick with stock buttons for now
  Still a little odd that it's a separate form but this conceptually belongs here
  We've got a utility for this
  Fix navbar alignment
  Kind of hate that icon, let's try something else
  Use new bubble shape
  Prevent bubble getting squished
  Fix image fit, try animation
  Don't assume `@filter` is set
  Clicking assignees filters by that assignee
  Restore behavior: clicking tags filters by that tag
  Make these consist from view-to-view
  Improve hover motion for meta bubbles
  No longer used
  Improve assignee bubble display, especially when there are multiple assignees
  name -> key
  ** not required
  Swap one? and many? branches
  Change title based on selected buckets
  ...
2024-11-19 13:09:57 -06:00
Jason Zimdars 4eaa414ebb Missed one 2024-11-19 13:01:01 -06:00
Jason Zimdars ca7cccdb7c Add some structure to buckets index 2024-11-19 12:45:16 -06:00