Commit Graph

83 Commits

Author SHA1 Message Date
Kevin McConnell 78b7fe0f3d Fix tests 2025-01-14 13:21:20 +00:00
Kevin McConnell 66d0f29d45 Notify on pop as well
And DRY up some duplication.
2025-01-13 14:21:47 +00:00
Kevin McConnell e67ac372d3 Fix test 2025-01-13 14:21:47 +00:00
Kevin McConnell dc53a39b93 Update notification body 2025-01-13 14:21:47 +00:00
Kevin McConnell 5a56c16029 Add a factory for creating notifications 2025-01-13 14:21:47 +00:00
Kevin McConnell d0ae5b4bdc Add notification model 2025-01-13 14:21:47 +00:00
Kevin McConnell 22be073a92 Sanitize search terms 2025-01-08 16:49:40 +00:00
Jason Zimdars 0a6b5571c0 Merge pull request #167 from basecamp/users
Account users
2024-12-19 11:11:41 -06:00
Jose Farias 5b83d0b5b2 Filter#persist! -> Filter#remember 2024-12-18 18:34:47 -06:00
Jose Farias 7d83874266 Use Redcarpet for plain text rendering 2024-12-18 16:39:56 -06:00
Jason Zimdars 592c88e639 Add session transfer feature 2024-12-18 12:38:53 -06:00
Jose Farias cb1686d84e Use house ssr 2024-12-17 18:02:42 -06:00
Jose Farias 326bdc74cf Merge branch 'main' into house
* main: (23 commits)
  Improve the flow for editing bubble titles
  Use path helpers in tests
  Revising access shouldn't do a replace turbo-action
  Split into new tests
  Update this test, too
  Adjust tests to match new behavior
  Reapply "Destroy equivalent filters upon resource removal"
  Revert "Destroy equivalent filters upon resource removal"
  Destroy equivalent filters upon resource removal
  Don't autocomplete
  Rework boosts form so you can enter any integer
  Pull out access_menu_tag
  Punt on removing filters for inaccessible buckets
  Can't see bubbles in buckets you've lost access to
  Users can remove themselves from buckets
  Fix redirect assertion
  Fix redirect assertion
  Submit form when toggling all-access + caching
  Unnecessary parens
  Can't revoke access to all-access bucket
  ...
2024-12-16 13:50:55 -06:00
Jose Farias e085cb7497 Split into new tests 2024-12-16 11:35:50 -06:00
Jose Farias d13d558a0b Merge branch 'main' into everyone
* main:
  Update this test, too
  Adjust tests to match new behavior
  Don't autocomplete
  Rework boosts form so you can enter any integer
2024-12-16 11:19:36 -06:00
Jason Zimdars 5fdea98b8d Update this test, too 2024-12-16 11:15:56 -06:00
Jose Farias aed33620ba Reapply "Destroy equivalent filters upon resource removal"
This reverts commit 5e09fddbe0.
2024-12-13 18:51:22 -06:00
Jose Farias 5e09fddbe0 Revert "Destroy equivalent filters upon resource removal"
This reverts commit 6c69bf7dc1.
2024-12-13 18:49:41 -06:00
Jose Farias 6c69bf7dc1 Destroy equivalent filters upon resource removal 2024-12-13 17:26:30 -06:00
Jose Farias 2f7c3d0fd3 Punt on removing filters for inaccessible buckets
Current behavior just stops querying for bubbles in inaccessible buckets. That might be fine.
2024-12-13 14:41:10 -06:00
Jose Farias 4095eba266 Can't see bubbles in buckets you've lost access to 2024-12-13 14:37:19 -06:00
Jose Farias 065b73f889 Can't revoke access to all-access bucket 2024-12-12 19:08:36 -06:00
Jose Farias 59c66923f0 Implement all_access buckets 2024-12-10 19:46:40 -06:00
Jose Farias 45e94e4484 Support search on markdown fields 2024-11-29 14:28:37 -06:00
Jose Farias 11e9e691bf Clean up test names 2024-11-25 20:35:53 -06:00
Jose Farias 3e1b2c74e4 Make one-way assignment and tagging methods private 2024-11-25 17:55:25 -06:00
Jose Farias 36d930cd0e Add tests for tagging and assigning 2024-11-25 17:49:28 -06:00
Jose Farias e117f4e5af boost_count -> boosts_count
This aligns better with counter_cache conventions, in case we turn boosts into a model later
2024-11-19 14:22:51 -06:00
Jose Farias c88fefd92a Clean up activity score tests 2024-11-19 14:18:27 -06:00
Jose Farias df746e5a64 Merge branch 'main' into activity-score
* main:
  Missed one
  Tighten up workflow panel
  Fix test
  Forget about the dividing line for now
  Add some structure to buckets index
  Adjust form
  Restore bucket settings link, adjust styles for filters
  No need for inline svg here anymore
2024-11-19 13:38:39 -06:00
Jose Farias 0c38699dec Merge branch 'main' into activity-score
* main: (22 commits)
  Fix layout issue that caused comment form to be unselectable
  Stick with stock buttons for now
  Still a little odd that it's a separate form but this conceptually belongs here
  We've got a utility for this
  Fix navbar alignment
  Kind of hate that icon, let's try something else
  Use new bubble shape
  Prevent bubble getting squished
  Fix image fit, try animation
  Don't assume `@filter` is set
  Clicking assignees filters by that assignee
  Restore behavior: clicking tags filters by that tag
  Make these consist from view-to-view
  Improve hover motion for meta bubbles
  No longer used
  Improve assignee bubble display, especially when there are multiple assignees
  name -> key
  ** not required
  Swap one? and many? branches
  Change title based on selected buckets
  ...
2024-11-19 13:09:57 -06:00
Jason Zimdars fada5fef59 Fix test 2024-11-19 12:52:39 -06:00
Jose Farias 0c51129e1e name -> key 2024-11-18 12:04:52 -06:00
Jose Farias 0995eee074 Turn filter chips into links 2024-11-18 11:34:44 -06:00
Jose Farias f1c8ae2f5f No need to pluck title
Was a debugging artifact
2024-11-15 18:21:39 -06:00
Jose Farias b4e8adca47 Pre-calculate comment counts and activity scores 2024-11-15 18:17:42 -06:00
Jose Farias 4dfba46142 Fix tests 2024-11-13 13:55:30 -06:00
Jose Farias af1aa3fd62 Test field accessors 2024-11-13 13:51:54 -06:00
Jose Farias a3fb92d506 Test filter terms 2024-11-13 13:39:04 -06:00
Jose Farias 458a6a1ac2 Wire up assigner filters 2024-11-13 13:34:51 -06:00
Jose Farias 768b48ea03 Use Filter class method to digest fixture params 2024-11-13 12:08:23 -06:00
Jose Farias eff8539b66 Fix test 2024-11-11 14:23:00 -06:00
Jose Farias d455b72906 Hash filter params 2024-11-08 15:17:55 -06:00
Jose Farias 75d2b793a3 Increase filter tests specificity 2024-11-07 16:52:49 -06:00
Jose Farias da37fa56d8 Add some more tests for bubble filters 2024-11-07 16:13:00 -06:00
Jose Farias 201a543a9b Assert params after resource removal 2024-11-07 11:34:56 -06:00
Jose Farias ec04ccef4d Test param sanitization 2024-11-06 18:22:10 -06:00
Jose Farias 9efe94a277 idempotent_create -> persist 2024-11-06 18:09:55 -06:00
Jose Farias 12ce07639d Add tests 2024-11-06 17:49:14 -06:00
Jose Farias e92da7c73a Test EventSummary bodies 2024-10-27 20:30:15 -06:00