Commit Graph

500 Commits

Author SHA1 Message Date
Jorge Manrubia 68e2e96076 Fix indentation 2025-04-23 10:44:42 +02:00
Jason Zimdars 9b57480b40 ticket is a vestige of a previous design 2025-04-22 13:55:46 -05:00
Jorge Manrubia 9b4fec936e Move mentions to comments
- It does not make sense to scan "event summaries" for notifications.
- Placing them at the message level prevents us from using the generic approach to extract the mentionable content
2025-04-22 16:17:37 +02:00
David Heinemeier Hansson 3d28203224 Use singular staging resource and beef up testing 2025-04-22 14:44:55 +02:00
Jorge Manrubia 3bf73a0b71 Rename to match actual action 2025-04-22 14:22:23 +02:00
Jorge Manrubia 4f06473405 Notifications for mentions showing up 2025-04-22 12:02:48 +02:00
David Heinemeier Hansson 22abf0ba46 Remove anemic concern
Colors are a card concern.
2025-04-22 11:56:41 +02:00
Jorge Manrubia aa3acfeaa8 Add plain text mentions 2025-04-22 11:26:56 +02:00
Jorge Manrubia b0aae3ad9e Reapply "Add a description field for cards"
This reverts commit a4cc143b09.
2025-04-21 16:45:24 +02:00
Jorge Manrubia a4cc143b09 Revert "Add a description field for cards" 2025-04-21 16:41:33 +02:00
David Heinemeier Hansson 9e921b85c0 Merge branch 'main' into add-card-description 2025-04-19 20:00:43 +02:00
David Heinemeier Hansson 247524da29 Stlye 2025-04-18 16:47:53 +02:00
David Heinemeier Hansson c6f363c281 Style 2025-04-18 16:42:35 +02:00
Jason Zimdars 026020c06e Restore drafted card state 2025-04-17 18:07:39 -05:00
David Heinemeier Hansson 461c104ac2 Extract helper method to keep partial at a uniform level of abstraction 2025-04-17 15:42:07 +02:00
David Heinemeier Hansson 73f272f132 Use one controller for all notification readings 2025-04-15 19:14:50 +02:00
Kevin McConnell 028a43e652 Title is on the related card 2025-04-14 15:50:24 +01:00
Andy Smith a88264ed0a Merge branch 'main' into consolidate-cards
* main: (94 commits)
  Source order seems to be significant
  Use `card.title`
  Nicer flow
  Fix string interpolation
  Fix constant
  Use record lookup
  Always use sole
  Explained less and extracted nothing of value
  Weird double negative
  Remove anemic and indirect method that explained nothing
  Can use record lookup for workflows
  Access control has already been done through the card
  Style
  Use _path in all cases where we are not potentially changing the domain
  Clearer
  Spacing
  Get rid of card_title
  Join the two users controllers but split out role setting
  Ensure user is returned
  We are not using the parameter
  ...
2025-04-14 09:40:22 -05:00
Jason Zimdars 3cfdaf1129 Use card.title 2025-04-14 08:54:54 -05:00
David Heinemeier Hansson 80c518b7e1 Fix string interpolation 2025-04-13 20:36:16 +02:00
David Heinemeier Hansson cf93da6886 Get rid of card_title
We can just set untitled on assignment of empty
2025-04-12 21:29:56 +02:00
David Heinemeier Hansson 760cbb6c99 Drop boosts
Killed by design.
2025-04-12 18:52:54 +02:00
David Heinemeier Hansson 120e8da1d5 Unused 2025-04-12 14:14:34 +02:00
David Heinemeier Hansson 4723b7b504 Style 2025-04-12 14:13:20 +02:00
David Heinemeier Hansson 6f3ac772ea Merge branch 'main' into comments-refactoring
* main:
  Show more of the summary before truncating
  Improve event summaries
  Add this for debugging empty event cards
  Some actions shouldn't be available to closed cards
  Nicer spacing when the large button isn't present
  Update `card-color` in a couple more places
  Don't show the engagement toggle on closed cards
  Show more of the summary before truncating
  Improve event summaries
  Remove shadows from notifications you can't see
  Add this for debugging empty event cards
  Some actions shouldn't be available to closed cards
  Nicer spacing when the large button isn't present
  Update `card-color` in a couple more places
  Don't show the engagement toggle on closed cards
  Style drafted cards
  Considering needs to include drafted cards or you'll never be able to see them
  This item makes no sense until it's saved
  Tighten engagement switch design, only display it for published cards
2025-04-12 09:56:28 +02:00
Andy Smith 75a46356cc Merge branch 'main' into consolidate-cards
* main:
  Show more of the summary before truncating
  Improve event summaries
  Add this for debugging empty event cards
  Some actions shouldn't be available to closed cards
  Nicer spacing when the large button isn't present
  Update `card-color` in a couple more places
  Don't show the engagement toggle on closed cards
  Show more of the summary before truncating
  Improve event summaries
  Remove shadows from notifications you can't see
  Add this for debugging empty event cards
  Some actions shouldn't be available to closed cards
  Nicer spacing when the large button isn't present
  Update `card-color` in a couple more places
  Don't show the engagement toggle on closed cards
2025-04-11 15:38:57 -05:00
Jason Zimdars 188ebc3110 Improve event summaries 2025-04-11 13:21:47 -05:00
Andy Smith c853d3c570 Merge branch 'main' into consolidate-cards
* main: (31 commits)
  Style drafted cards
  Considering needs to include drafted cards or you'll never be able to see them
  This item makes no sense until it's saved
  Tighten engagement switch design, only display it for published cards
  Needed to come first
  In order of appearance
  Schema movement -- is this because the dumper doesnt sort deterministically? cc @flavorjones
  Move comments under cards
  Fix indention
  Refresh timers when morphing happens
  Extract helper for card articles, use classes to determine when to show golden status
  Only consider golden those cards in "doing"
  Fix recently completed order for good!
  Place recently closed cards first
  Monkey patch a prepend_order method
  Rename inconsistency: go with goldness
  Touch
  Use gild/ungild
  Format
  Fix test
  ...
2025-04-11 12:43:05 -05:00
David Heinemeier Hansson 6effc1568f No need for a separate body partial 2025-04-11 18:41:26 +02:00
Jorge Manrubia 825bbf808e Extract helper for card articles, use classes to determine when to show golden status 2025-04-11 12:01:52 +02:00
Jorge Manrubia aef75feead Only consider golden those cards in "doing" 2025-04-11 11:49:52 +02:00
Andy Smith 70a59eb341 WIP pins 2025-04-10 17:42:17 -05:00
Jason Zimdars e4110734eb Rework min card design and meta section for all cards 2025-04-10 14:39:50 -05:00
Jason Zimdars 7fdf9ab2fd Move title to the img element so we get hover in both cases 2025-04-10 14:39:19 -05:00
Jason Zimdars 84276e85ba Ensure overflow cards are hidden 2025-04-10 09:43:09 -05:00
Jorge Manrubia c7b3b45977 Merge pull request #391 from basecamp/cards-pagination-2
Paginate collection cards
2025-04-10 15:10:54 +02:00
Jorge Manrubia 695247ae9b Paginate collection cards 2025-04-10 15:09:56 +02:00
Jorge Manrubia ced24d8a7c Reuse existing constant 2025-04-10 12:32:28 +02:00
Jason Zimdars f9fb633cba Add colors to stages 2025-04-09 15:45:08 -05:00
Jason Zimdars c55501a6c8 Remove unused display count feature 2025-04-09 14:54:53 -05:00
Jason Zimdars 60890b10ee Remove translations feature 2025-04-09 14:11:32 -05:00
Jorge Manrubia 723e6d94f5 Rename bubbles => cards 2025-04-09 14:50:58 +02:00
Andy Smith e8f85df720 Merge branch 'main' into cascade-layers-2
* main: (104 commits)
  Default collection permissions to "all access"
  dep: update active_record-tenanted to 8758240b
  dep: bump Rails to 32d96235
  Test for `Bubbles::RecoversController`
  Move readings under bubbles and out of double nesting
  Move bubble stagings out from double nesting
  Correct alpha ordering
  Fix indention
  Move bubble recovery out from double nesting
  Move bubbles publish out from the double nesting
  Move bubble pops out from double nesting
  Move controller to delete bubble image out from double nesting under bucket
  Revert "Scope searches by user"
  Scope searches by user
  Few more lazy loading avatars!
  Another lazy loading point
  Remove double nesting under bubbles for engagement
  Lets just preload all avatars for now
  No need for an array when there is only one dependency
  Scope data by account
  ...
2025-04-07 14:15:55 -05:00
David Heinemeier Hansson bcd6c6dd66 Move bubble stagings out from double nesting 2025-04-07 14:00:30 +02:00
David Heinemeier Hansson 28c106fd83 Fix indention 2025-04-07 13:58:41 +02:00
Jorge Manrubia 67398926df Prefer aria-label 2025-04-07 12:54:37 +02:00
Jorge Manrubia 8d7d8e76f2 Avoid # since it confuses screen readers 2025-04-07 12:45:53 +02:00
Jorge Manrubia a7aae833d1 Extract helper with fallback for the "go to back" and use consistently 2025-04-07 11:28:03 +02:00
David Heinemeier Hansson 5134985418 Simplify the assignments flow
We now submit on every selection, so we dont need a whole form and
checkboxes to do it.

This needs some design tune-up after the change, though. cc @jzimdars
2025-04-05 17:14:57 +02:00
David Heinemeier Hansson 64c00aea30 Extract helper for bubble_assignee_checkbox 2025-04-05 16:20:31 +02:00