Commit Graph

1191 Commits

Author SHA1 Message Date
Jason Zimdars dc1d920379 Use black for closed cards only 2025-05-02 15:39:10 +02:00
Jorge Manrubia 7478e7692f Fix condition in callback 2025-05-01 13:11:23 +02:00
Jorge Manrubia 75bc2460ae Reapply "Move condition to the callback"
This reverts commit db50b643b3.
2025-05-01 13:11:01 +02:00
Jorge Manrubia db1a9d8b45 Reapply "Set default "Untitled" title for published cards"
This reverts commit 448989bfa2.
2025-05-01 13:10:58 +02:00
Jorge Manrubia 448989bfa2 Revert "Set default "Untitled" title for published cards"
This reverts commit ca1e002806.
2025-05-01 13:10:36 +02:00
Jorge Manrubia db50b643b3 Revert "Move condition to the callback"
This reverts commit 7b6de076e3.
2025-05-01 13:10:34 +02:00
Jorge Manrubia 7b6de076e3 Move condition to the callback 2025-05-01 13:09:42 +02:00
Jorge Manrubia ca1e002806 Set default "Untitled" title for published cards 2025-05-01 13:08:15 +02:00
Jorge Manrubia 0045e48f70 Don't notify yourself of self-assignments 2025-05-01 12:57:25 +02:00
Andy Smith 6c7de54137 Rename 'badge' to 'bubble' 2025-05-01 11:19:58 +02:00
Andy Smith 0d086cd39e Merge branch 'main' into closing-soon-badge 2025-05-01 09:59:42 +02:00
Andy Smith 78941e5068 Address PR feedback 2025-05-01 09:58:23 +02:00
Jorge Manrubia d9acafcb64 New line 2025-04-30 11:05:58 +02:00
Jorge Manrubia c349f52aec Not used 2025-04-30 10:22:23 +02:00
Jorge Manrubia 174bb21b8a Drop event summaries too
We'll regenerate with a script
2025-04-30 09:55:29 +02:00
Jorge Manrubia e1347bec3f Extract method 2025-04-30 09:47:05 +02:00
Jorge Manrubia b6c3e5c090 Add tests and clean unused events 2025-04-30 09:45:41 +02:00
Jorge Manrubia 6f06fb2277 Format 2025-04-30 08:25:06 +02:00
Jorge Manrubia c7893aa24d Remove default chronological order 2025-04-30 08:24:22 +02:00
Jorge Manrubia 9edffe2170 Format 2025-04-29 20:39:55 +02:00
Jorge Manrubia 4ff55df2e0 Create system comments on events 2025-04-29 20:33:07 +02:00
Jorge Manrubia 2b98db9e66 Flatten out comments and messages
https://37s.fizzy.37signals.com/collections/693169850/cards/999008989#comment_994777841
2025-04-29 19:21:18 +02:00
Jason Zimdars 137a16a810 Move to concern 2025-04-26 19:26:34 -05:00
Jorge Manrubia 82885e453d Not needed anymore 2025-04-26 09:13:24 +02:00
Jorge Manrubia 685c1f4aca Reorder methods 2025-04-25 20:04:04 +02:00
Jorge Manrubia 0056cafa04 Merge pull request #436 from basecamp/configure-auto-close
Configure the autoclose period for collections
2025-04-25 19:55:19 +02:00
Jorge Manrubia 5e279ab2e1 Fix: dismiss notifications from comments 2025-04-25 19:52:09 +02:00
Jorge Manrubia e90b062440 Configure the autoclose period at the collection level 2025-04-25 13:29:16 +02:00
Jorge Manrubia 5a431ba6bb Collections can be private now too 2025-04-25 10:31:41 +02:00
Jorge Manrubia b866267192 Not used outside the class anymore 2025-04-25 10:28:39 +02:00
Jorge Manrubia 54d7327ccd Merge branch 'main' into events-revamp
* main:
  Account for stages where the color isn't set
  Choose workflows from a small preview
  Add missing filter display classes, style input
  Scroll users list, adjust layout
  Workflows and card perma polish
  Type polish and sizing constraints
  dep: AR::Tenanted: no implicit db migrations
  New layout for collections settings, stub entropy setting
  Adjust collection line to contrast with comment excerpts
  Adjust perma layout for larger cards
  Give the timeline a little space on each side
2025-04-25 09:41:29 +02:00
Jason Zimdars dca5e3b942 New layout for collections settings, stub entropy setting 2025-04-24 12:56:14 -05:00
Jorge Manrubia 331fdc05f6 Format 2025-04-24 15:20:08 +02:00
Jorge Manrubia 40368032f2 Split notifiers for comments and cards
This lets us remove the annoying if to check the card
2025-04-24 15:19:42 +02:00
Jorge Manrubia ccb72ad229 Rename for consistency with what we had for comments 2025-04-24 14:51:25 +02:00
Jorge Manrubia 4183a5a32c Remove unneeded transaction 2025-04-24 14:49:48 +02:00
Jorge Manrubia 27f6006b58 Does not belong here anymore 2025-04-24 13:48:53 +02:00
Jorge Manrubia 905ccb9b4b Make comments the event's host 2025-04-24 13:45:48 +02:00
Jorge Manrubia 18cc24e1d3 Add an event prefix named after the model now that events are generic 2025-04-24 13:20:09 +02:00
Jorge Manrubia b746987712 Make eventable a generic concern and create a card's especialization for it 2025-04-24 13:07:12 +02:00
Jorge Manrubia aee7f4f886 Not used 2025-04-24 12:34:33 +02:00
Jorge Manrubia 13b0c0fc41 First pass to tidy up activity time rendering 2025-04-24 12:28:16 +02:00
Jorge Manrubia 965100df51 Access events through collections 2025-04-24 12:28:16 +02:00
Jorge Manrubia 54f4bd5144 Generalize event's cards as eventable,add collection
Lots to tidy up but this is working
2025-04-24 12:28:16 +02:00
Jorge Manrubia e8e3bd16a6 First step to make events more generic in nature 2025-04-24 12:28:16 +02:00
Jorge Manrubia f166b30f2f Fix: dismiss mention notifications in cards and comments when reading a card 2025-04-24 12:19:20 +02:00
Jorge Manrubia 3793718e72 Fix concern I lost during merge 2025-04-23 17:25:36 +02:00
Jorge Manrubia b08326ccbe Merge branch 'main' into plain-text-mentions
* main: (48 commits)
  Improve layout and truncation
  This is annoying
  Fix summary
  Remove index columns
  Same treatment for the events index
  New menu filters and navigates
  Don't test for _Added by_ events
  Indention
  @collection is always available when card scoped
  Style
  Remove check for _Added by..._ line
  The placeholder attribute is on the `house-md` element
  Duh, no before destroy commit, but this is still not right!
  No long transactions!
  Don't display published event in threads
  But feels more essentially part of the User, so list first
  Not related to the other two
  Missing controller
  Style
  Errant `bubbles` => `cards` replacement
  ...

# Conflicts:
#	app/models/card.rb
#	app/models/user.rb
#	db/schema.rb
#	db/schema_cache.yml
2025-04-23 17:24:01 +02:00
Jorge Manrubia 5749ad77e5 Rename classes 2025-04-23 16:19:50 +02:00
Jorge Manrubia f258b05b23 Delegate target to the notifiable objects 2025-04-23 16:19:50 +02:00