Commit Graph

193 Commits

Author SHA1 Message Date
Jason Zimdars 4433e80691 Make steps non-interactive 2025-07-09 10:56:32 -05:00
Jason Zimdars 9ac5f46875 This shouldn't ever appear on the index, we have a preview partial 2025-07-09 10:44:53 -05:00
Jason Zimdars f1337048bd This shouldn't need to be here, it would never be displayed and does nothing 2025-07-09 10:42:03 -05:00
Jason Zimdars 8f7a373aad Public card templates 2025-07-09 10:16:39 -05:00
Jason Zimdars 485e575c40 Merge branch 'main' into card-attachments
* main: (45 commits)
  Display tag counts in the filter menu
  Move Add Card button to header
  Re-write help content, try a modal-like display
  Move to internal registry
  Show date instead of time for notifications older than 1 day
  Ensure checks are visible for tags and assignments
  Adjust padding so card number isn't cut off
  Don't color the collection header in considering
  Golden cards bubble to the top of Considering, too
  Adjust card collection header when colored golden
  Allow cards in Considering to gilded
  Hide focus ring on new card titles and step inputs
  Add hover effect for comment edit button
  Add hover effect to overflow button
  Improve multi-account behavior of the PWA
  Remove unneeded *
  Rename test
  Review the code to move cards
  Update editor
  Generalize and delete mentions too
  ...
2025-07-08 16:04:14 -05:00
Andy Smith 6e2eacd3d8 Hide focus ring on new card titles and step inputs 2025-07-07 13:23:19 -05:00
Andy Smith f9c7862fc1 Add hover effect for comment edit button 2025-07-07 10:12:32 -05:00
Jason Zimdars cf4c6dba9c Indicate cards with attachments in the description 2025-07-03 15:56:25 -05:00
Andy Smith 757ff4ff2b Merge branch 'main' into focus-hover-styles 2025-07-03 15:14:14 -05:00
Andy Smith 5c2997422f Address PR feedback 2025-07-03 15:00:12 -05:00
Jason Zimdars aff0a38b37 Move to scope and inline method 2025-07-02 16:14:25 -05:00
Jason Zimdars 25a33fb9c8 Merge branch 'main' into card-steps
* main: (22 commits)
  Fix that stage should be visible above card background
  Indicate opens menu
  Hide dialog targets from screen readers when closed
  Mark up as heading for screen reader navigation
  Copy for screen readers
  Don't hide the input so it's accessible to screen readers
  Point skip links to correct anchor, don't navigate with turbo
  There aren't any `li` children so just use `div`
  Use headings for screen reader navigation
  Use `h3` for individual cards in collection view
  Make collection title `h1` for screen reader navigation
  Esc should not propagate when closing dialogs
  squash! Remove session controller actions other than delete
  Screen reader: Use heading for comments navigation
  Remove the invitation codes for now
  Remove session controller actions other than delete
  Correct label for field
  Style
  Screen reader: De-duplicate links for each person in account settings
  Account.signal_account is no longer optional
  ...
2025-07-02 16:09:49 -05:00
Jason Zimdars 70d6a7190f Use h3 for individual cards in collection view 2025-07-02 14:42:53 -05:00
Jason Zimdars f02215c5b7 Add steps to cards 2025-07-01 20:05:20 -05:00
Jason Zimdars ffb422ac61 This attribute is no longer needed 2025-06-30 17:31:07 -05:00
Jason Zimdars 3af949edca Merge branch 'main' into filter-ignore-diacritics
* main:
  Clear the comments cache
  Add context for search screens
  Needs changed for both states
  Use lighter icon and update asset
  Add btn--circle class to user edit form
  Organize button variants
  Untangle `avatar btn` crossover styles
  Remove redundant classes and styles for avatars
  Adjust footer line height
  Tweak padding
2025-06-30 17:01:43 -05:00
Andy Smith be003cd3f7 Remove redundant classes and styles for avatars 2025-06-30 14:00:59 -05:00
Jason Zimdars 2678f8c099 Convert diacritics to approximations before filtering
- Introduces a helper method for setting the filterable value
- Updates `filter_controller.js` to use `data-filter-text-value` attribute populated with converted content. This was previous `data-value` in the earlier implementation but ignored in the current on.
- Also uses the same helper to make @mentions diacritic insensitive
2025-06-30 13:53:50 -05:00
Andy Smith c087ceee52 Properly close the span 2025-06-24 15:29:41 -05:00
Jason Zimdars c2b92fd4f5 DRY this up 2025-06-19 20:42:11 -05:00
Jason Zimdars c59a99fa68 Only display workflows when the card is in Doing 2025-06-19 13:35:20 -05:00
Jorge Manrubia 6907d07d07 Don't choke when a card is missing its stage
This can happen if the stage was destroyed
2025-06-19 08:25:48 +02:00
Jason Zimdars cc407f6198 Rework truncation so tag and collection menus display correctly 2025-06-17 16:26:54 -05:00
Jason Zimdars 975bbe2385 Render stage inline so it doesn't overlap collection name
Allows truncation of collection name to fit stage name
2025-06-17 15:11:21 -05:00
Jason Zimdars ba7cef801a Band aid for dialog inside overflow elements 2025-06-16 20:44:25 -05:00
Jason Zimdars 73b3442e96 Make cards resilient to long collection names 2025-06-16 19:53:55 -05:00
Jason Zimdars 2b74ece8b3 Merge branch 'main' into add-cards-in-more-places
* main: (34 commits)
  Opt out of writer affinity on readings controller
  Enable VFS, but don't load extension again
  Add flash notice when adding another card
  Fix tests after updating rails
  Fix fixtures after updating gem
  Make sure you can't drag drafts
  Fix clipped tag selector
  Don't miss cards dropped in the same container!
  Make sure that only cards in do/considering are draggable
  Add test
  Add test
  Use the same controller for publishing cards and for publishing and adding another
  Position Completed stamps better
  Bump sentry-rails from 5.24.0 to 5.25.0
  Bump rails from `0ac3fba` to `fd49d6a`
  Bump sentry-ruby from 5.24.0 to 5.25.0
  Add multiple cards quickly
  Tweak a little more
  Tighter bubbles on small screens
  Need a little space in the layout for the drag/drop outline
  ...
2025-06-16 12:13:38 -05:00
Jorge Manrubia 50b20c4099 Make sure you can't drag drafts 2025-06-13 10:25:48 +02:00
Jorge Manrubia 303a3faea1 Merge pull request #607 from basecamp/drag-and-drop-cards
Drag and drop cards to move between doing/considering
2025-06-13 10:04:59 +02:00
Jorge Manrubia 69263766ec Make sure that only cards in do/considering are draggable
Not in complete, not in the event timeline
2025-06-13 10:02:31 +02:00
Jason Zimdars f79f51b1e3 Don't navigate, activate the menu 2025-06-12 15:43:03 -05:00
Jorge Manrubia f58aaadba5 Drag and drop cards to move between doing/considering 2025-06-12 11:57:53 +02:00
Andy Smith 4beeb60484 Closing cards on mobile 2025-06-11 11:42:36 -05:00
Jason Zimdars 319050fe94 Merge branch 'main' into public-collections
* main:
  Zoom background on perma
  Flip hover behavior between collection and perma
2025-06-10 10:47:36 -05:00
Jorge Manrubia e5f7d252fe Create dedicate templates for card previews
To remove links and customize as we need to
2025-06-10 10:17:19 +02:00
Jason Zimdars c7cc4fb286 Zoom background on perma 2025-06-09 16:30:12 -05:00
Jorge Manrubia 15d3c0e724 Simplify since the design is identical 2025-06-06 09:19:51 +02:00
Jorge Manrubia f742749b0f Tidy up controller and make sure the different targets are properly separated
If not, it wouldn't show stalled if there were entropy bubbles in the page
2025-06-06 09:15:51 +02:00
Jorge Manrubia 6287acf5ba Tidy up controller
Remove namespace "entropy" since the regions are common now
2025-06-06 09:04:42 +02:00
Jason Zimdars 9d706902e8 Style stalled bubble 2025-06-05 16:25:21 -05:00
Jorge Manrubia 19e27370fa Stimulus can't handle "null" JSON string 2025-06-05 11:10:09 +02:00
Jorge Manrubia fbe12014ab Format 2025-06-05 11:08:37 +02:00
Jorge Manrubia 6e8087ee2e Toggle entropy/stalled container in the bubbles controller 2025-06-05 11:08:20 +02:00
Jorge Manrubia 76119b17bd Entropy, not bubble! 2025-06-05 10:33:02 +02:00
Jorge Manrubia 22ed605884 Namespace bubble-related targets 2025-06-05 10:32:14 +02:00
Jorge Manrubia 2cbd451944 Group entropy options in an object value
We'll add stalling considerations next, this helps keeping things organized.
2025-06-05 10:28:33 +02:00
Jorge Manrubia 5dc33c304c Restore reminder period I replaced by mistake 2025-06-04 17:17:47 +02:00
Jorge Manrubia a6ffbf7ec6 Rename method 2025-06-04 14:56:19 +02:00
Jorge Manrubia db86d17880 Refactor to introduce an entropy model
Instead of keeping two tracks of similar logic (auto-reconsider / auto-close).
2025-06-04 14:40:02 +02:00
Jorge Manrubia e8249d2405 Consider the new default settings for previews 2025-06-04 13:13:45 +02:00