Commit Graph

58 Commits

Author SHA1 Message Date
Jorge Manrubia 4527dcbeda Remove unnecessary filtering code
After removing collections from the filtering menu, there was quite a good cleanup here pending
2025-10-03 10:56:34 +02:00
Jorge Manrubia 0347806ce1 Fix: Keep the previous filtering when navigating back from cards
https://fizzy.37signals.com/5986089/cards/1760/edit

This also adds a proper resource for filtered collections, instead of changing the URL to cards for filtering cards.
2025-09-30 15:48:56 +02:00
Andy Smith 58c0314c17 Merge branch 'main' into tooltip-orient
* main: (161 commits)
  Save expanded state to localStorage
  Update seeds to use the workflow stages
  Disable autocomplete when editing columns
  Reset column form and disable autocomplete
  Remove unused job
  Fix Stream workflow stage BG
  We need the grid layout when filtering events
  Fix: proper filtering by collection in the collection perma
  Fix test
  Fix test
  Position expander menu
  Use parent layout when using with_manual_pagination
  Reinstate gap to cards list
  Fix: include collection filter in the collection perma
  Add some basic caching for the new columns approach
  Format
  Fix tests
  No need to use extra method here
  Move actions to stream templates
  Prevent recursive loop now that we have nested frames
  ...
2025-09-29 13:55:33 -05:00
Jorge Manrubia aa9d7664ef Move cards to different columns from the perma 2025-09-26 11:14:02 +02:00
Andy Smith b82c6e9102 Use data-controller instead of class for tooltip CSS 2025-09-22 16:58:57 -05:00
Andy Smith 3d5bdc64f4 Add JS controller to existing tooltips 2025-09-22 16:50:07 -05:00
Andy Smith ccd18def01 Merge pull request #1080 from basecamp/print-styles
Print styles
2025-09-10 16:29:50 -05:00
Andy Smith 22f9c9d168 WIP 2025-09-10 12:15:31 -05:00
Jorge Manrubia 4e72566856 Flatten card resource
We only need the parent collection for creating cards. Carrying it in the
rest of actions is a hassle.
2025-09-10 11:24:23 +02:00
Jason Zimdars 457725d597 Fix rendering and introduce a new style 2025-09-02 20:11:34 -05:00
Andy Smith bb04512b0c Consolidate header and nav layouts 2025-08-27 13:48:47 -05:00
Jorge Manrubia 42c8bb89e5 Use the unified filter for cards/show 2025-08-21 14:25:02 +02:00
Andy Smith 49d3b900bf Add tooltips to icon buttons 2025-08-07 15:28:45 -05:00
Jason Zimdars 7d77f014a2 Only connect lightbox controller where the partial is present
- Fixes a console error that complained the dialog target was missing
2025-08-06 17:38:45 -05:00
Andy Smith 38be44dd11 Move lightbox to cards/show so we can use it for description and Lexical images 2025-08-04 16:11:43 -05:00
Andy Smith c6587a0562 Better truncation for header__titles 2025-07-30 12:25:03 -05:00
Jason Zimdars 6b6cec3026 Add open graph tags for unfurling private URLs, too 2025-07-28 16:59:44 -05:00
Stanko K.R. 66a8d35060 Fix typo in the card recovery message 2025-07-24 15:26:26 +02:00
Andy Smith fdbb9c185e Merge branch 'main' into collection-nav
* main: (203 commits)
  Re-write help content, try a modal-like display
  Move to internal registry
  Show date instead of time for notifications older than 1 day
  Ensure checks are visible for tags and assignments
  Adjust padding so card number isn't cut off
  Don't color the collection header in considering
  Golden cards bubble to the top of Considering, too
  Adjust card collection header when colored golden
  Allow cards in Considering to gilded
  Hide focus ring on new card titles and step inputs
  Add hover effect for comment edit button
  Add hover effect to overflow button
  Improve multi-account behavior of the PWA
  Remove unneeded *
  Rename test
  Review the code to move cards
  Update editor
  Generalize and delete mentions too
  Remove unused code
  Make sure we don't remove accesses if collection is accessible
  ...
2025-07-08 15:34:01 -05:00
Andy Smith 5c2997422f Address PR feedback 2025-07-03 15:00:12 -05:00
Andy Smith a27331409e Consolidate Add card buttons 2025-06-26 15:32:33 -05:00
Jason Zimdars 67087f2967 Bring back hotkey for returning to collection 2025-06-18 11:26:42 -05:00
Jason Zimdars b91ba6d8ef Add Fizzy menu to card perma 2025-06-12 16:46:01 -05:00
Jason Zimdars a55c111737 Fix typo, move to peer element 2025-06-12 15:51:15 -05:00
Jason Zimdars fc19a74e49 Add an obvious link to the collection 2025-06-12 15:39:38 -05:00
Jason Zimdars 7355b09382 Expose button so you can delete drafts 2025-06-03 17:48:08 -05:00
Jorge Manrubia b0aae3ad9e Reapply "Add a description field for cards"
This reverts commit a4cc143b09.
2025-04-21 16:45:24 +02:00
Jorge Manrubia a4cc143b09 Revert "Add a description field for cards" 2025-04-21 16:41:33 +02:00
Jason Zimdars e51dc10dc5 Remove draft comments 2025-04-17 18:07:56 -05:00
David Heinemeier Hansson d019e282ae Better name 2025-04-17 15:00:14 +02:00
David Heinemeier Hansson f24287915f Extract partials that can be rerendered 2025-04-17 14:52:35 +02:00
David Heinemeier Hansson 0c743d27a8 There is no more/less flicker with morphing
Where did you see the flickering that this solved, @jorgemanrubia?
2025-04-17 13:42:49 +02:00
David Heinemeier Hansson b5d6d40462 Use domain language termn 2025-04-17 13:42:23 +02:00
David Heinemeier Hansson bf99da8914 Style 2025-04-17 13:33:45 +02:00
David Heinemeier Hansson ac65f39c0d Inline anemic partial 2025-04-15 16:32:56 +02:00
Andy Smith a88264ed0a Merge branch 'main' into consolidate-cards
* main: (94 commits)
  Source order seems to be significant
  Use `card.title`
  Nicer flow
  Fix string interpolation
  Fix constant
  Use record lookup
  Always use sole
  Explained less and extracted nothing of value
  Weird double negative
  Remove anemic and indirect method that explained nothing
  Can use record lookup for workflows
  Access control has already been done through the card
  Style
  Use _path in all cases where we are not potentially changing the domain
  Clearer
  Spacing
  Get rid of card_title
  Join the two users controllers but split out role setting
  Ensure user is returned
  We are not using the parameter
  ...
2025-04-14 09:40:22 -05:00
David Heinemeier Hansson cf93da6886 Get rid of card_title
We can just set untitled on assignment of empty
2025-04-12 21:29:56 +02:00
David Heinemeier Hansson 6f3ac772ea Merge branch 'main' into comments-refactoring
* main:
  Show more of the summary before truncating
  Improve event summaries
  Add this for debugging empty event cards
  Some actions shouldn't be available to closed cards
  Nicer spacing when the large button isn't present
  Update `card-color` in a couple more places
  Don't show the engagement toggle on closed cards
  Show more of the summary before truncating
  Improve event summaries
  Remove shadows from notifications you can't see
  Add this for debugging empty event cards
  Some actions shouldn't be available to closed cards
  Nicer spacing when the large button isn't present
  Update `card-color` in a couple more places
  Don't show the engagement toggle on closed cards
  Style drafted cards
  Considering needs to include drafted cards or you'll never be able to see them
  This item makes no sense until it's saved
  Tighten engagement switch design, only display it for published cards
2025-04-12 09:56:28 +02:00
Jason Zimdars c5fc847372 Update card-color in a couple more places 2025-04-11 13:21:47 -05:00
Jason Zimdars a76488fd49 Don't show the engagement toggle on closed cards 2025-04-11 13:21:47 -05:00
Andy Smith c853d3c570 Merge branch 'main' into consolidate-cards
* main: (31 commits)
  Style drafted cards
  Considering needs to include drafted cards or you'll never be able to see them
  This item makes no sense until it's saved
  Tighten engagement switch design, only display it for published cards
  Needed to come first
  In order of appearance
  Schema movement -- is this because the dumper doesnt sort deterministically? cc @flavorjones
  Move comments under cards
  Fix indention
  Refresh timers when morphing happens
  Extract helper for card articles, use classes to determine when to show golden status
  Only consider golden those cards in "doing"
  Fix recently completed order for good!
  Place recently closed cards first
  Monkey patch a prepend_order method
  Rename inconsistency: go with goldness
  Touch
  Use gild/ungild
  Format
  Fix test
  ...
2025-04-11 12:43:05 -05:00
Jason Zimdars ee8559343a Tighten engagement switch design, only display it for published cards 2025-04-11 11:50:09 -05:00
David Heinemeier Hansson 7861b7c087 Just open one turbo stream per card
Per comment is excessive and needless
2025-04-11 17:58:11 +02:00
Jason Zimdars 5560976091 Merge branch 'main' into gold-cards
* main:
  Try a segmented toggle for engagement
  Fix tests
  Rework min card design and meta section for all cards
  Move `title` to the `img` element so we get hover in both cases
  Remove sorting filter UI
  Sort Considering and Doing by `updated_at`
  Restore comment action icon
  Fix dot escaping container
  Seen cards should be flat
  Ensure overflow cards are hidden
  Arrow needs to match derived color
  Dialog target needs to be present
  This isn't necessary in the mini card template
  Revert "The button and dialog need not render in previews"
2025-04-10 16:42:45 -05:00
Jason Zimdars 81ee2ab64d Try a segmented toggle for engagement 2025-04-10 16:06:35 -05:00
Andy Smith 7c3c3a9ef5 Less space above card-perma 2025-04-10 15:44:45 -05:00
Andy Smith 74d1571b19 Merge branch 'main' into consolidate-cards
* main: (45 commits)
  Fix tests
  Rework min card design and meta section for all cards
  Move `title` to the `img` element so we get hover in both cases
  Remove sorting filter UI
  Sort Considering and Doing by `updated_at`
  Restore comment action icon
  Fix dot escaping container
  Seen cards should be flat
  Ensure overflow cards are hidden
  Arrow needs to match derived color
  Dialog target needs to be present
  This isn't necessary in the mini card template
  Revert "The button and dialog need not render in previews"
  Paginate collection cards
  Add a rails helper for the new custom stream action
  Add test
  Reflect picked color automatically with a custom stream action
  Simplify conditions to pick up a color
  Reuse existing constant
  Update fixtures and test
  ...
2025-04-10 15:12:38 -05:00
Andy Smith 8429669bf5 WIP card columns 2025-04-10 14:56:52 -05:00
Andy Smith 59798124cb Extract doing toggle into partial 2025-04-10 13:22:06 -05:00
Andy Smith f319c22f62 Use grid for card-container 2025-04-10 13:02:38 -05:00