Commit Graph

583 Commits

Author SHA1 Message Date
Andy Smith c6587a0562 Better truncation for header__titles 2025-07-30 12:25:03 -05:00
Jason Zimdars 6b6cec3026 Add open graph tags for unfurling private URLs, too 2025-07-28 16:59:44 -05:00
Andy Smith ece1751538 Merge pull request #805 from basecamp/bold-event-actions
Update system message to highlight verbs
2025-07-28 13:23:34 -05:00
Jason Zimdars d3a01cf9bb Dialog target needs to be in the DOM on connect
Moves it out of the turbo frame so it's available even when empty
2025-07-24 14:58:52 -05:00
Andy Smith 8e795f183d Update system message to highlight verbs 2025-07-24 13:42:19 -05:00
Stanko K.R. 66a8d35060 Fix typo in the card recovery message 2025-07-24 15:26:26 +02:00
Andy Smith 9489e23fc4 Add margins to the input instead of a wrapper. 2025-07-22 14:32:43 -05:00
Andy Smith 424b33979c Removed redundant div 2025-07-22 14:29:05 -05:00
Andy Smith 67df61b57d Dry up utility classes for popup__group 2025-07-21 13:59:33 -05:00
Andy Smith 7e0df47c8f Same padding for all popup__items 2025-07-21 13:38:08 -05:00
Andy Smith 37cc6a6955 popup__items full-width by default 2025-07-21 13:37:33 -05:00
Andy Smith d3db752f39 Remove redundant flex-grow class from popup__items 2025-07-21 13:35:24 -05:00
Andy Smith 1e62ae8c94 Set min-width on popup__items 2025-07-21 13:32:56 -05:00
Jason Zimdars 468a29c9ad Give them screen reader labels
See: https://fizzy.37signals.com/5986089/collections/2/cards/1106
2025-07-16 11:33:33 -05:00
Jason Zimdars f0235e7e07 Not needed
See: https://fizzy.37signals.com/5986089/collections/2/cards/1108
2025-07-16 11:08:06 -05:00
Jason Zimdars 70c2cc62a1 Merge branch 'main' into public-collection-cards
* main:
  Revert "Adjust borders"
  Don't allow wrapping initially
  Adjust borders
  Truncate long commands
  Try using env safe insets to avoid overlapping elements on mobile
  Correct asset width and remove caption input focus ring
  Revert "Make a focus-ring global variable"
  Make a focus-ring global variable
  Set `id` explicitly so the `label for` reference works
  Higher resolution image
  When adding a card out of context, default to most recently accessed collection
  Fine tuning to handle different attachment types
  Replace helper with view lookup
  Make nil safe
  Extract attachments to a partial
  Remove `card_published` check and render its own template
  Extract common concern to examine attachments
  This is a hack but we should be showing the card description and attachments for new cards
  Display attachments in events for comments
  Indicate cards with attachments in the description
2025-07-10 16:33:51 -05:00
Jorge Manrubia 81560c73dd Use existing direct route 2025-07-10 14:57:20 +02:00
Jason Zimdars 7a058a18d9 Merge branch 'main' into card-attachments
* main:
  Add circle-on-mobile button class
2025-07-09 11:22:41 -05:00
Jason Zimdars a60eedf186 Merge branch 'main' into public-collection-cards
* main:
  Add circle-on-mobile button class
2025-07-09 11:20:41 -05:00
Jason Zimdars 55f92e73f7 Not needed here 2025-07-09 11:08:09 -05:00
Jason Zimdars 4433e80691 Make steps non-interactive 2025-07-09 10:56:32 -05:00
Jason Zimdars 9ac5f46875 This shouldn't ever appear on the index, we have a preview partial 2025-07-09 10:44:53 -05:00
Jason Zimdars f1337048bd This shouldn't need to be here, it would never be displayed and does nothing 2025-07-09 10:42:03 -05:00
Jason Zimdars 8f7a373aad Public card templates 2025-07-09 10:16:39 -05:00
Andy Smith 6627482f04 Add circle-on-mobile button class 2025-07-09 10:11:12 -05:00
Jason Zimdars 485e575c40 Merge branch 'main' into card-attachments
* main: (45 commits)
  Display tag counts in the filter menu
  Move Add Card button to header
  Re-write help content, try a modal-like display
  Move to internal registry
  Show date instead of time for notifications older than 1 day
  Ensure checks are visible for tags and assignments
  Adjust padding so card number isn't cut off
  Don't color the collection header in considering
  Golden cards bubble to the top of Considering, too
  Adjust card collection header when colored golden
  Allow cards in Considering to gilded
  Hide focus ring on new card titles and step inputs
  Add hover effect for comment edit button
  Add hover effect to overflow button
  Improve multi-account behavior of the PWA
  Remove unneeded *
  Rename test
  Review the code to move cards
  Update editor
  Generalize and delete mentions too
  ...
2025-07-08 16:04:14 -05:00
Andy Smith fdbb9c185e Merge branch 'main' into collection-nav
* main: (203 commits)
  Re-write help content, try a modal-like display
  Move to internal registry
  Show date instead of time for notifications older than 1 day
  Ensure checks are visible for tags and assignments
  Adjust padding so card number isn't cut off
  Don't color the collection header in considering
  Golden cards bubble to the top of Considering, too
  Adjust card collection header when colored golden
  Allow cards in Considering to gilded
  Hide focus ring on new card titles and step inputs
  Add hover effect for comment edit button
  Add hover effect to overflow button
  Improve multi-account behavior of the PWA
  Remove unneeded *
  Rename test
  Review the code to move cards
  Update editor
  Generalize and delete mentions too
  Remove unused code
  Make sure we don't remove accesses if collection is accessible
  ...
2025-07-08 15:34:01 -05:00
Andy Smith 00d68a482c Move Add Card button to header 2025-07-08 15:30:43 -05:00
Jason Zimdars 98f9ba5512 Allow cards in Considering to gilded 2025-07-07 15:14:33 -05:00
Andy Smith 6e2eacd3d8 Hide focus ring on new card titles and step inputs 2025-07-07 13:23:19 -05:00
Andy Smith f9c7862fc1 Add hover effect for comment edit button 2025-07-07 10:12:32 -05:00
Andy Smith 95dac275fd Add hover effect to overflow button 2025-07-07 10:07:56 -05:00
Andy Smith 84d5f64d1f Merge pull request #695 from basecamp/focus-hover-styles
Focus hover styles
2025-07-07 09:49:08 -05:00
Jorge Manrubia 0191eb85dc Merge branch 'main' into card-attachments
* main:
  Don't create mentions from drafts until those are published
  Change Active Storage account slug extension to a to_prepare block
  dep: bump actiontext-lexical for previewable attachment fix
  Add assertion for composite command line
  Remove trace
  restore the right command
  Update action text
  The prompt confirmation system wasn't really working after moving to lexical
  Parse commands where it's just a gid properly
  Move inside concerns or the override won't work
  Truncation for comment author line
  Avoid duplicated queries and, instead, bump the last ones
  Adjust screen for screen readers
  Adjust icon sizing and uploading styles
2025-07-04 17:38:27 +02:00
Jason Zimdars cf4c6dba9c Indicate cards with attachments in the description 2025-07-03 15:56:25 -05:00
Andy Smith 757ff4ff2b Merge branch 'main' into focus-hover-styles 2025-07-03 15:14:14 -05:00
Jason Zimdars 8f42086703 Truncation for comment author line 2025-07-03 15:06:15 -05:00
Andy Smith 5c2997422f Address PR feedback 2025-07-03 15:00:12 -05:00
Jason Zimdars 5d34cb3f51 Adjust screen for screen readers 2025-07-03 14:37:31 -05:00
Jason Zimdars 645d4b3497 Fix broken page title 2025-07-03 09:35:24 -05:00
Andy Smith 4bc1b36d3d Clean up --hover variables 2025-07-02 16:14:34 -05:00
Jason Zimdars aff0a38b37 Move to scope and inline method 2025-07-02 16:14:25 -05:00
Jason Zimdars 25a33fb9c8 Merge branch 'main' into card-steps
* main: (22 commits)
  Fix that stage should be visible above card background
  Indicate opens menu
  Hide dialog targets from screen readers when closed
  Mark up as heading for screen reader navigation
  Copy for screen readers
  Don't hide the input so it's accessible to screen readers
  Point skip links to correct anchor, don't navigate with turbo
  There aren't any `li` children so just use `div`
  Use headings for screen reader navigation
  Use `h3` for individual cards in collection view
  Make collection title `h1` for screen reader navigation
  Esc should not propagate when closing dialogs
  squash! Remove session controller actions other than delete
  Screen reader: Use heading for comments navigation
  Remove the invitation codes for now
  Remove session controller actions other than delete
  Correct label for field
  Style
  Screen reader: De-duplicate links for each person in account settings
  Account.signal_account is no longer optional
  ...
2025-07-02 16:09:49 -05:00
Jason Zimdars 10893b8fa2 Don't hide the input so it's accessible to screen readers 2025-07-02 15:02:37 -05:00
Jason Zimdars 70d6a7190f Use h3 for individual cards in collection view 2025-07-02 14:42:53 -05:00
Jason Zimdars db99e5928c Make collection title h1 for screen reader navigation 2025-07-02 14:38:29 -05:00
Jason Zimdars 985337a91c Esc should not propagate when closing dialogs 2025-07-02 14:29:15 -05:00
Jason Zimdars 91aa8be4fc Screen reader: Use heading for comments navigation 2025-07-02 14:22:16 -05:00
Jason Zimdars f02215c5b7 Add steps to cards 2025-07-01 20:05:20 -05:00
Andy Smith 624dc823c4 Make card column filters interactive 2025-07-01 17:16:09 -05:00