Commit Graph

2171 Commits

Author SHA1 Message Date
Jason Zimdars 029daece9b Save button should match card color 2025-06-03 16:46:09 -05:00
Jason Zimdars 37dc14c0c6 x interferes with string entry, try SHIFT+ENTER to toggle checkboxes 2025-06-03 16:35:55 -05:00
Jason Zimdars 56b32e6f52 No explicit stalled setting for now
Stalled will be determined by the system
2025-06-03 15:57:11 -05:00
Jason Zimdars 678fb66f17 Stub UI for independent settings for Considering and Doing 2025-06-03 15:51:37 -05:00
Jason Zimdars ff403021cc Wire-up keyboard navigation
- Introduces a distinct controller and individual forms for each option so they behave like other pop-ups
- Adds `filter` and `navigable-list` behaviors
2025-06-03 11:05:39 -05:00
Jason Zimdars acfc7da551 Merge pull request #548 from basecamp/change-collection
Change collection
2025-06-03 08:56:00 -05:00
Jason Zimdars 98c1f32e1c Spell it all out for now 2025-06-03 08:54:37 -05:00
Jason Zimdars 6045b7a736 Correct hotkey 2025-06-03 08:49:03 -05:00
Jorge Manrubia cf5f0a9f3f Set ratio for videos via style
And update lexical to allow style attributes
2025-06-03 11:41:10 +02:00
Jorge Manrubia 199a78ee08 Merge branch 'main' into filter-revamp
* main:
  `event.assignees` collection doesn't include `event.creator` when self-assigning
  Consistent verb forms
  Autolinking shouldn't include final punctuation.
  dep: update kamal to edge
  No need to delegate auto_closing? anymore
  Extract common method to query when entropy is cleaned
  Invalidate card caches when editing workflows

# Conflicts:
#	app/javascript/controllers/navigable_list_controller.js
2025-06-03 06:12:34 +02:00
Jason Zimdars 2c75c9e746 Let's try it without the explicit submit
Later on we could consider adding an explicit button that only shows up when the filter has no matches and there is something typed in the filter input
2025-06-02 16:37:58 -05:00
Jason Zimdars f796b62aa8 Update markup to match assignments list
Drifted due to neglect (I guess)
2025-06-02 16:28:47 -05:00
Jason Zimdars de8fce5eee Prefer ul for a11y 2025-06-02 16:12:34 -05:00
Jason Zimdars 63808ff567 Just say "Filter…", since it can match other things 2025-06-02 16:09:18 -05:00
Jason Zimdars 84b52f8fae Ensure these can be matched by the filter, too 2025-06-02 15:56:46 -05:00
Jason Zimdars dc5c8d17a4 Handle these special case options a different way 2025-06-02 15:49:44 -05:00
Andy Smith 34a4ba6c60 Add height/width values for images and videos 2025-06-02 14:36:04 -05:00
Jorge Manrubia 61fbad218b Make tag filters selectable/navigable too 2025-06-02 18:39:44 +02:00
Jorge Manrubia c0cd5e1967 Merge pull request #566 from basecamp/fix-caching
Invalidate card caches when editing workflows
2025-06-02 18:09:52 +02:00
Jorge Manrubia 08c5abfbdb Extract common method to query when entropy is cleaned
We were always quering auto_close_at
https://37s.fizzy.37signals.com/collections/2/cards/743
2025-06-02 18:04:14 +02:00
Jorge Manrubia 5c31ef1aa6 Make dialog close on ESC 2025-06-02 17:17:13 +02:00
Jason Zimdars 3ab0cb7422 Down arrow glyph 2025-06-02 10:02:27 -05:00
Jason Zimdars 902a99ca56 Merge branch 'main' into change-collection
* main: (25 commits)
  Add controller to retarget links
  Use more complete regexp
  dep: bundle update
  refactor: Extract a Card::Entropy concern
  Autolink emails and URLs at rendering time
  Remove the "mirror" storage service
  Update production storage to write to the Pure blob store
  Clean up the purestorage config, and add explanatory comments.
  Drop the action_text_markdowns table
  Mount mission control under `/admin/jobs`
  dep: add mission_control-jobs
  Flip the storage mirror to write to Pure as the primary
  Production mirrors Active Storage to `:purestorage`
  Make sure Sentry is configured for the beta env.
  Update lexical
  update lexical
  update lexical
  Create a distinct "beta" environment
  Revert "Patch for cards missing description"
  Add a kamal "ssh" alias
  ...
2025-06-02 09:34:01 -05:00
Jorge Manrubia b10ab3063b Add class I lost by mistake 2025-06-02 15:32:39 +02:00
Jorge Manrubia ca40e36a79 Make dialog to assign users searchable and navigable 2025-06-02 15:30:55 +02:00
Jorge Manrubia 10ee5611c9 Make collection's filter searchable too 2025-06-02 15:22:34 +02:00
Jorge Manrubia 29c1f3133d Remove unused classes from controller 2025-06-02 15:08:34 +02:00
Jorge Manrubia 37fd2b248d Revamp filters menu (WIP)
- Make them navigable by keyboard (UP, DOWN, ENTER to activate option).
- Filter based on the actual text in the element, use containment condition instead of CSS selector on value prefix.
- Make all the elements in the filter searchable and reachable by keyboard.
2025-06-02 14:51:03 +02:00
Jorge Manrubia 51dcf8b25f Invalidate card caches when editing workflows
https://37s.fizzy.37signals.com/collections/2/cards/607
2025-06-02 13:08:54 +02:00
Jorge Manrubia db9ee1b3b2 Merge pull request #564 from basecamp/auto-link-render
Autolink emails and URLs at rendering time
2025-06-02 12:12:39 +02:00
Jorge Manrubia d7c06702e3 Add controller to retarget links
So that internal links can skip turbo frames, and external links
open in new pages
2025-06-02 12:04:43 +02:00
Mike Dalessio 28ed744d0c refactor: Extract a Card::Entropy concern
to encompass behavior related to auto-closing and auto-reconsidering.

Note that putting this code in a single place reveals an asymmetry
between the actions:

- Auto-closing period is an optional attribute of a collection
- Auto-reconsidering period is hard-coded to 30 days for all collections
2025-06-01 16:50:12 -04:00
Jorge Manrubia 5214a74c03 Autolink emails and URLs at rendering time 2025-06-01 22:24:24 +02:00
Jorge Manrubia 8924e7b42f Merge branch 'main' into creation-bugs
* main:
  update lexical
  Update AR::Tenanted to have tenanted blob keys
  Delete old multitenancy migration script
  Drop the unnecessary initializer creating storage paths
  Card shadow tweaks
2025-05-31 18:21:47 +02:00
Jorge Manrubia 5d662f1ec9 Revert "Patch for cards missing description"
This reverts commit 257c0902f4.
2025-05-31 12:30:04 +02:00
Andy Smith 68906321e8 Card shadow tweaks 2025-05-30 13:11:36 -05:00
Jorge Manrubia 257c0902f4 Patch for cards missing description
The problem was that after redirecting back with morphing, the autosave mechanism
would trigger an autosave call with an empty content.

This is a first patch. The editor shouldn't be triggering these "change" events
in the first place when loading the editor.
2025-05-30 17:35:25 +02:00
Jason Zimdars c4ca5d34e4 Allow cards to be moved to another collection 2025-05-29 21:41:29 -05:00
Jason Zimdars 9228337c52 Don't color closed golden cards 2025-05-29 16:49:57 -05:00
Jason Zimdars 9052b76c39 Indicate golden cards in activity 2025-05-29 15:30:17 -05:00
Jason Zimdars 32ae94524a Safari doesn't support CSS field-sizing: content so we can shim it for now 2025-05-29 14:19:48 -05:00
Jorge Manrubia fa04016cbe Revert "Revert "Replace House with Lexical"" 2025-05-29 14:25:16 +02:00
Jorge Manrubia 08d8b2e5ff Revert "Replace House with Lexical" 2025-05-29 14:22:27 +02:00
Jorge Manrubia 62bef018ea Merge branch 'main' into lexical
* main:
  Don't choke when rendering commands where the card was deleted
  Update tests
  Rework system events
  test: add missing assertions
  dep: bump active_record-tenanted to fix URI support
  Remove hyphen from "Un-do"
  Prevent default when handling keyboard shortcuts
  dep: update AR::Tenanted to support database URIs
  Detect platform and label the correct hotkey shortcut
  Things got too tight
  Don't require TLS for Beamer at the moment
  dep: update dependencies

# Conflicts:
#	Gemfile
#	Gemfile.lock
#	app/assets/stylesheets/comments.css
2025-05-29 12:44:14 +02:00
Jason Zimdars a69dbdafe1 Simple format excerpts in activity 2025-05-28 17:18:20 -05:00
Jorge Manrubia 594161b982 Make autosave work with lexical 2025-05-28 23:20:24 +02:00
Jason Zimdars c6c9e0d5fc Rework system events
- Restyle system events so they don't look like comments and aren't attributed to the system user
- Ensure the event creator is included in the description so it's clear who did it.
- Walk back system comment replacement. Yes, it potentially avoids embarassing people when they change their mind, it's also losing data. If two intentional assigments happen in proximity, we've been only showing the latest one,.
2025-05-28 15:26:41 -05:00
Kevin McConnell 50e2085e8b Remove hyphen from "Un-do" 2025-05-28 13:58:26 +01:00
Kevin McConnell 880e3d98b2 Prevent default when handling keyboard shortcuts
Without this, any default action would still happen. With Chrome on
Linux, that causes browser features to be triggered with our CTRL+J and
CTRL+K actions.
2025-05-28 08:18:49 +01:00
Jason Zimdars fc0d0cd300 Style non-previewable attachment in editor and rendered 2025-05-27 22:21:58 -05:00