Commit Graph

4156 Commits

Author SHA1 Message Date
Jason Zimdars fa248c035d Alignment 2025-03-24 17:46:29 -05:00
Jason Zimdars 403a328ef8 Walk-back two-column comments design 2025-03-24 17:43:43 -05:00
Jason Zimdars abeb0762f6 Untangle list 2025-03-24 17:27:24 -05:00
Jason Zimdars c9a8f73134 Avoid wrapping 2025-03-24 17:04:18 -05:00
Jason Zimdars 7c54a20ece DRY this up a bit 2025-03-24 17:04:08 -05:00
Jason Zimdars ebca0caa03 Square headers, correct centering, use --grid-lines variable throughout 2025-03-24 16:36:13 -05:00
Mike Dalessio a66dc2a789 Move tags and assignments partials out of "bubbles/sidebar"
They're part of the card now, let's name them that way.

Also, rename the "tag" partial to "tagging", following the naming
convention established by the controller.
2025-03-24 17:11:58 -04:00
Mike Dalessio 5ae87d8140 Ensure the tags dropdown is not subject to the cached card fragment
- Rearrange the _tags and _tag partial, so they are properly nested concerns
- Add turbo frames for _tags and _tag
- Load _tag in a separate request, so it's not cached with the card
- Cache _tag using the bubble and the account
- New model behavior: touch Account when tags are added or removed
- New controller action: "new" for taggings toggles, which renders the _tag partial
- Updating taggings responds with a turbo stream response that updates the _tags frame

This is very much a parallel change to what was done with assignments
in #317.
2025-03-24 16:48:11 -04:00
Mike Dalessio 506f74144b Touch Account when adding or removing a Tag
so we can properly cache the tags partial using account as part of the key.
2025-03-24 16:48:11 -04:00
Jason Zimdars 9c690c5822 Don't display before login 2025-03-24 15:19:51 -05:00
Mike Dalessio df377861fc Merge pull request #317 from basecamp/flavorjones-assignee-card-cache
Assignee dropdown no longer subject to the card fragment cache
2025-03-24 15:27:53 -04:00
Jason Zimdars bc5858081a Make sure back restores any active filters 2025-03-24 14:15:45 -05:00
Jason Zimdars 4bc125c7eb Load the form in a turbo frame so focused field doesn't intercept hotkeys 2025-03-24 14:15:28 -05:00
Jason Zimdars 9b9e09601e Introduce text-based UI 2025-03-24 11:33:04 -05:00
Mike Dalessio 44650cc36e Reload the assignees turbo frame when assigments are updated
Also, add a cache around the dropdown keyed on [bubble, bucket].
2025-03-21 17:53:41 -04:00
Mike Dalessio a830ec1999 Extract an "assignees" partial
pulling the avatars down from the "people" partial, and pulling the
add button up from the "assignment" partial.

The result is:

- the "bubbles/sidebar/assignment" partial is just the dialog box
- the "bubbles/assignees" partial contains everything about assignees
- the "bubbles/people" partial makes one render call

and I've introduced some turbo frames in the expectation of the next
commit which will load the dialog in the background.
2025-03-21 17:20:14 -04:00
Jason Zimdars cbc9567966 Smaller tray cards 2025-03-21 14:54:26 -05:00
Jason Zimdars 53b906423a Overflow needs to be on the nearest item 2025-03-20 18:12:43 -05:00
Jason Zimdars 39ebeadc08 Hide button when empty 2025-03-20 18:04:39 -05:00
Jason Zimdars 9dba039096 Missing class 2025-03-20 17:59:29 -05:00
Jason Zimdars eaf927f1a8 Refactor tray styles 2025-03-20 17:54:24 -05:00
Jason Zimdars 0da84efd01 Tray pins design 2025-03-20 16:52:56 -05:00
Jason Zimdars 1802a6391a Tweak events and dates 2025-03-20 13:54:56 -05:00
Jason Zimdars 0e0513dd77 Try addressing clipped descenders another way 2025-03-20 11:52:33 -05:00
Jason Zimdars 2f2dd1248d Revert "Address line-height"
This reverts commit efaeb26fab.
2025-03-20 11:52:33 -05:00
Mike Dalessio 947b963157 Merge pull request #308 from basecamp/flavorjones-fix-card-cache-on-bucket-change
Use the bucket name as part of the card cache key
2025-03-20 12:49:54 -04:00
Mike Dalessio 473703df3d Invalidate the bubble cache when the bucket name changes
by including the bucket name as part of the bubble cache key.

ref: https://37s.fizzy.37signals.com/buckets/693169850/bubbles/999008709

Co-authored-by: Kevin McConnell <kevin@37signals.com>
2025-03-20 12:46:23 -04:00
Jason Zimdars 2e0f787777 Polish trays behavior 2025-03-20 11:41:17 -05:00
Jason Zimdars e92995b5e5 Account for untitled bubbles 2025-03-20 11:41:02 -05:00
Jason Zimdars efaeb26fab Address line-height 2025-03-20 11:16:31 -05:00
Jason Zimdars 7f06504a55 Ensure something is rendered when title is blank 2025-03-20 11:16:31 -05:00
Jason Zimdars 015b26e7e8 Dark mode 2025-03-20 11:16:31 -05:00
Jason Zimdars e315e66d58 Keep it top right 2025-03-19 17:54:52 -05:00
Jason Zimdars f4b1c0593b Missing summary 2025-03-19 17:50:26 -05:00
Jason Zimdars 05d377e919 Actually let's use the icons and the state 2025-03-19 17:45:20 -05:00
Jason Zimdars 4370281f67 Add a missing event, adjust icons 2025-03-19 17:02:05 -05:00
Jason Zimdars 264d78b21a Update test 2025-03-19 16:37:06 -05:00
Jason Zimdars eabb5a14c8 This is causing layout issues with code blocks
Ideally they would scroll and keep the original line breaks but the layout needs proper constraints for that to happen
2025-03-19 16:34:33 -05:00
Jason Zimdars 572428bfbc Improved comments and events layout 2025-03-19 16:33:03 -05:00
Jason Zimdars 714ae9d317 Differentiate events with an icon 2025-03-19 13:35:17 -05:00
Jason Zimdars 8e26106a07 Reorder and rename activity columns; include system popped events 2025-03-19 13:35:17 -05:00
Mike Dalessio a6197753ff Make sure first runs redirect will work
by turning off turbo on the form
2025-03-19 12:36:32 -04:00
Jason Zimdars 5973d14e2c Trays everywhere 2025-03-18 17:13:57 -05:00
Jason Zimdars fc163886e8 Move search onto home 2025-03-18 17:11:42 -05:00
Jason Zimdars de851fa69c Move back to edges 2025-03-18 17:10:50 -05:00
Jason Zimdars b99fc7484b Handful of tweaks 2025-03-18 16:01:31 -05:00
Jason Zimdars b498dfd752 Restore related events hover effect 2025-03-18 15:59:37 -05:00
Kevin McConnell 4216b1123e Formatting 2025-03-18 17:53:32 +00:00
Kevin McConnell bc5e32e737 Only "published" notifies collection subscribers
The other notifications are only sent to the watchers of the bubble.
2025-03-18 17:46:57 +00:00
Jason Zimdars 836e6fab5e Avoid touch when setting initial stage 2025-03-18 08:26:16 -05:00