0a5854e02e
Merge pull request #121 from basecamp/workflows-spike
...
Spike workflows
2024-10-22 11:32:44 -06:00
c74dce6002
Remove unnecessary turbo_confirms
2024-10-22 10:50:33 -06:00
79670c04c3
Remove unnecessary parens
2024-10-22 10:49:08 -06:00
6a9ffe3103
Remove unnecessary calls to #id
2024-10-22 10:45:32 -06:00
d2667ba04a
Fix tag test
2024-10-21 21:40:51 -07:00
876f1d0564
Use params.expect
2024-10-21 16:02:08 -06:00
b182124358
Account for workflow path de-nesting
2024-10-21 15:57:54 -06:00
34df819e30
Fix tag test
2024-10-21 15:50:15 -06:00
128fc22eb1
Make it look like the filter
2024-10-21 16:39:39 -05:00
b0565fbf20
Spike workflows
2024-10-21 15:33:30 -06:00
bb0282d24c
Ensure text wraps nicely
2024-10-21 16:03:51 -05:00
6e5b71ea99
Make this a one-liner, no need for hierarchy
2024-10-21 16:03:41 -05:00
b1f5498914
Encapsulate tagging as a taggable domain method
...
Tag scope control should not float around in the controller
2024-10-19 20:14:59 -07:00
c00dcd8c66
Already comes as a hash
2024-10-19 19:55:14 -07:00
255435a38f
No need for a non-standard factory method for something this simple
2024-10-19 19:53:20 -07:00
139fa7afdc
No need for this to be in a transaction
...
If you update the name by itself, it is fine. We generally want to be
very careful about having txn spans, since all the work done within them
will block the sqlite writer.
2024-10-19 19:51:25 -07:00
0c5778495e
Resolve bubble to bucket_bubble for ease of redirecting
2024-10-19 19:48:31 -07:00
e75e585f03
Routes are actually ensuring the id is always there
2024-10-19 19:37:46 -07:00
aef3c8ca32
No need to specify the extension now
2024-10-19 19:36:23 -07:00
e3f7930dcd
Unlikely we are going to need this
2024-10-19 19:35:21 -07:00
b8e93c4f8a
Extract render svg as a real renderer
2024-10-19 19:31:48 -07:00
15b0d6e818
Simplify join code svg rendering
...
There are no other formats, so dont use the multiformat structure, but
prepare for a render svg upstream.
2024-10-19 19:19:12 -07:00
b53a2b8880
Fix url reference
2024-10-19 19:07:48 -07:00
b7efd04a43
Use _path consistently in the controllers when not changing host
2024-10-19 19:00:04 -07:00
2995c1571f
Use the new params#expect syntax where applicable
...
To ensure we don't get spurious 500s when we can serve 400s on bad data
2024-10-19 18:53:41 -07:00
cdcf2500c1
Another spot where we need to move a Current.user check to a stimulus controller to cache
2024-10-19 18:31:21 -07:00
53afd0d93c
Note that Current.user cannot be referenced within partials that must be cached
2024-10-19 17:51:09 -07:00
716e14998f
Note that we need to keep all partials cacheable, so no dynamic path munging
2024-10-19 17:46:36 -07:00
1d404830f4
Must touch to bust bubble caches
2024-10-19 17:42:06 -07:00
0bffcb8b86
Actually need to do all work outside of transaction loop
...
We can be more efficient as just as descriptive with an explaining
variable
2024-10-19 17:08:05 -07:00
942eb9fd64
Extract explaining method
...
And keep parent method at a consistent level of abstraction
2024-10-19 17:03:37 -07:00
32d1792cb2
Fetch bubbles index with multiget cache
2024-10-19 16:50:19 -07:00
cd14fda395
Cache bubble partial on itself
2024-10-19 16:50:05 -07:00
5d06e5449f
Etag the bubbles#show
2024-10-19 16:49:51 -07:00
e2c9048581
Only load from app, not all plugins etc
...
This will prevent loading trix for example
2024-10-18 12:49:12 -07:00
d9d473723b
Clean up Bucket::BubbleFilter initializer
2024-10-18 11:15:53 -06:00
09c003431e
Pull out Bucket::BubbleFilter
2024-10-18 11:11:23 -06:00
224cd14fe6
Scope view lookup to Current.user
2024-10-17 23:17:27 -06:00
bd2f4fc476
Fix tag_filters and assignee_filters calls
2024-10-17 23:02:59 -06:00
e7cc426fdc
Move bubble filtering to the model
2024-10-17 22:51:02 -06:00
91401c2e75
Put latest buckets first
2024-10-17 22:29:15 -06:00
e38a7fadda
Merge pull request #113 from basecamp/persisted-filters
...
Persisted filters
2024-10-17 22:17:43 -06:00
54cea4eb75
clear_assignees_if_unassigned -> clear_assignees
2024-10-17 22:09:34 -06:00
be43dbc693
Remove unnecessary compact_blank
2024-10-17 22:03:07 -06:00
c0df006ebc
Consolidate bucket_view_helper and filters_helper
2024-10-17 21:37:48 -06:00
c9e6ecda58
bucket_view_form_tag -> bubble_filter_form_tag
2024-10-17 21:35:21 -06:00
6dc01479b7
Fix search form
2024-10-17 21:34:48 -06:00
9c2b101624
Memoize view_filter_params
2024-10-17 20:58:11 -06:00
3542298394
@view might be nil in BubblesController#index
2024-10-17 20:56:52 -06:00
862c854377
querying_unassigned_status -> unassigned_filter_activated
2024-10-17 20:55:11 -06:00
Jose Farias