Commit Graph

5512 Commits

Author SHA1 Message Date
Kevin McConnell 0b068d62a7 Merge pull request #280 from basecamp/scoring
More dynamic activity scores
2025-03-06 11:29:31 +00:00
Kevin McConnell 16a80ff3a6 More dynamic activity scores
This introduces a more dynamic system of activity scoring, to improve
the way bubbles "bubble up" due to their activity. There are a few
different parts we can tune here, and it's likely we'll need to make
adjustments once we get a feel for how this works in practice.

The basic idea here is:

- We assign points for certain types of event that happen on a bubble. A
  boost gets 1 point, a comment gets 10 points, and so on.
- These points decay over time, at a rate of 50% per day. So old
  activity is worth much less than new activity. Bubbles should rise up
  quickly when acted upon, bit will float back down if left idle.
- Some comments can score higher than others: the first comment from
  each person on a bubble is worth more (20) because it signals that
  more people are getting involved; and comments that follow a comment
  by a different author are also worth more (15) because that signals
  there's ongoing conversation between people, not just a series of
  notes being left by one individual.

In terms of implementation, we persist the score on the bubble
whenever it changes, but we handle the decay on the client side. That
allows us to cache the bubble representation without having to
continually change it while its activity decays.

We also keep a separate `activity_score_order` attribute on the model.
This can be used to sort the bubbles in order of "most active", without
having to think about the decay.
2025-03-05 17:16:31 +00:00
Kevin McConnell a65d7b0397 Don't blow up on missing comment 2025-03-05 16:51:14 +00:00
Kevin McConnell 748d09a5f7 Cache comment partial 2025-03-03 17:04:16 +00:00
Kevin McConnell 49fa8b21a6 Move current user check to controller
This is necessary to a) ensure people can't edit/delete comments they
don't own, and b) make the comment partial cacheable.
2025-03-03 17:04:16 +00:00
Jason Zimdars 65ceb3c5f0 Tighten-up headings so they look good when they wrap to two lines (rare) 2025-03-03 09:04:37 -07:00
Jason Zimdars 72592ec3cc Order events in the cluster so that the oldest is closest to the timestamp 2025-03-03 09:04:08 -07:00
Jason Zimdars a87ffd6473 Avoid squishing the switch when the bucket name is very long 2025-03-03 08:55:49 -06:00
Kevin McConnell e7da0d5327 Merge pull request #276 from basecamp/autosave-comments
Autosave comments
2025-02-28 15:30:21 +00:00
Kevin McConnell 5d1206e067 remote-auto-save -> outlet-auto-save 2025-02-28 15:15:09 +00:00
Kevin McConnell 4d13db0f8b Rename to local-save-controller 2025-02-28 15:13:23 +00:00
Kevin McConnell 06dcb11e4b Refactor the controller a little bit 2025-02-28 15:12:10 +00:00
Kevin McConnell a7cde91a10 Don't save draft comment to local storage
Since we already save this to the database, along with the title.
2025-02-28 14:50:26 +00:00
Kevin McConnell bb2a2c618b Don't lose formatting in draft comment
When displaying a bubble in the `creating` state, we were wrongly using
the plaintext version of the draft comment. This has the effect of
losing formatting whenever the page is saved and reloaded.
2025-02-28 12:43:22 +00:00
Kevin McConnell eaf4903afc Formatting 2025-02-28 11:48:29 +00:00
Kevin McConnell 55464f39a2 Don't duplicate notifications on publish
We're already sending everyone the "published" notification, and for
assignees that will include the assignment message. Tracking the event
again here would just duplicate that.
2025-02-27 16:37:53 +00:00
Kevin McConnell 93474002b7 Add test for watchers_and_subscribers 2025-02-27 16:27:12 +00:00
Kevin McConnell 942dd27e5c Sort buckets on notification settings 2025-02-27 12:17:32 +00:00
Kevin McConnell 0c3d5b6789 Merge pull request #274 from basecamp/notif-prefs
Notification preferences
2025-02-27 10:54:36 +00:00
Kevin McConnell ab27371115 Include self in watcher list 2025-02-27 10:51:59 +00:00
Kevin McConnell 8bd207096b Pass user in locals 2025-02-27 10:45:18 +00:00
Kevin McConnell 2b8d41a752 Start with subscriptions on for everyone
To prevent people missing a notification they care about when we ship
the subscriptions feature, we'll start out with everything toggled on
(which matches the previous behaviour). People can then opt out as they
like.
2025-02-27 10:42:19 +00:00
Jason Zimdars ed08b85c25 Fix that remote-auto-save loses markdown formatting by using local autosave 2025-02-26 17:48:02 -06:00
Jason Zimdars a0ffbc807f Auto save comments to local storage to prevent losing work 2025-02-26 17:37:49 -06:00
Jason Zimdars cf5ddbbb78 Style watchers block 2025-02-26 16:47:48 -06:00
Jason Zimdars 8ddf8d1ad3 Use local_assigns 2025-02-26 15:57:16 -06:00
Kevin McConnell f54119f477 Add missing test 2025-02-26 10:58:56 +00:00
Kevin McConnell fc1939d771 Avoid using Current in the partial 2025-02-26 10:53:03 +00:00
Kevin McConnell 84d06c7f0b Creators watch their own bubble by default 2025-02-26 10:53:03 +00:00
Kevin McConnell 4009553ffc Remove unnecessary file 2025-02-26 10:53:03 +00:00
Kevin McConnell 385e299db7 Simplify param 2025-02-26 10:53:03 +00:00
Kevin McConnell a238f504e4 Don't create initial watches
We have subscriptions instead now. Watches need only be created as
necessary to override the defaults.
2025-02-26 10:53:03 +00:00
Kevin McConnell a802b8de5a Allow managing bucket subscriptions 2025-02-26 10:53:03 +00:00
Kevin McConnell f22742c431 watched_by? should reflect subscriptions too 2025-02-26 10:53:03 +00:00
Kevin McConnell d29e999552 Make Buckets subscribable 2025-02-26 10:53:03 +00:00
Kevin McConnell 6157d8b4bd Start watching when participating on a bubble
If you're added as an assignee, or if you comment, then your watching
preference will be toggled on.
2025-02-26 10:53:03 +00:00
Kevin McConnell 2d0c9d309b All notifiers use same recipients 2025-02-26 10:53:03 +00:00
Kevin McConnell 694783e5f3 Allow toggling watch preference
We use a true/false preference so we can tell the difference between
disabling the watch vs never having the watch. This is so we can toggle
off and on the preferences for a container (like the bucket) without
losing any bubble-specific preferences.
2025-02-26 10:53:03 +00:00
Kevin McConnell 59144ad17a Add Watches to track notification preferences 2025-02-26 10:53:03 +00:00
Kevin McConnell 1910bba681 Add missing table to schema 2025-02-26 10:52:50 +00:00
Jason Zimdars 8b0f11ab3e Use existing filters system to create some quick links 2025-02-25 16:57:03 -06:00
Jason Zimdars 3184e6ba2d Only hover on dot 2025-02-24 17:18:31 -06:00
Jason Zimdars d73d3a9daa Constrain boost events 2025-02-24 17:12:46 -06:00
Jason Zimdars 5a4d2a72c8 Remove uniqueness constraint
I'm not sure if this was inadvertent or an artifact of an earlier design but I'm fairly certain we want a more comprehensive list of events here. Especially comments, for example. We should show all the comments that happen in a particular hour on the timeline. There may be places were we need to dial back but for now I'm going to lift the constraint and see how it feels.
2025-02-24 17:01:43 -06:00
Jason Zimdars 256edbfa96 Special case self-assignment 2025-02-24 16:25:24 -06:00
Jason Zimdars ed0a815a35 Fix that title could overlap unread indicator 2025-02-24 16:05:42 -06:00
Jason Zimdars 15cf38d46f This isn't necessary (apparently) and doesn't work in Firefox 2025-02-24 14:28:22 -06:00
Jason Zimdars cd534391c1 Delete referenced events when deleting comments 2025-02-24 13:24:49 -06:00
Jason Zimdars d254d1eb27 Bust this cache 2025-02-21 17:37:17 -06:00
Jason Zimdars 635d3a83a5 Fix hover state on radio buttons 2025-02-21 17:30:16 -06:00