Commit Graph

457 Commits

Author SHA1 Message Date
Kevin McConnell 63ddb23585 Opt out of writer affinity on readings controller 2025-06-16 15:05:47 +01:00
Jorge Manrubia a7cdf964dd Fix tests after updating rails 2025-06-13 10:49:52 +02:00
Jorge Manrubia cb101ca43f Fix fixtures after updating gem 2025-06-13 10:48:08 +02:00
Jorge Manrubia 303a3faea1 Merge pull request #607 from basecamp/drag-and-drop-cards
Drag and drop cards to move between doing/considering
2025-06-13 10:04:59 +02:00
Jorge Manrubia 7a4e59391b Add test 2025-06-13 09:55:37 +02:00
Jorge Manrubia 1175bf5dce Merge pull request #608 from basecamp/create-and-add-another
Add multiple cards quickly
2025-06-13 08:58:35 +02:00
Jorge Manrubia 9dc221f0b2 Add test 2025-06-13 08:58:06 +02:00
Mike Dalessio 5430355da6 Avoid losing access to a Collection when updating entropy
ref: https://37s.fizzy.37signals.com/collections/2/cards/820
2025-06-12 13:43:13 -04:00
Jorge Manrubia 9295cf9ca0 Add test 2025-06-10 12:03:21 +02:00
Jorge Manrubia a916fe4470 Add tests 2025-06-10 11:18:33 +02:00
Jorge Manrubia 0807cfc3d0 Format 2025-06-06 09:21:45 +02:00
Jorge Manrubia d7a6e25d78 Fix tests after removing indexed_by param 2025-06-06 08:25:49 +02:00
Jorge Manrubia 0cb5b9ecd6 Reactions reset entropy 2025-06-05 16:07:19 +02:00
Jorge Manrubia 310b8ad4e9 Make sure we only detect activity spikes when we should
The detection logic wasn't really working before
2025-06-05 15:49:27 +02:00
Jorge Manrubia b9ec71ff84 Format 2025-06-05 15:21:18 +02:00
Jorge Manrubia 6688ca3e82 Consider reopened cards as an activity spike 2025-06-05 15:16:13 +02:00
Jorge Manrubia 67b45cc5a6 Test scope 2025-06-05 15:11:06 +02:00
Jorge Manrubia d22cbe6f7f Add tests for stalled detection 2025-06-05 15:09:55 +02:00
Jorge Manrubia eb95af4add Add test for reopening cards 2025-06-05 13:29:34 +02:00
Jorge Manrubia 7c1bd23460 Exclude body checking in this test
Requests like summarize can result in completely different responses
2025-06-05 13:02:40 +02:00
Jorge Manrubia 3df7d3e5a8 Match requests by body
So that modifying the prompt make the tests fail

If not, the tests defeat their purpose!
2025-06-05 12:45:45 +02:00
Jorge Manrubia 9b4cd7eff2 Remove vcr_record! 2025-06-05 12:36:37 +02:00
Jorge Manrubia 7eb1930eb3 Test for stalled cards 2025-06-05 12:36:12 +02:00
Jorge Manrubia c52e49ef91 Merge branch 'main' into stalled-cards
* main: (33 commits)
  Rename helpers since they are not related to collections only anymore
  Simplify
  Reorder method
  Update brakeman
  Fix tests after removing the index action
  Format
  Extract partials
  Format
  Tidy up code
  We're not using this right now
  Wire up knob UI design
  Contain images
  Extract the header so we can explain in context
  Display users and invite on `account/settings`
  Link to workflows
  Link to account settings
  Update to use two-column layout, add title and nav
  Add comment
  Properly parameterize the field name
  Remove leftover console.log
  ...
2025-06-05 10:09:12 +02:00
Jorge Manrubia 540254def4 Fix tests after removing the index action
The show action makes more sense in the controller. Also, the filter
scoped was failing due to Rails raising on missing actions (because we
have deleted the index action). Inlining the concern fixes it and clarifies
where this action is implemented.
2025-06-05 09:12:07 +02:00
Jorge Manrubia de87f4ed6c Format 2025-06-05 08:58:15 +02:00
Jorge Manrubia cd9d9f78c7 We'll add tests here 2025-06-04 17:18:01 +02:00
Jorge Manrubia 9cdc34f0ae Basic tests for detecting stalled cards 2025-06-04 17:18:01 +02:00
Jorge Manrubia 77ff7f43eb This test does not make sense anymore with the new entropy model 2025-06-04 15:03:57 +02:00
Jorge Manrubia db86d17880 Refactor to introduce an entropy model
Instead of keeping two tracks of similar logic (auto-reconsider / auto-close).
2025-06-04 14:40:02 +02:00
Jorge Manrubia 6cb1fef909 Add controller tests 2025-06-04 13:26:10 +02:00
Jorge Manrubia 75ce06733a Review entropy tests to include the new behavior and settings 2025-06-04 12:45:04 +02:00
Jorge Manrubia 2ee857a4d2 Add fixture for account entropy configurations 2025-06-04 11:36:47 +02:00
Jorge Manrubia 91787a3523 Revamp entropy configuraiton
- Move both settings to its dedicated model entropy configuration
- A collection can have an entropy configuration, or will default to the account if not
2025-06-04 10:41:08 +02:00
Jason Zimdars acfc7da551 Merge pull request #548 from basecamp/change-collection
Change collection
2025-06-03 08:56:00 -05:00
Jorge Manrubia e2939e846c Consistent verb forms 2025-06-03 02:53:03 +02:00
Mike Dalessio 1302fe9da2 Autolinking shouldn't include final punctuation. 2025-06-02 14:16:02 -04:00
Mike Dalessio 3a5ce1ca4c No need to delegate auto_closing? anymore
Related to #568
2025-06-02 12:41:55 -04:00
Jorge Manrubia 08c5abfbdb Extract common method to query when entropy is cleaned
We were always quering auto_close_at
https://37s.fizzy.37signals.com/collections/2/cards/743
2025-06-02 18:04:14 +02:00
Jason Zimdars 902a99ca56 Merge branch 'main' into change-collection
* main: (25 commits)
  Add controller to retarget links
  Use more complete regexp
  dep: bundle update
  refactor: Extract a Card::Entropy concern
  Autolink emails and URLs at rendering time
  Remove the "mirror" storage service
  Update production storage to write to the Pure blob store
  Clean up the purestorage config, and add explanatory comments.
  Drop the action_text_markdowns table
  Mount mission control under `/admin/jobs`
  dep: add mission_control-jobs
  Flip the storage mirror to write to Pure as the primary
  Production mirrors Active Storage to `:purestorage`
  Make sure Sentry is configured for the beta env.
  Update lexical
  update lexical
  update lexical
  Create a distinct "beta" environment
  Revert "Patch for cards missing description"
  Add a kamal "ssh" alias
  ...
2025-06-02 09:34:01 -05:00
Jorge Manrubia db9ee1b3b2 Merge pull request #564 from basecamp/auto-link-render
Autolink emails and URLs at rendering time
2025-06-02 12:12:39 +02:00
Mike Dalessio 28ed744d0c refactor: Extract a Card::Entropy concern
to encompass behavior related to auto-closing and auto-reconsidering.

Note that putting this code in a single place reveals an asymmetry
between the actions:

- Auto-closing period is an optional attribute of a collection
- Auto-reconsidering period is hard-coded to 30 days for all collections
2025-06-01 16:50:12 -04:00
Jorge Manrubia 5214a74c03 Autolink emails and URLs at rendering time 2025-06-01 22:24:24 +02:00
Jason Zimdars 5051e5d53d Linter: TrailingWhitespace 2025-05-29 23:27:28 -05:00
Jason Zimdars 922122538a Test granting access 2025-05-29 22:09:33 -05:00
Jorge Manrubia fa04016cbe Revert "Revert "Replace House with Lexical"" 2025-05-29 14:25:16 +02:00
Jorge Manrubia 08d8b2e5ff Revert "Replace House with Lexical" 2025-05-29 14:22:27 +02:00
Jorge Manrubia 6d88975d46 Use existing method 2025-05-29 13:07:20 +02:00
Jorge Manrubia 62bef018ea Merge branch 'main' into lexical
* main:
  Don't choke when rendering commands where the card was deleted
  Update tests
  Rework system events
  test: add missing assertions
  dep: bump active_record-tenanted to fix URI support
  Remove hyphen from "Un-do"
  Prevent default when handling keyboard shortcuts
  dep: update AR::Tenanted to support database URIs
  Detect platform and label the correct hotkey shortcut
  Things got too tight
  Don't require TLS for Beamer at the moment
  dep: update dependencies

# Conflicts:
#	Gemfile
#	Gemfile.lock
#	app/assets/stylesheets/comments.css
2025-05-29 12:44:14 +02:00
Jorge Manrubia 34eb8f1672 Format 2025-05-29 12:38:07 +02:00