Commit Graph

272 Commits

Author SHA1 Message Date
Jorge Manrubia a916fe4470 Add tests 2025-06-10 11:18:33 +02:00
Jorge Manrubia 0807cfc3d0 Format 2025-06-06 09:21:45 +02:00
Jorge Manrubia d7a6e25d78 Fix tests after removing indexed_by param 2025-06-06 08:25:49 +02:00
Jorge Manrubia 0cb5b9ecd6 Reactions reset entropy 2025-06-05 16:07:19 +02:00
Jorge Manrubia 310b8ad4e9 Make sure we only detect activity spikes when we should
The detection logic wasn't really working before
2025-06-05 15:49:27 +02:00
Jorge Manrubia b9ec71ff84 Format 2025-06-05 15:21:18 +02:00
Jorge Manrubia 6688ca3e82 Consider reopened cards as an activity spike 2025-06-05 15:16:13 +02:00
Jorge Manrubia 67b45cc5a6 Test scope 2025-06-05 15:11:06 +02:00
Jorge Manrubia d22cbe6f7f Add tests for stalled detection 2025-06-05 15:09:55 +02:00
Jorge Manrubia eb95af4add Add test for reopening cards 2025-06-05 13:29:34 +02:00
Jorge Manrubia 9b4cd7eff2 Remove vcr_record! 2025-06-05 12:36:37 +02:00
Jorge Manrubia 7eb1930eb3 Test for stalled cards 2025-06-05 12:36:12 +02:00
Jorge Manrubia cd9d9f78c7 We'll add tests here 2025-06-04 17:18:01 +02:00
Jorge Manrubia 9cdc34f0ae Basic tests for detecting stalled cards 2025-06-04 17:18:01 +02:00
Jorge Manrubia 77ff7f43eb This test does not make sense anymore with the new entropy model 2025-06-04 15:03:57 +02:00
Jorge Manrubia db86d17880 Refactor to introduce an entropy model
Instead of keeping two tracks of similar logic (auto-reconsider / auto-close).
2025-06-04 14:40:02 +02:00
Jorge Manrubia 75ce06733a Review entropy tests to include the new behavior and settings 2025-06-04 12:45:04 +02:00
Jorge Manrubia 91787a3523 Revamp entropy configuraiton
- Move both settings to its dedicated model entropy configuration
- A collection can have an entropy configuration, or will default to the account if not
2025-06-04 10:41:08 +02:00
Jason Zimdars acfc7da551 Merge pull request #548 from basecamp/change-collection
Change collection
2025-06-03 08:56:00 -05:00
Mike Dalessio 3a5ce1ca4c No need to delegate auto_closing? anymore
Related to #568
2025-06-02 12:41:55 -04:00
Jorge Manrubia 08c5abfbdb Extract common method to query when entropy is cleaned
We were always quering auto_close_at
https://37s.fizzy.37signals.com/collections/2/cards/743
2025-06-02 18:04:14 +02:00
Jason Zimdars 902a99ca56 Merge branch 'main' into change-collection
* main: (25 commits)
  Add controller to retarget links
  Use more complete regexp
  dep: bundle update
  refactor: Extract a Card::Entropy concern
  Autolink emails and URLs at rendering time
  Remove the "mirror" storage service
  Update production storage to write to the Pure blob store
  Clean up the purestorage config, and add explanatory comments.
  Drop the action_text_markdowns table
  Mount mission control under `/admin/jobs`
  dep: add mission_control-jobs
  Flip the storage mirror to write to Pure as the primary
  Production mirrors Active Storage to `:purestorage`
  Make sure Sentry is configured for the beta env.
  Update lexical
  update lexical
  update lexical
  Create a distinct "beta" environment
  Revert "Patch for cards missing description"
  Add a kamal "ssh" alias
  ...
2025-06-02 09:34:01 -05:00
Mike Dalessio 28ed744d0c refactor: Extract a Card::Entropy concern
to encompass behavior related to auto-closing and auto-reconsidering.

Note that putting this code in a single place reveals an asymmetry
between the actions:

- Auto-closing period is an optional attribute of a collection
- Auto-reconsidering period is hard-coded to 30 days for all collections
2025-06-01 16:50:12 -04:00
Jason Zimdars 5051e5d53d Linter: TrailingWhitespace 2025-05-29 23:27:28 -05:00
Jason Zimdars 922122538a Test granting access 2025-05-29 22:09:33 -05:00
Jason Zimdars d1f01182f2 Update tests 2025-05-28 15:32:00 -05:00
Mike Dalessio 1262285181 test: add missing assertions 2025-05-28 12:13:40 -04:00
Jason Zimdars 9fe5ebdc6b Adjust for change from Array strings to hashes 2025-05-22 17:02:32 -05:00
Jorge Manrubia 5ecb1b1a6d Fix: VCR fixtures mismatches making it need test.key for credentials 2025-05-20 15:02:39 +02:00
Jorge Manrubia 5ac5b5ebde Add test for the composite command 2025-05-16 15:38:22 +02:00
Jorge Manrubia 04e3e56516 Add tests for ai parsing 2025-05-16 15:20:30 +02:00
Jorge Manrubia 2c0f6913ce Test fixes 2025-05-16 15:02:59 +02:00
Jorge Manrubia 7c2a1022a2 Fix test 2025-05-16 14:52:16 +02:00
Jorge Manrubia a5de913608 Improve prompt and tests 2025-05-16 14:49:51 +02:00
Jorge Manrubia 3ccfc165b2 Remove unused command 2025-05-16 14:20:20 +02:00
Jorge Manrubia b8f94c4ecb Add VCR and some initial tests 2025-05-16 13:29:18 +02:00
Jorge Manrubia 50d323d402 Rename method 2025-05-16 13:29:18 +02:00
Jorge Manrubia 7d21443868 Remove unused 2025-05-16 13:29:18 +02:00
Jorge Manrubia 188ae20fd8 Reorder methods 2025-05-16 13:29:18 +02:00
Jorge Manrubia 2510c1e0ac Major rework of the command/ai abstractions
- Big simplification of the overall workflow.
- Composite commands store their commands properly, these are undoable now.
- Child commands are excluded from history
2025-05-16 13:29:18 +02:00
Mike Dalessio (aider) 2f9a0bbe75 Introduce a recurring job to delete unused tags
ref: https://37s.fizzy.37signals.com/collections/693169850/cards/999009072
2025-05-14 12:35:52 -04:00
Jorge Manrubia 59303a4628 Merge branch 'main' into fizzy-do-3
* main: (29 commits)
  Ensure that a "reconsidered" card gets an updated timestamp
  Try a fresh activity design
  Log the authenticated user
  Remove leading space when avatar is hidden on pinned cards
  Display card number in notifications and events
  Ensure that cards with an empty title aren't mysterious in notifs
  bin/dev ensures puma runs solid queue
  Adjust selection color to feel more terminal-y
  Eliminate double-tab behavior
  Clear error state when you start editing
  Color terminal text on error
  Don't indicate spelling errors
  The command is lowercase
  Remind 7 days before, not 30
  Make the icon square
  Subtler bubble styles
  Variable bubble shapes
  Bubble CSS
  Rename 'badge' to 'bubble'
  Address PR feedback
  ...

# Conflicts:
#	app/javascript/controllers/terminal_controller.js
#	app/views/commands/_form.html.erb
2025-05-08 10:29:54 +02:00
Jorge Manrubia d10c45772e Add a clear command to clear filters 2025-05-08 10:20:57 +02:00
Mike Dalessio 4e815fc423 Ensure that a "reconsidered" card gets an updated timestamp
so that it's not closed by the subsequent Card::AutoCloseAllDueJob

ref: https://37s.fizzy.37signals.com/collections/693169850/cards/999009030
2025-05-07 19:04:13 -04:00
Jorge Manrubia 8aecabe6a6 Fix typo 2025-05-07 17:43:06 +02:00
Jorge Manrubia b7f086d361 Add command to tag cards 2025-05-07 16:52:11 +02:00
Jorge Manrubia 31d0271952 Rewrite to use infinitive in the test verbs, for consistency with other tests 2025-05-07 16:48:06 +02:00
Jorge Manrubia 50da28c0be Add command to filter by tag 2025-05-07 16:07:21 +02:00
Jorge Manrubia 6d0855da28 Format 2025-05-07 13:50:58 +02:00
Jorge Manrubia 181e35b5b2 Restore command when clicking on it 2025-05-07 12:03:02 +02:00