Commit Graph

2402 Commits

Author SHA1 Message Date
Jason Zimdars c4aa46a35e Fix that flash notices invisibly overlapped navbar 2025-06-05 11:28:58 -05:00
Jason Zimdars a22a78e60a Use card header in events 2025-06-05 11:28:58 -05:00
Jason Zimdars 33e9a6e645 Cap height and scroll list 2025-06-05 11:28:58 -05:00
Jorge Manrubia 35b8b6f470 Fix: update option when changing index 2025-06-05 17:03:21 +02:00
Mike Dalessio b0a1983553 Invalidate card cache when editing collection entropy config 2025-06-05 09:13:27 -04:00
Jorge Manrubia 1fe16e1416 Merge pull request #585 from basecamp/entropy-settings-ui
Entropy improvements
2025-06-05 09:19:56 +02:00
Jorge Manrubia a5f7f34750 Rename helpers since they are not related to collections only anymore 2025-06-05 09:19:08 +02:00
Jorge Manrubia a014af6ef0 Simplify 2025-06-05 09:16:38 +02:00
Jorge Manrubia 8a63bac3c0 Reorder method 2025-06-05 09:14:51 +02:00
Jorge Manrubia 540254def4 Fix tests after removing the index action
The show action makes more sense in the controller. Also, the filter
scoped was failing due to Rails raising on missing actions (because we
have deleted the index action). Inlining the concern fixes it and clarifies
where this action is implemented.
2025-06-05 09:12:07 +02:00
Jorge Manrubia acd1038359 Extract partials 2025-06-05 08:57:38 +02:00
Jorge Manrubia cb1ee9eabd Format 2025-06-05 08:54:42 +02:00
Jorge Manrubia b9dd7fe808 Tidy up code 2025-06-05 08:54:31 +02:00
Jason Zimdars 6eece93f10 Merge branch 'knobs' into entropy-settings-ui
* knobs:
  Add comment
  Properly parameterize the field name
  Remove leftover console.log
  Correct the reserved area math
  Better a11y
  Connect the range slider
  Basic radio input working
  Expose button so you can delete drafts
  Save button should match card color
  `x` interferes with string entry, try `SHIFT+ENTER` to toggle checkboxes
  Remove unnecessary param and update condition
2025-06-04 20:34:04 -05:00
Jason Zimdars 25d8defa85 We're not using this right now 2025-06-04 20:28:33 -05:00
Jason Zimdars e42c6548b0 Wire up knob UI design 2025-06-04 20:28:20 -05:00
Andy Smith 22a85e6fc5 Contain images 2025-06-04 16:00:46 -05:00
Jason Zimdars 10224c2698 Extract the header so we can explain in context 2025-06-04 15:30:19 -05:00
Jason Zimdars 638bc16b4b Display users and invite on account/settings 2025-06-04 15:16:24 -05:00
Jason Zimdars cc03a3dcb4 Link to workflows 2025-06-04 14:58:09 -05:00
Jason Zimdars 24f4589c02 Link to account settings 2025-06-04 14:57:09 -05:00
Jason Zimdars 9872f35c2a Update to use two-column layout, add title and nav 2025-06-04 14:56:30 -05:00
Andy Smith 989825dcda Add comment 2025-06-04 13:50:27 -05:00
Andy Smith b4e283ab6a Properly parameterize the field name 2025-06-04 13:49:18 -05:00
Andy Smith 5baebefb6b Remove leftover console.log 2025-06-04 13:48:07 -05:00
Andy Smith 8e24b3edff Merge pull request #572 from basecamp/prevent-layout-shift
Add height/width values for images and videos
2025-06-04 13:39:23 -05:00
Andy Smith e513474e36 Correct the reserved area math 2025-06-04 13:38:50 -05:00
Andy Smith 04551d859e Better a11y 2025-06-04 13:06:43 -05:00
Andy Smith 80b1ac8cc9 Connect the range slider 2025-06-04 12:49:32 -05:00
Andy Smith 68ac1f80ec Basic radio input working 2025-06-04 12:10:28 -05:00
Jorge Manrubia 5dc33c304c Restore reminder period I replaced by mistake 2025-06-04 17:17:47 +02:00
Jorge Manrubia a6ffbf7ec6 Rename method 2025-06-04 14:56:19 +02:00
Jorge Manrubia db86d17880 Refactor to introduce an entropy model
Instead of keeping two tracks of similar logic (auto-reconsider / auto-close).
2025-06-04 14:40:02 +02:00
Jorge Manrubia 407141f376 Fix typo 2025-06-04 13:32:05 +02:00
Jorge Manrubia 2870924ca7 Format 2025-06-04 13:14:46 +02:00
Jorge Manrubia e8249d2405 Consider the new default settings for previews 2025-06-04 13:13:45 +02:00
Jorge Manrubia 653186a8b9 Remove unneeded parenthesis 2025-06-04 12:59:02 +02:00
Jorge Manrubia b35aefd07b Format 2025-06-04 12:58:33 +02:00
Jorge Manrubia b8b8a2fa03 Simpler 2025-06-04 12:58:17 +02:00
Jorge Manrubia dd78ec2db2 Shortcut to grab the default entropy configuration 2025-06-04 12:56:11 +02:00
Jorge Manrubia f721bc2c0a Format 2025-06-04 12:52:11 +02:00
Jorge Manrubia 75ce06733a Review entropy tests to include the new behavior and settings 2025-06-04 12:45:04 +02:00
Jorge Manrubia 23f3c42114 Use the new setting to calculate the auto_reconsider_period 2025-06-04 12:34:17 +02:00
Jorge Manrubia f4bbab1485 More concise 2025-06-04 12:13:36 +02:00
Jorge Manrubia f3e6f1e5e0 This is clearer imo 2025-06-04 12:12:10 +02:00
Jorge Manrubia ae1ad9c509 Extract scope to clarify semantics 2025-06-04 12:04:11 +02:00
Jorge Manrubia a39ad0cae3 Not needed 2025-06-04 12:02:19 +02:00
Jorge Manrubia 741a6faaf5 Consider the new recording period for stagnated cards 2025-06-04 12:01:09 +02:00
Jorge Manrubia 6501604a5f All the collections are "auto closing now" 2025-06-04 11:44:18 +02:00
Jorge Manrubia 3c61fc3cdf Add screen to edit account settings to tweak default entropy configuration 2025-06-04 11:25:10 +02:00