Commit Graph

414 Commits

Author SHA1 Message Date
Jason Zimdars 0a500612da Just set the clear filter so restore_collections_filter_from_cookie can do the right thing 2025-05-13 08:24:48 -05:00
Jason Zimdars 368ae5ce6a Handle case where no params are sent because nothing is checked 2025-05-12 22:23:16 -05:00
Mike Dalessio 7dee9ed9d6 Log the authenticated user
to help track down issues reported by individuals in the logs
2025-05-07 17:13:25 -04:00
Jorge Manrubia 9c1185055e Instead of removing uncofirmed commands don't create them in the first place 2025-05-07 14:47:15 +02:00
Jorge Manrubia b017a3fd67 Destroy unconfirmed commands so that they don't end up in the user history 2025-05-07 14:43:11 +02:00
Jorge Manrubia 837de05baa Format 2025-05-07 13:54:22 +02:00
Jorge Manrubia 6d0855da28 Format 2025-05-07 13:50:58 +02:00
Jorge Manrubia 189c7e4a87 Serve the last commands in reverse order so that the most recent one is just above 2025-05-07 12:07:13 +02:00
Jorge Manrubia 8697cabbe2 Show confirmation when submitting certain commands
https://3.basecamp.com/2914079/buckets/37331921/todos/8617430347
2025-05-07 10:20:32 +02:00
Jorge Manrubia 55ea460d3e Handle form errors with a stimulus class
We need to keep the focus in place when submitting the form. We are using a data-turbo-permanent for that. We were rendering the error form with a turbo stream. The problem was that turbo streams ignore permanent elements as per this https://github.com/hotwired/turbo/pull/688, so the system wasn't updating the input field as expected.

Handling this as the stimulus level will also help with managing additional error states (such as the one we need for confirmations).
2025-05-07 08:46:47 +02:00
Jorge Manrubia d7164356f1 Format 2025-05-06 11:20:04 +02:00
Jorge Manrubia 0ef83740f7 Format 2025-05-06 11:10:53 +02:00
Jorge Manrubia d510cbd92e Not used 2025-05-06 11:09:07 +02:00
Jorge Manrubia 712b4157bb Extract undo! method that undoes and destroys 2025-05-06 10:49:46 +02:00
Jorge Manrubia 8ad3461d1b Keep focus on error 2025-05-06 10:16:38 +02:00
Jorge Manrubia 0bdbcbf156 Highlight errors 2025-05-06 09:56:12 +02:00
Jorge Manrubia 3e8896ef93 Undo working for assignments 2025-05-06 09:25:52 +02:00
Jorge Manrubia 7a51e13d7c Remove old code 2025-05-06 08:56:56 +02:00
Jorge Manrubia 9d7459f865 Show recent commands 2025-05-06 08:54:58 +02:00
Jorge Manrubia 75558d0056 Move user assignment and validation to the controller 2025-05-06 07:18:27 +02:00
Jorge Manrubia dc4834cb93 Validate commands 2025-05-06 06:55:51 +02:00
Jorge Manrubia 72ffcfac8b Assignments working 2025-05-06 06:45:37 +02:00
Jorge Manrubia 65d809dd8d Basic models for Fizzy do and searches working with them 2025-05-06 06:42:33 +02:00
Jorge Manrubia 2b98db9e66 Flatten out comments and messages
https://37s.fizzy.37signals.com/collections/693169850/cards/999008989#comment_994777841
2025-04-29 19:21:18 +02:00
Jason Zimdars b6658d3081 Bring back custom collections
WIP, still needs UI for creating new custom collections but there are two hard-coded collections and any previously created ones on production should now be available again
2025-04-26 20:49:35 -05:00
Jorge Manrubia 76fc4aeb0e Order method 2025-04-26 09:10:58 +02:00
Jorge Manrubia e90b062440 Configure the autoclose period at the collection level 2025-04-25 13:29:16 +02:00
Jorge Manrubia 6fb0d88079 Tidy up 2025-04-25 08:22:21 +02:00
Jorge Manrubia 55059e968b Fix collection filtering persistence via cookies 2025-04-25 07:22:54 +02:00
Jorge Manrubia 0be58f50a5 Add comment about something that is pending 2025-04-24 18:53:45 +02:00
Jorge Manrubia 79df3bcb2a Compact things a bit 2025-04-24 17:15:41 +02:00
Jorge Manrubia 8e136875ad Inline method 2025-04-24 16:53:00 +02:00
Jorge Manrubia 2652e21055 Remove noisy filter actions 2025-04-24 16:41:40 +02:00
Jorge Manrubia 5277086611 Use plural for consistency 2025-04-24 16:27:41 +02:00
Jorge Manrubia 4aedb70e70 Move to method 2025-04-24 16:27:19 +02:00
Jorge Manrubia b5737ee9ed Rename 2025-04-24 16:06:28 +02:00
Jorge Manrubia a9ad52e390 Rename for consistency 2025-04-24 16:02:32 +02:00
Jorge Manrubia b29d66296a Rename 2025-04-24 14:46:59 +02:00
Jorge Manrubia 92e913d0d5 Rename 2025-04-24 14:30:16 +02:00
Jorge Manrubia 13b0c0fc41 First pass to tidy up activity time rendering 2025-04-24 12:28:16 +02:00
Jorge Manrubia 965100df51 Access events through collections 2025-04-24 12:28:16 +02:00
Jorge Manrubia 54f4bd5144 Generalize event's cards as eventable,add collection
Lots to tidy up but this is working
2025-04-24 12:28:16 +02:00
Jorge Manrubia f166b30f2f Fix: dismiss mention notifications in cards and comments when reading a card 2025-04-24 12:19:20 +02:00
Jorge Manrubia b08326ccbe Merge branch 'main' into plain-text-mentions
* main: (48 commits)
  Improve layout and truncation
  This is annoying
  Fix summary
  Remove index columns
  Same treatment for the events index
  New menu filters and navigates
  Don't test for _Added by_ events
  Indention
  @collection is always available when card scoped
  Style
  Remove check for _Added by..._ line
  The placeholder attribute is on the `house-md` element
  Duh, no before destroy commit, but this is still not right!
  No long transactions!
  Don't display published event in threads
  But feels more essentially part of the User, so list first
  Not related to the other two
  Missing controller
  Style
  Errant `bubbles` => `cards` replacement
  ...

# Conflicts:
#	app/models/card.rb
#	app/models/user.rb
#	db/schema.rb
#	db/schema_cache.yml
2025-04-23 17:24:01 +02:00
David Heinemeier Hansson 3d28203224 Use singular staging resource and beef up testing 2025-04-22 14:44:55 +02:00
David Heinemeier Hansson 2d5901fe1e Fix pin turbo stream response rendering 2025-04-22 11:48:19 +02:00
Jorge Manrubia aa3acfeaa8 Add plain text mentions 2025-04-22 11:26:56 +02:00
Jorge Manrubia b0aae3ad9e Reapply "Add a description field for cards"
This reverts commit a4cc143b09.
2025-04-21 16:45:24 +02:00
Jorge Manrubia a4cc143b09 Revert "Add a description field for cards" 2025-04-21 16:41:33 +02:00
Jorge Manrubia fb83b5e70e Merge branch 'main' into add-card-description
* main:
  Fix trailing empty line
  --skip-server in ci setup
  Enumerate all the options for logging in
  Have an empty first-run tenant too
  Convert to conventional Rails style
  Seed multiple seed accounts with basic DSL
  Stlye
  No need to run Solid Cache in development
  Use morphing to replace the card and exclude turbo frames from being replaced
  Name is already schema and UI required
  Cards have a not-null schema and collections destroy all cards on deletion
  No longer used
  Inline touch check thats only used once

# Conflicts:
#	app/views/cards/_container.html.erb
2025-04-21 16:04:06 +02:00