Commit Graph

288 Commits

Author SHA1 Message Date
Andy Smith b539cd1ed1 Fix tests 2025-05-13 16:39:11 -05:00
Andy Smith 05aa2e3fb9 Merge branch 'main' into activity-dom
* main:
  Just set the clear filter so `restore_collections_filter_from_cookie` can do the right thing
  Refresh local time target when morphed
  Handle case where no params are sent because nothing is checked
  Ensure checkboxes in menus have full size click targets
  Do or die
  Handle collections that do not auto close
  Ensure dates are re-formatted on turbo frame load
2025-05-13 16:28:17 -05:00
Andy Smith 32cfba82d9 Finish desktop styles 2025-05-13 14:32:51 -05:00
Andy Smith 5c6a53a1bc WIP new sorting 2025-05-13 12:34:07 -05:00
Jorge Manrubia 515396263e Refresh local time target when morphed
Alternative to https://github.com/basecamp/fizzy/pull/486
2025-05-13 05:44:19 +02:00
Andy Smith 9a38c28858 Merge pull request #463 from basecamp/reaction-emojis
Reaction emojis
2025-05-08 11:00:26 -05:00
Mike Dalessio c2c4def3b4 Ensure that cards with an empty title aren't mysterious in notifs
Use something like "Card 55" instead of it being blank or raising an exception.
2025-05-07 15:57:55 -04:00
Jason Zimdars c2a563c699 Need to name the assignee(s) 2025-05-06 15:45:28 -05:00
Andy Smith d3d7a25d07 Stub out basic emoji presets 2025-05-06 10:43:56 -05:00
Andy Smith 4824597649 Larger click area for the clear notification button 2025-05-05 14:49:31 -05:00
Jason Zimdars 4cf0242443 Handle the case where you can only see one collection 2025-05-02 18:08:57 +02:00
Jason Zimdars 360d37d6ff Stub stalled setting, adjust auto-close options 2025-05-02 16:04:32 +02:00
Jason Zimdars 9c813720e5 Remove duplicate class name 2025-05-02 14:18:28 +02:00
Jason Zimdars d5fe842d9a Remove double prefix 2025-04-30 11:38:51 +02:00
Jason Zimdars 8e5209a4a5 Merge branch 'main' into jz-4-30
* main:
  New line
  Not used
  Remove another reference to message
  Remove summary id column too
  Script to re-create system comments
  Drop event summaries too
  Extract method
  Add tests and clean unused events
  Format
  Remove default chronological order
  Format
  Create system comments on events
  Rename test that was being skipped
  Flatten out comments and messages
2025-04-30 11:30:04 +02:00
Jason Zimdars 6ed5549c1b 'Reported' -> 'Added' 2025-04-30 10:29:16 +02:00
Jason Zimdars efac175251 Incorrect event action 2025-04-30 09:51:17 +02:00
Jorge Manrubia 4ff55df2e0 Create system comments on events 2025-04-29 20:33:07 +02:00
Jason Zimdars 92f0d078b8 Update filter, we're not setting indexed_by 2025-04-27 15:55:40 +02:00
Jason Zimdars 137a16a810 Move to concern 2025-04-26 19:26:34 -05:00
Jason Zimdars ff5ecf305e Merge branch 'main' into jz-4-25
* main:
  Reorder methods
  Fix: dismiss notifications from comments
  Configure the autoclose period at the collection level
2025-04-25 13:50:53 -05:00
Jason Zimdars e82241669f Fix card icons 2025-04-25 12:45:15 -05:00
Jorge Manrubia e90b062440 Configure the autoclose period at the collection level 2025-04-25 13:29:16 +02:00
Jorge Manrubia 54d7327ccd Merge branch 'main' into events-revamp
* main:
  Account for stages where the color isn't set
  Choose workflows from a small preview
  Add missing filter display classes, style input
  Scroll users list, adjust layout
  Workflows and card perma polish
  Type polish and sizing constraints
  dep: AR::Tenanted: no implicit db migrations
  New layout for collections settings, stub entropy setting
  Adjust collection line to contrast with comment excerpts
  Adjust perma layout for larger cards
  Give the timeline a little space on each side
2025-04-25 09:41:29 +02:00
Jason Zimdars 783e7d12a1 Scroll users list, adjust layout 2025-04-24 16:59:48 -05:00
Jorge Manrubia 25dbd77acd Tidy up things a bit removing dups and splitting methods 2025-04-24 18:01:49 +02:00
Jorge Manrubia 27f6006b58 Does not belong here anymore 2025-04-24 13:48:53 +02:00
Jorge Manrubia 905ccb9b4b Make comments the event's host 2025-04-24 13:45:48 +02:00
Jorge Manrubia 18cc24e1d3 Add an event prefix named after the model now that events are generic 2025-04-24 13:20:09 +02:00
Jorge Manrubia 13b0c0fc41 First pass to tidy up activity time rendering 2025-04-24 12:28:16 +02:00
Jorge Manrubia 54f4bd5144 Generalize event's cards as eventable,add collection
Lots to tidy up but this is working
2025-04-24 12:28:16 +02:00
Jason Zimdars 8c51ca391b Move card delete button to a far less prominent position 2025-04-23 16:39:47 -05:00
Jorge Manrubia 646e4a59bc Fix missing variable name 2025-04-23 18:45:55 +02:00
Jorge Manrubia b08326ccbe Merge branch 'main' into plain-text-mentions
* main: (48 commits)
  Improve layout and truncation
  This is annoying
  Fix summary
  Remove index columns
  Same treatment for the events index
  New menu filters and navigates
  Don't test for _Added by_ events
  Indention
  @collection is always available when card scoped
  Style
  Remove check for _Added by..._ line
  The placeholder attribute is on the `house-md` element
  Duh, no before destroy commit, but this is still not right!
  No long transactions!
  Don't display published event in threads
  But feels more essentially part of the User, so list first
  Not related to the other two
  Missing controller
  Style
  Errant `bubbles` => `cards` replacement
  ...

# Conflicts:
#	app/models/card.rb
#	app/models/user.rb
#	db/schema.rb
#	db/schema_cache.yml
2025-04-23 17:24:01 +02:00
Jorge Manrubia 07d3447e7e Resolve notifications URLs 2025-04-23 14:34:59 +02:00
Jorge Manrubia 2eae58725a Remove notifications' resource relationship
Is confusing since "source" already captures the origin of the notifications. It's
needed to interpret things at rendering time, so we can query things as needed there.
2025-04-23 13:52:47 +02:00
Jorge Manrubia 7c0aff0680 Don't indent case 2025-04-23 13:36:39 +02:00
Jorge Manrubia 043230394e Tidy up event helper code
Also, revert to using a helper method to determine the event action, since this is purely a view concern. Keep method at the event model to identify initial assignments.
2025-04-23 13:35:09 +02:00
Jorge Manrubia 68e2e96076 Fix indentation 2025-04-23 10:44:42 +02:00
Jason Zimdars 9b57480b40 ticket is a vestige of a previous design 2025-04-22 13:55:46 -05:00
Jorge Manrubia 9b4fec936e Move mentions to comments
- It does not make sense to scan "event summaries" for notifications.
- Placing them at the message level prevents us from using the generic approach to extract the mentionable content
2025-04-22 16:17:37 +02:00
David Heinemeier Hansson 3d28203224 Use singular staging resource and beef up testing 2025-04-22 14:44:55 +02:00
Jorge Manrubia 3bf73a0b71 Rename to match actual action 2025-04-22 14:22:23 +02:00
Jorge Manrubia 4f06473405 Notifications for mentions showing up 2025-04-22 12:02:48 +02:00
David Heinemeier Hansson 22abf0ba46 Remove anemic concern
Colors are a card concern.
2025-04-22 11:56:41 +02:00
Jorge Manrubia aa3acfeaa8 Add plain text mentions 2025-04-22 11:26:56 +02:00
Jorge Manrubia b0aae3ad9e Reapply "Add a description field for cards"
This reverts commit a4cc143b09.
2025-04-21 16:45:24 +02:00
Jorge Manrubia a4cc143b09 Revert "Add a description field for cards" 2025-04-21 16:41:33 +02:00
David Heinemeier Hansson 9e921b85c0 Merge branch 'main' into add-card-description 2025-04-19 20:00:43 +02:00
David Heinemeier Hansson 247524da29 Stlye 2025-04-18 16:47:53 +02:00