Commit Graph

388 Commits

Author SHA1 Message Date
Andy Smith 7cd652db1c Merge pull request #493 from basecamp/activity-dom
Activity dom
2025-05-14 13:10:46 -05:00
Mike Dalessio (aider) 2f9a0bbe75 Introduce a recurring job to delete unused tags
ref: https://37s.fizzy.37signals.com/collections/693169850/cards/999009072
2025-05-14 12:35:52 -04:00
Andy Smith b539cd1ed1 Fix tests 2025-05-13 16:39:11 -05:00
Andy Smith 5c6a53a1bc WIP new sorting 2025-05-13 12:34:07 -05:00
Jorge Manrubia 59303a4628 Merge branch 'main' into fizzy-do-3
* main: (29 commits)
  Ensure that a "reconsidered" card gets an updated timestamp
  Try a fresh activity design
  Log the authenticated user
  Remove leading space when avatar is hidden on pinned cards
  Display card number in notifications and events
  Ensure that cards with an empty title aren't mysterious in notifs
  bin/dev ensures puma runs solid queue
  Adjust selection color to feel more terminal-y
  Eliminate double-tab behavior
  Clear error state when you start editing
  Color terminal text on error
  Don't indicate spelling errors
  The command is lowercase
  Remind 7 days before, not 30
  Make the icon square
  Subtler bubble styles
  Variable bubble shapes
  Bubble CSS
  Rename 'badge' to 'bubble'
  Address PR feedback
  ...

# Conflicts:
#	app/javascript/controllers/terminal_controller.js
#	app/views/commands/_form.html.erb
2025-05-08 10:29:54 +02:00
Jorge Manrubia d10c45772e Add a clear command to clear filters 2025-05-08 10:20:57 +02:00
Mike Dalessio 4e815fc423 Ensure that a "reconsidered" card gets an updated timestamp
so that it's not closed by the subsequent Card::AutoCloseAllDueJob

ref: https://37s.fizzy.37signals.com/collections/693169850/cards/999009030
2025-05-07 19:04:13 -04:00
Jorge Manrubia 8aecabe6a6 Fix typo 2025-05-07 17:43:06 +02:00
Jorge Manrubia b7f086d361 Add command to tag cards 2025-05-07 16:52:11 +02:00
Jorge Manrubia 31d0271952 Rewrite to use infinitive in the test verbs, for consistency with other tests 2025-05-07 16:48:06 +02:00
Jorge Manrubia 50da28c0be Add command to filter by tag 2025-05-07 16:07:21 +02:00
Jorge Manrubia b017a3fd67 Destroy unconfirmed commands so that they don't end up in the user history 2025-05-07 14:43:11 +02:00
Jorge Manrubia 6d0855da28 Format 2025-05-07 13:50:58 +02:00
Jorge Manrubia 181e35b5b2 Restore command when clicking on it 2025-05-07 12:03:02 +02:00
Jorge Manrubia 561e9fad0c Support selecting multiple cards by using a list of numbers (separated by comma, or space)
https://3.basecamp.com/2914079/buckets/37331921/todos/8620236700#__recording_8620273944
2025-05-07 11:30:58 +02:00
Jorge Manrubia dc28f4c9c5 Add command to close cards
https://3.basecamp.com/2914079/buckets/37331921/todos/8620236700
2025-05-07 11:00:22 +02:00
Jorge Manrubia 8697cabbe2 Show confirmation when submitting certain commands
https://3.basecamp.com/2914079/buckets/37331921/todos/8617430347
2025-05-07 10:20:32 +02:00
Jorge Manrubia 22c3c33c0b Merge pull request #460 from basecamp/fizzy-do-initial
Fizzy Do (initial)
2025-05-07 08:57:37 +02:00
Jorge Manrubia 26614c5f02 Fix test 2025-05-07 08:56:32 +02:00
Jason Zimdars ec4be7353b Need a user for this 2025-05-06 12:28:33 -05:00
Jason Zimdars 2d22bef203 We can't rely on count now so test that the specific collection no longer exists 2025-05-06 12:27:02 -05:00
Jorge Manrubia 804a80dde6 Format 2025-05-06 15:18:41 +02:00
Jorge Manrubia 37bf992d67 Add controller tests for undo 2025-05-06 15:17:57 +02:00
Jorge Manrubia e8adf15ba7 Add controller tests 2025-05-06 15:07:02 +02:00
Jorge Manrubia 6961f36a45 Add tests for assignment 2025-05-06 14:57:51 +02:00
Jorge Manrubia 863ced55c4 Add tests 2025-05-06 14:17:28 +02:00
Jorge Manrubia db1a9d8b45 Reapply "Set default "Untitled" title for published cards"
This reverts commit 448989bfa2.
2025-05-01 13:10:58 +02:00
Jorge Manrubia 448989bfa2 Revert "Set default "Untitled" title for published cards"
This reverts commit ca1e002806.
2025-05-01 13:10:36 +02:00
Jorge Manrubia ca1e002806 Set default "Untitled" title for published cards 2025-05-01 13:08:15 +02:00
Jorge Manrubia 0045e48f70 Don't notify yourself of self-assignments 2025-05-01 12:57:25 +02:00
Jorge Manrubia 4f5e8bfc07 Test that system comments won't result in notifications 2025-04-30 12:28:19 +02:00
Jorge Manrubia b6c3e5c090 Add tests and clean unused events 2025-04-30 09:45:41 +02:00
Jorge Manrubia 4ff55df2e0 Create system comments on events 2025-04-29 20:33:07 +02:00
Jorge Manrubia e03f1f7f9b Rename test that was being skipped 2025-04-29 19:23:56 +02:00
Jorge Manrubia 2b98db9e66 Flatten out comments and messages
https://37s.fizzy.37signals.com/collections/693169850/cards/999008989#comment_994777841
2025-04-29 19:21:18 +02:00
Jorge Manrubia f12970c697 We're using seconds now 2025-04-25 22:55:42 +02:00
Jorge Manrubia 0056cafa04 Merge pull request #436 from basecamp/configure-auto-close
Configure the autoclose period for collections
2025-04-25 19:55:19 +02:00
Jorge Manrubia 5e279ab2e1 Fix: dismiss notifications from comments 2025-04-25 19:52:09 +02:00
Jorge Manrubia e90b062440 Configure the autoclose period at the collection level 2025-04-25 13:29:16 +02:00
Jorge Manrubia 501a3b2b44 Add test to make sure you can't access innaccessible collections via filtering either 2025-04-25 07:23:11 +02:00
Jorge Manrubia 40368032f2 Split notifiers for comments and cards
This lets us remove the annoying if to check the card
2025-04-24 15:19:42 +02:00
Jorge Manrubia 905ccb9b4b Make comments the event's host 2025-04-24 13:45:48 +02:00
Jorge Manrubia 18cc24e1d3 Add an event prefix named after the model now that events are generic 2025-04-24 13:20:09 +02:00
Jorge Manrubia e8cffd0717 Add missing test 2025-04-24 12:37:25 +02:00
Jorge Manrubia 54f4bd5144 Generalize event's cards as eventable,add collection
Lots to tidy up but this is working
2025-04-24 12:28:16 +02:00
Jorge Manrubia 38e16ab9ee Remove dummy test I had created for debugging purposes 2025-04-24 12:20:25 +02:00
Jorge Manrubia f166b30f2f Fix: dismiss mention notifications in cards and comments when reading a card 2025-04-24 12:19:20 +02:00
Jorge Manrubia d2237c2a68 Remove trace 2025-04-23 23:19:38 +02:00
Jorge Manrubia b08326ccbe Merge branch 'main' into plain-text-mentions
* main: (48 commits)
  Improve layout and truncation
  This is annoying
  Fix summary
  Remove index columns
  Same treatment for the events index
  New menu filters and navigates
  Don't test for _Added by_ events
  Indention
  @collection is always available when card scoped
  Style
  Remove check for _Added by..._ line
  The placeholder attribute is on the `house-md` element
  Duh, no before destroy commit, but this is still not right!
  No long transactions!
  Don't display published event in threads
  But feels more essentially part of the User, so list first
  Not related to the other two
  Missing controller
  Style
  Errant `bubbles` => `cards` replacement
  ...

# Conflicts:
#	app/models/card.rb
#	app/models/user.rb
#	db/schema.rb
#	db/schema_cache.yml
2025-04-23 17:24:01 +02:00
Jorge Manrubia 2545604659 Add tests 2025-04-23 17:20:04 +02:00