Commit Graph

1471 Commits

Author SHA1 Message Date
Jason Zimdars 954d209cbc Link should break out of frame 2025-07-03 10:13:09 -05:00
Jason Zimdars 1dfe541bd4 Allow deselecting a Workflow 2025-07-03 10:11:36 -05:00
Jason Zimdars 645d4b3497 Fix broken page title 2025-07-03 09:35:24 -05:00
Mike Dalessio b667c1f9cd PWS manifest uses paths and not URLs 2025-07-03 10:10:03 -04:00
Mike Dalessio a268a5f00b Merge pull request #697 from basecamp/flavorjones/fix-pwa
Fix the PWA manifest to use slugged URLs
2025-07-03 10:05:46 -04:00
Mike Dalessio a565504113 Fix activity feed pagination to fetch on demand
Commit 01c642e6 restructured the page so that the "next page" link was
always in view, meaning the page always loaded the entire history.

Now we load the next day as the user scrolls to the bottom, as intended.
2025-07-03 01:36:21 -04:00
Mike Dalessio 59548ac7eb Fix the PWA manifest to use slugged URLs
ref: https://fizzy.37signals.com/5986089/collections/2/cards/991
2025-07-02 23:51:00 -04:00
Mike Dalessio ccf961dad2 Merge pull request #696 from basecamp/flavorjones/collection-workflow-save
Collection edit page uses turbo frames to avoid resetting the user access form
2025-07-02 22:28:51 -04:00
Mike Dalessio 4589360dd1 Collection publication edits render a turbo frame
so we don't disturb the rest of the edit page.
2025-07-02 22:25:09 -04:00
Mike Dalessio 0799ad050b Collection workflow edits render a turbo frame
so we don't disturb the rest of the edit page.
2025-07-02 22:24:49 -04:00
Mike Dalessio 263bc486ed Collection entropy config edits render a turbo frame
so we don't disturb the rest of the edit page.
2025-07-02 22:24:41 -04:00
Mike Dalessio 36727ba5ea Introduce a separate controller for collection entropy config
which opens the door to rendering turbo frames in the responses to
collection edits.
2025-07-02 17:41:29 -04:00
Jason Zimdars aff0a38b37 Move to scope and inline method 2025-07-02 16:14:25 -05:00
Jason Zimdars 25a33fb9c8 Merge branch 'main' into card-steps
* main: (22 commits)
  Fix that stage should be visible above card background
  Indicate opens menu
  Hide dialog targets from screen readers when closed
  Mark up as heading for screen reader navigation
  Copy for screen readers
  Don't hide the input so it's accessible to screen readers
  Point skip links to correct anchor, don't navigate with turbo
  There aren't any `li` children so just use `div`
  Use headings for screen reader navigation
  Use `h3` for individual cards in collection view
  Make collection title `h1` for screen reader navigation
  Esc should not propagate when closing dialogs
  squash! Remove session controller actions other than delete
  Screen reader: Use heading for comments navigation
  Remove the invitation codes for now
  Remove session controller actions other than delete
  Correct label for field
  Style
  Screen reader: De-duplicate links for each person in account settings
  Account.signal_account is no longer optional
  ...
2025-07-02 16:09:49 -05:00
Jason Zimdars a31637bac7 Merge branch 'main' into accessibility-improvments
* main:
  squash! Remove session controller actions other than delete
  Remove the invitation codes for now
  Remove session controller actions other than delete
  Account.signal_account is no longer optional
  Remove local authentication code
  Drop the password column from the users table.
2025-07-02 16:07:29 -05:00
Jason Zimdars 41e40b5444 Indicate opens menu 2025-07-02 15:57:39 -05:00
Jason Zimdars b8f58dc70b Mark up as heading for screen reader navigation 2025-07-02 15:34:32 -05:00
Jason Zimdars 6b4c32ef9f Copy for screen readers 2025-07-02 15:34:17 -05:00
Jason Zimdars 10893b8fa2 Don't hide the input so it's accessible to screen readers 2025-07-02 15:02:37 -05:00
Jason Zimdars 6504813b4a Point skip links to correct anchor, don't navigate with turbo 2025-07-02 14:53:47 -05:00
Jason Zimdars c19e5a6253 Use headings for screen reader navigation 2025-07-02 14:46:43 -05:00
Jason Zimdars 70d6a7190f Use h3 for individual cards in collection view 2025-07-02 14:42:53 -05:00
Jason Zimdars db99e5928c Make collection title h1 for screen reader navigation 2025-07-02 14:38:29 -05:00
Jason Zimdars 985337a91c Esc should not propagate when closing dialogs 2025-07-02 14:29:15 -05:00
Mike Dalessio 4537037a4c squash! Remove session controller actions other than delete 2025-07-02 15:23:59 -04:00
Jason Zimdars 91aa8be4fc Screen reader: Use heading for comments navigation 2025-07-02 14:22:16 -05:00
Mike Dalessio 7f1b384425 Remove the invitation codes for now
until I circle back for https://3.basecamp.com/2914079/buckets/37331921/todos/8746162337
2025-07-02 15:15:05 -04:00
Mike Dalessio fa1c5f7279 Remove session controller actions other than delete
and do some general cleanup around sessions controllers and the
sign_in_as test helper
2025-07-02 15:03:28 -04:00
Jason Zimdars 08043a7c5e Correct label for field 2025-07-02 14:01:10 -05:00
Jason Zimdars 5262e2812f Style 2025-07-02 13:58:50 -05:00
Jason Zimdars 79eada3e8d Screen reader: De-duplicate links for each person in account settings 2025-07-02 13:56:50 -05:00
Jason Zimdars f4218d9403 Merge branch 'main' into card-steps
* main:
  Script to create Users for existing 37id accounts
  Configure Mission Control to skip tenanted authentication
  Script to update URLs and attachments in cards and comments
  Make sure seeds are creating sluggable tenants
  Script to rename tenants after the QB account id
  Update the signups tests to work with untenanted paths
  Update the Command classes to handle paths with account slugs
  Update bin/dev to point at the new tenant URLs
  Patch Active Storage controllers to generate slugged URLs
  Point Action Cable at the slugged cable endpoint
  Extract pieces from the tenanting initializer
  Patch Turbo to use the request script name
  Use the new AR::Tenanted convention for action cable connections
  Use a tenant resolver that recognizes the account slug
  dep: Use the patched AR::Tenanted branch
2025-07-02 11:59:40 -05:00
Jason Zimdars f02215c5b7 Add steps to cards 2025-07-01 20:05:20 -05:00
Mike Dalessio 98e6bd8cd7 Point Action Cable at the slugged cable endpoint
I proposed this upstream in https://github.com/rails/rails/pull/55250,
but it's not clear if the presence of script_name should _always_
prefix generated URLs, so for now it's local to Fizzy.
2025-07-01 15:56:14 -04:00
Jorge Manrubia a5f5a4ec26 Remove helper not used anymore because lexical handles it
https://github.com/basecamp/actiontext-lexical/pull/18
2025-07-01 09:44:24 +02:00
Jason Zimdars ffb422ac61 This attribute is no longer needed 2025-06-30 17:31:07 -05:00
Jason Zimdars 3af949edca Merge branch 'main' into filter-ignore-diacritics
* main:
  Clear the comments cache
  Add context for search screens
  Needs changed for both states
  Use lighter icon and update asset
  Add btn--circle class to user edit form
  Organize button variants
  Untangle `avatar btn` crossover styles
  Remove redundant classes and styles for avatars
  Adjust footer line height
  Tweak padding
2025-06-30 17:01:43 -05:00
Andy Smith c7eeb56cfa Clear the comments cache 2025-06-30 16:47:08 -05:00
Jason Zimdars f3c3a72887 Needs changed for both states 2025-06-30 15:00:03 -05:00
Jason Zimdars a8e495db36 Merge branch 'update-bookmark-button'
* update-bookmark-button:
  Use lighter icon and update asset
2025-06-30 14:52:10 -05:00
Jason Zimdars 45f2ace71b Use lighter icon and update asset 2025-06-30 14:47:33 -05:00
Andy Smith 79c0847a0e Add btn--circle class to user edit form 2025-06-30 14:29:09 -05:00
Andy Smith be003cd3f7 Remove redundant classes and styles for avatars 2025-06-30 14:00:59 -05:00
Jason Zimdars 2678f8c099 Convert diacritics to approximations before filtering
- Introduces a helper method for setting the filterable value
- Updates `filter_controller.js` to use `data-filter-text-value` attribute populated with converted content. This was previous `data-value` in the earlier implementation but ignored in the current on.
- Also uses the same helper to make @mentions diacritic insensitive
2025-06-30 13:53:50 -05:00
Jorge Manrubia dc351959e8 Remove creation and closure params 2025-06-27 20:28:40 +02:00
Jorge Manrubia 716ea6cafa Fix label 2025-06-27 13:38:47 +02:00
Jorge Manrubia 4d5017b671 Add chip filters for the new time window filters
rename close => closure to ease interpretation by the LLM
2025-06-27 13:38:45 +02:00
Jason Zimdars fe8e73015c Adjust spacing 2025-06-26 20:14:22 -05:00
Jason Zimdars d81e8b9118 Merge branch 'main' into logo-placeholder-update
* main:
  Need to return all collections so it's not blank
  Button to add a new filter
  Update test for new redirect
  Comparing params is fragile, use `id` for saved filters
  Update summary tests
  Improve summary display in menu
  Add keyboard navigation and filtering to quick filters
  Copy
  Keep stage when clearing
  Keep the current filter params after deleting a saved filter so you can change your mind
  Update test because we now drop all filters on destroy
  New UI for exposing filter options and saving/deleting them
  Unnecessary
  These aren't actually in the events namespace, use utility class
2025-06-26 20:08:54 -05:00
Jason Zimdars 3129b6e205 Use new logo placeholder 2025-06-26 20:08:48 -05:00