f6cd21f7cb
Extract default stages into something that will be created together with a new Workflow in the model
2025-04-18 16:07:01 +02:00
1026408736
Need this for the draft header to be visible
2025-04-18 15:22:59 +02:00
f3000a02c5
Follow render_card_replacement pattern
...
And clean up the rest of the implementation a tad.
2025-04-18 15:20:38 +02:00
7395d4e034
Removing the image can also just be done as a card replacement
2025-04-18 15:14:36 +02:00
04f9a0f83a
Merge branch 'main' into add-card-description
...
* main: (33 commits)
Run beamer accessories in production only
Less noisy logging in production
Inline perma to container partial
Use card replacement for card updates too
Extract helper method to keep partial at a uniform level of abstraction
Remove duplicated conditional
Style
Note that we dont want to keep reloading these frames
I like this even better
Suffix qualifier is unnnecessary
Group partials for container
Match domain language
Fix trailing space
Use card rerendering instead of redirects
Better name
Stick with domain language
Fix tests
Rerender instead of redirect
Style
Extract partials that can be rerendered
...
2025-04-17 16:40:23 -05:00
0e442ac0d0
Use card replacement for card updates too
2025-04-17 15:56:56 +02:00
ac9cbad4f9
I like this even better
2025-04-17 15:32:09 +02:00
62088b66d1
Suffix qualifier is unnnecessary
2025-04-17 15:30:55 +02:00
4dbd8205ce
Fix trailing space
2025-04-17 15:21:14 +02:00
7adbd8d634
Use card rerendering instead of redirects
2025-04-17 15:20:27 +02:00
547e5ea24f
Rerender instead of redirect
2025-04-17 14:54:29 +02:00
4d0dddec46
No need to loop through a job when this is the sole point of the action
2025-04-17 14:31:28 +02:00
87ce4a623b
Even clearer about where these pins are going
2025-04-17 14:31:02 +02:00
1437bcb3b7
Clearer about where these are being sent
2025-04-17 14:29:12 +02:00
fc0cf3917f
Pin without redirect
...
Use turbo stream response to save on the redirect latency
2025-04-17 14:05:26 +02:00
07e801b74c
Fix pinning to tray
...
They need to have a complete dom element that is unique
2025-04-17 13:52:55 +02:00
a5de4863fa
Allow for multiple notifications to be read
...
cc @kevinmcconnell
2025-04-17 11:39:37 +02:00
6c8fe164b3
Read a card should dismiss all notifications
...
Previous code assumed that there was a single notification to dismiss
for that card, but in practice there can be zero or many. If it's zero,
we need to avoid the crash. If it's many, we should dismiss them all.
Also re-rendering the notification stack after dismissing enables us to
remove all the removed cards, as well as reveal any older ones that were
previously outside the visible page size.
This reverts commit 6135909b7e
2025-04-17 09:40:59 +01:00
d257cb5fb6
No longer used
2025-04-16 18:57:47 -05:00
7b3b5c471b
Add a description filed for cards
2025-04-16 18:53:26 -05:00
5dc6e0394f
Style
2025-04-16 17:12:20 +02:00
d8ec2c3364
More natural to fetch that which will be shown first
2025-04-16 16:58:03 +02:00
6135909b7e
Card readings just need to remove the notification
...
No need to broadcast everything again
2025-04-16 16:51:18 +02:00
98401b9536
Explain this
2025-04-16 16:44:04 +02:00
4bb9085737
Hide implementation detail of reading
2025-04-16 16:41:22 +02:00
8ff71b2650
Dont turbo stream when coming from a read_all redirect
2025-04-16 16:21:31 +02:00
5932bf9316
This is rare enough that a redirect is fine
2025-04-16 16:21:16 +02:00
d00a0433e9
Inline anemic method
2025-04-16 15:34:28 +02:00
73f272f132
Use one controller for all notification readings
2025-04-15 19:14:50 +02:00
2ea898324f
We can just set the namespace directly in the class name
2025-04-15 16:36:40 +02:00
680611503d
Distinguish between administering and just changing
2025-04-15 16:00:29 +02:00
2ace519d91
There is only one account, so just check join code directly
2025-04-15 15:35:10 +02:00
a88264ed0a
Merge branch 'main' into consolidate-cards
...
* main: (94 commits)
Source order seems to be significant
Use `card.title`
Nicer flow
Fix string interpolation
Fix constant
Use record lookup
Always use sole
Explained less and extracted nothing of value
Weird double negative
Remove anemic and indirect method that explained nothing
Can use record lookup for workflows
Access control has already been done through the card
Style
Use _path in all cases where we are not potentially changing the domain
Clearer
Spacing
Get rid of card_title
Join the two users controllers but split out role setting
Ensure user is returned
We are not using the parameter
...
2025-04-14 09:40:22 -05:00
289487a383
Source order seems to be significant
...
Regressed in d3c5c86b21
2025-04-14 09:23:57 -05:00
cfb345bc32
Nicer flow
2025-04-13 20:39:09 +02:00
e8a730c239
Fix constant
2025-04-13 20:36:07 +02:00
34232c0e31
Use record lookup
2025-04-13 20:30:03 +02:00
d9a9690137
Always use sole
2025-04-13 20:29:10 +02:00
9e0b9c08c2
Explained less and extracted nothing of value
2025-04-13 20:28:35 +02:00
33278469ef
Weird double negative
2025-04-13 20:26:58 +02:00
a5df54015e
Remove anemic and indirect method that explained nothing
2025-04-13 20:25:59 +02:00
e2a931b657
Can use record lookup for workflows
2025-04-13 20:24:16 +02:00
366fe06113
Access control has already been done through the card
2025-04-13 20:22:53 +02:00
e12ef119da
Style
2025-04-13 20:17:24 +02:00
dbf61f4fc3
Use _path in all cases where we are not potentially changing the domain
2025-04-13 08:17:36 +02:00
7b60748796
Clearer
2025-04-13 08:11:25 +02:00
4ef46ccd19
Spacing
2025-04-13 08:10:47 +02:00
a106b1b6a7
Join the two users controllers but split out role setting
2025-04-12 20:30:47 +02:00
6bbf68a4f9
The tenanted db is the account scope
2025-04-12 20:06:34 +02:00
760cbb6c99
Drop boosts
...
Killed by design.
2025-04-12 18:52:54 +02:00
David Heinemeier Hansson