Commit Graph

1506 Commits

Author SHA1 Message Date
David Heinemeier Hansson 6cd8d54bf7 We werent using any of the other avatar methods 2025-04-22 21:20:18 +02:00
David Heinemeier Hansson 134333ae44 Dont do a lot of work inside a single transaction
Especially with sqlite3!
2025-04-22 21:01:11 +02:00
David Heinemeier Hansson 78d186bebd Really liking the new it-style yields in many places 2025-04-22 20:59:49 +02:00
Jorge Manrubia cdadc0373a Don't trigger unless the mentionable content changes
This is also needed to prevent incorrect triggering on cascade touches!
2025-04-22 18:10:27 +02:00
Jorge Manrubia a567e662e2 Fix: wrong delegation 2025-04-22 17:23:47 +02:00
Jorge Manrubia 9b4fec936e Move mentions to comments
- It does not make sense to scan "event summaries" for notifications.
- Placing them at the message level prevents us from using the generic approach to extract the mentionable content
2025-04-22 16:17:37 +02:00
David Heinemeier Hansson 3d28203224 Use singular staging resource and beef up testing 2025-04-22 14:44:55 +02:00
Jorge Manrubia 3bf73a0b71 Rename to match actual action 2025-04-22 14:22:23 +02:00
Jorge Manrubia beac61699c Not needed 2025-04-22 14:21:26 +02:00
Jorge Manrubia d5f0359338 Extract mentionable content using reflection to remove duplicated logic and the need for additional concerns 2025-04-22 14:19:45 +02:00
Jorge Manrubia 9db675e589 Format 2025-04-22 14:15:40 +02:00
Jorge Manrubia 22df208f9a Render proper content for mentions, don't send mentions to yourself 2025-04-22 14:11:21 +02:00
Jorge Manrubia 8aa99e34b4 Persist notification's creator
Instead of delegating. With a polymorphic relationship, relying on a certain
attribute implies doing things like aliasing "mentioner" to "creator" or similar.
2025-04-22 13:48:43 +02:00
David Heinemeier Hansson 5ea0ec8cb4 Test and fix setting workflow to nothing 2025-04-22 13:05:39 +02:00
David Heinemeier Hansson a7d17b38aa Be confident 2025-04-22 12:44:49 +02:00
David Heinemeier Hansson 827c00ce49 Extract Workflowing concern 2025-04-22 12:32:34 +02:00
David Heinemeier Hansson 20a2965181 Keep scopes together 2025-04-22 12:12:30 +02:00
David Heinemeier Hansson 7a46fd0948 Stick with open/close as a consistent pair instead of active/close 2025-04-22 12:08:56 +02:00
Jorge Manrubia 4f06473405 Notifications for mentions showing up 2025-04-22 12:02:48 +02:00
David Heinemeier Hansson 22abf0ba46 Remove anemic concern
Colors are a card concern.
2025-04-22 11:56:41 +02:00
David Heinemeier Hansson 268e367c6f Unused 2025-04-22 11:53:16 +02:00
Jorge Manrubia aa3acfeaa8 Add plain text mentions 2025-04-22 11:26:56 +02:00
Jorge Manrubia b0aae3ad9e Reapply "Add a description field for cards"
This reverts commit a4cc143b09.
2025-04-21 16:45:24 +02:00
Jorge Manrubia a4cc143b09 Revert "Add a description field for cards" 2025-04-21 16:41:33 +02:00
Jorge Manrubia fb83b5e70e Merge branch 'main' into add-card-description
* main:
  Fix trailing empty line
  --skip-server in ci setup
  Enumerate all the options for logging in
  Have an empty first-run tenant too
  Convert to conventional Rails style
  Seed multiple seed accounts with basic DSL
  Stlye
  No need to run Solid Cache in development
  Use morphing to replace the card and exclude turbo frames from being replaced
  Name is already schema and UI required
  Cards have a not-null schema and collections destroy all cards on deletion
  No longer used
  Inline touch check thats only used once

# Conflicts:
#	app/views/cards/_container.html.erb
2025-04-21 16:04:06 +02:00
Jorge Manrubia 99dbc04e2c Format 2025-04-21 15:20:03 +02:00
Jorge Manrubia ffdec1cc3b Index description too 2025-04-21 15:18:11 +02:00
Jorge Manrubia 491e743c27 Place below associations 2025-04-21 14:48:07 +02:00
David Heinemeier Hansson 89d1b316f0 Name is already schema and UI required
And we are not using these validations for display anywhere.
2025-04-21 09:21:55 +02:00
David Heinemeier Hansson dc2205ee79 Cards have a not-null schema and collections destroy all cards on deletion
This shouldnt be necessary. Maybe remnant of some previous design?
2025-04-21 09:18:42 +02:00
David Heinemeier Hansson ccd98f6d98 Update card.rb 2025-04-19 20:01:41 +02:00
David Heinemeier Hansson 9e921b85c0 Merge branch 'main' into add-card-description 2025-04-19 20:00:43 +02:00
David Heinemeier Hansson 78369725c4 Move card concern logic into those concerns 2025-04-18 17:18:28 +02:00
David Heinemeier Hansson cacee0febb Remove anemic scope 2025-04-18 17:18:13 +02:00
David Heinemeier Hansson f368b9f9c9 Inline anemic method 2025-04-18 17:13:11 +02:00
David Heinemeier Hansson aae6c7b1a2 Indention 2025-04-18 17:09:55 +02:00
David Heinemeier Hansson 7c76bdd96d Drop Scorable concern 2025-04-18 17:07:36 +02:00
David Heinemeier Hansson 7b0d3d033f Fix extra space 2025-04-18 16:08:53 +02:00
David Heinemeier Hansson f6cd21f7cb Extract default stages into something that will be created together with a new Workflow in the model 2025-04-18 16:07:01 +02:00
Jason Zimdars 47d0ae98a1 Remove DraftCommenting 2025-04-16 19:01:21 -05:00
Jason Zimdars 7b3b5c471b Add a description filed for cards 2025-04-16 18:53:26 -05:00
Andy Smith 5ccff34e6b Add Closes Today styles 2025-04-16 10:20:16 -05:00
Andy Smith 6fb69294a3 Smaller badge size 2025-04-16 10:14:24 -05:00
David Heinemeier Hansson 2ced8e643d Clarify a bit 2025-04-16 17:01:32 +02:00
David Heinemeier Hansson 2757cd8e62 Dont render inline 2025-04-16 16:49:16 +02:00
David Heinemeier Hansson 4bb9085737 Hide implementation detail of reading 2025-04-16 16:41:22 +02:00
David Heinemeier Hansson 397fc1d2bd Only broadcast creations 2025-04-16 16:21:54 +02:00
Andy Smith adad6dd657 Remind 7 days before auto close 2025-04-15 13:24:40 -05:00
Andy Smith eeadc1c494 Make it look like a stamp 2025-04-15 13:22:12 -05:00
Andy Smith ad80aee38e Stub out working auto close reminder 2025-04-15 13:15:29 -05:00