Commit Graph

766 Commits

Author SHA1 Message Date
Jason Zimdars d4e540d633 Need to replace the entire block, not just the buttons in most cases
Fixes that closure notice was missing from views
2025-11-28 08:36:41 -06:00
Mike Dalessio 79c9ea2ce1 Remove a bunch of N+1s
related to notification and comment rendering
2025-11-27 11:08:45 -05:00
Jason Zimdars e26845709a Disable focus ring 2025-11-26 11:24:13 -06:00
Jason Zimdars 3d429c1dea Include full name string so you can type your name to filter 2025-11-25 13:19:33 -06:00
Mike Dalessio 3811088db3 Prioritize current user and assigned users in assignment dropdown
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-25 13:46:14 -05:00
Stanko K.R. a7df8260c3 Fix cards getting stuck in edit mode 2025-11-25 15:36:13 +01:00
Stanko K.R. 4e52f9b9a9 Show tags the card is tagged with first 2025-11-25 11:24:21 +01:00
Stanko Krtalić c8169c1972 Merge pull request #1712 from basecamp/fix-background-image-previews
Fix background images not showing up after upload
2025-11-25 08:15:20 +01:00
Stanko K.R. c11a13dc20 Replace the whole card on update 2025-11-25 08:13:18 +01:00
Mike Dalessio e0aa1d257e Drop User.system and replace with Account#system_user 2025-11-24 13:23:57 -05:00
Jason Zimdars 86932803e4 Clarify not now move actions copy 2025-11-24 12:03:34 +01:00
Jason Zimdars a66b40ba51 Display this full size on mobile
Just the icon isn't clear enough
2025-11-22 17:59:33 -06:00
Mike Dalessio b05ecb7809 Update card buttons dynamically
User flows when editing a card look like:
- Click "Edit" → the closure buttons are replaced by "Save changes"
- Submit card form → Saves and restores closure buttons
- Press ESC while editing → Cancels and restores closure buttons

Also, renamed for clarity:
- _title.html.erb → _content.html.erb

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-22 12:14:39 -05:00
Mike Dalessio 4e6a053ff2 Make sure the card edit button targets the turbo frame
Related to 5aaaeab5
2025-11-22 10:15:11 -05:00
Jason Zimdars a9bbd9d539 Special handling on mobile 2025-11-21 16:07:36 -06:00
Jason Zimdars c8012ef4d4 Improve assignments picker when few/short names 2025-11-21 14:29:22 -06:00
Jason Zimdars 5aaaeab5ea Try the edit button on the bottom line 2025-11-21 14:17:41 -06:00
Jason Zimdars 0747eadb81 For some reason 1pw wants to fill this field, avoid overflow 2025-11-21 14:11:44 -06:00
Jason Zimdars d179316662 Merge pull request #1650 from basecamp/column-nav-keyboard
Navigate columns with keyboard
2025-11-21 12:59:32 -06:00
Stanko K.R. 2c1a0301c2 Fix crash on very long card titles 2025-11-21 18:17:49 +01:00
Stanko K.R. 6f8364071c Fix call to non-existant blur action 2025-11-21 17:57:38 +01:00
Stanko K.R. ac2ed4851e Blur comment field after submission 2025-11-21 15:59:22 +01:00
Stanko K.R. 2b23d85653 Add dir=auto to title inputs
See: https://github.com/basecamp/once-campfire/pull/97
2025-11-21 11:13:44 +01:00
Jorge Manrubia a4cc568a71 Merge branch 'main' into column-nav-keyboard
Resolved conflict in app/views/boards/show/_columns.html.erb by combining:
- hide-scrollbar class from main
- navigable-list controller from column-nav-keyboard

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-21 10:54:45 +01:00
Jorge Manrubia 649888dbd4 Making the frame permanent with an id would reconnect the editor causing the dup
This is something we need to fix in Lexxy for good, but for now this patch will do it.

https://github.com/basecamp/lexxy/issues/263
2025-11-21 08:52:10 +01:00
Andy Smith 75a978e972 Merge pull request #1655 from basecamp/hide-title-scrollbar
Add hide-scrollbar utility and use on card titles
2025-11-20 11:37:17 -06:00
Andy Smith 7fe2ea203d Add hide-scrollbar utility and use on card titles 2025-11-20 11:03:10 -06:00
Mike Dalessio 71f2ffbf59 Change "ADDED" to "DRAFTED" when rendering draft cards
ref: https://app.fizzy.do/5986089/cards/3062
2025-11-20 09:32:42 -05:00
Jorge Manrubia 95b2d6ffe6 Make cards activable via keyboard 2025-11-20 11:41:37 +01:00
Jorge Manrubia 0726da2708 Things more or less working 2025-11-20 11:29:09 +01:00
Jason Zimdars 25e2d98c35 Don't label these, they're expected and obvious (I think) 2025-11-19 16:26:55 -06:00
Jason Zimdars 0259cb860d Fix awkward wrapping on mobile 2025-11-19 16:16:16 -06:00
David Heinemeier Hansson 66d397fa80 Eager load lazy frames inside dialogs on hover 2025-11-19 08:28:18 +01:00
Mike Dalessio c2a5c81e21 Older cards do not have a postponed_by user 2025-11-18 15:46:29 -05:00
Andy Smith 249c06e4f6 Straighten out focus ring for the background image button 2025-11-18 11:29:40 +00:00
Andy Smith 7c8ebd1f02 Make sure assign button isn't tabbable when previewing 2025-11-18 11:29:31 +00:00
Jason Zimdars eeeb3a6e7e Remove extra mark-up 2025-11-17 17:38:25 -06:00
Jason Zimdars 51a9edf419 Contain hotkeys inside the button 2025-11-17 17:35:14 -06:00
Jason Zimdars e3e56e8289 Hide hotkeys on mobile 2025-11-17 17:07:28 -06:00
Jorge Manrubia 22d042b900 Fix typo with tag 2025-11-17 20:21:56 +01:00
Kevin McConnell a764a08863 Use card number as ID when dragging
Because the endpoints are `CardScoped` by number, we should also use the
number here for consistency.
2025-11-17 09:12:41 -05:00
Stanko K.R. 32d96db7d9 Replace card id with card number 2025-11-17 09:12:15 -05:00
Jorge Manrubia 906c5245ce Prefer inline partials 2025-11-17 11:29:08 +01:00
Jorge Manrubia c247a430fb Favor consistent style that avoids explicit dom_id calls 2025-11-17 11:21:50 +01:00
Jorge Manrubia d6b602b7d7 Restore refreshes: make sure they play well with cards in editing mode 2025-11-14 15:37:43 +01:00
Jason Zimdars 7650bf9c33 Display stamp in cards view when it's auto-postponed by the system 2025-11-13 18:12:24 -06:00
Jorge Manrubia 17876b30d4 Manage comments with streams
We replacing the full list of comments within a turbo frame, which didn't feel great when you had several comments.
2025-11-13 17:12:46 +01:00
Jorge Manrubia bddbc0c0ac Make comment body area permanent so that morphing/refresh does not touch it 2025-11-13 16:52:54 +01:00
Jason Zimdars 197cf12512 "Post" is too terse
I think we can go back to the longer label now that the hotkeys aren't
inside the button
2025-11-12 17:12:39 -06:00
Jason Zimdars a3f2bc276a Add hotkey indicators 2025-11-12 17:07:24 -06:00