Commit Graph

5337 Commits

Author SHA1 Message Date
Jose Farias 2f7baaff29 create -> create! 2024-10-28 10:47:49 -06:00
Jose Farias cf9b07711a Document left_joins_messageable smell 2024-10-28 10:27:50 -06:00
Jose Farias 5cdf83163c Document with_status name smell 2024-10-28 10:25:56 -06:00
Jose Farias dbad5a1a8c Document intention to persist summary body 2024-10-28 10:24:43 -06:00
Jose Farias 79869858da Pull out new_comment_placeholder helper 2024-10-28 10:23:40 -06:00
Jose Farias 404755c9d9 Clean up Bubble#track_event 2024-10-28 10:20:39 -06:00
Jose Farias e6622a1e7d Use targets for created-by-current-user-controller 2024-10-28 10:14:39 -06:00
Jose Farias c571c4400d Inline EventSummary#tallied_boosts 2024-10-28 10:07:25 -06:00
Jose Farias 8b062b4432 Pull out Bubble#activity_count 2024-10-28 10:07:12 -06:00
Jose Farias e8eb5ac243 Pass filter to filter helpers 2024-10-28 10:06:56 -06:00
Jose Farias 46d1ce4702 Make it clear where the boost_count is coming from 2024-10-27 19:53:37 -06:00
Jose Farias 2fb6ed76b3 Fix comments-dependent scopes 2024-10-27 19:50:06 -06:00
Jose Farias 3bb6419c08 Remove boosted action partial 2024-10-27 17:56:37 -06:00
Jose Farias 61d68bf79d Account for event summaries with no boosts 2024-10-27 17:53:00 -06:00
Jose Farias 287a956364 Let EventSummary do the work to summarize events 2024-10-27 17:41:48 -06:00
Jose Farias 0727414017 Lean into delegated types APIs 2024-10-27 17:39:30 -06:00
Jose Farias f782b43ef5 find_or_create_next_summary -> find_or_create_active_summary 2024-10-27 12:36:37 -06:00
Jose Farias ede04d6d96 Fix search tests 2024-10-27 12:33:33 -06:00
Jose Farias 993870c10c Messageable concerns aren't actually dependent on Messages 2024-10-27 12:23:47 -06:00
Jose Farias 5601949f3b Only tally boosts if there are any 2024-10-27 12:16:36 -06:00
Jose Farias 45ba9b7a70 Use helpers instead of partials for events 2024-10-27 12:13:03 -06:00
Jose Farias f9712ea53f Messageables don't belong to bubble directly 2024-10-27 11:57:33 -06:00
Jose Farias 5ea2004adb Use tag helper for current-user meta 2024-10-27 11:50:42 -06:00
Jose Farias ee96d4425e Inline selector method in created-by-user-controller 2024-10-25 16:14:16 -06:00
Jose Farias 17dab8e310 Remove references to thread 2024-10-25 16:09:20 -06:00
Jose Farias 1b2df2200f Unnecessary after_touch 2024-10-25 16:06:43 -06:00
Jose Farias a3edee6e58 Extract grouping of boosts 2024-10-25 16:06:34 -06:00
Jose Farias 9855ae5b16 Remove min-height on event summary
This was for when we were bundling the boosts client-side and event summaries could be empty
2024-10-25 15:50:41 -06:00
Jose Farias e85f688e35 Remove JS extensions 2024-10-25 15:46:05 -06:00
Jose Farias 7b104287ba Roll up boosts server-side 2024-10-25 15:39:54 -06:00
Jose Farias 9eb07c559b Bucket views already filter for status 2024-10-25 15:28:23 -06:00
Jose Farias 46c2b450da has_one allows for touch: true 2024-10-25 15:25:57 -06:00
Jose Farias 9a562d8ab1 differentiator -> mine 2024-10-25 15:08:22 -06:00
Jose Farias a1c7de721b Remove remaining rollup references 2024-10-25 15:05:07 -06:00
Jose Farias 85d47a35ab threadables -> messageables 2024-10-25 15:03:31 -06:00
Jose Farias 3cd1d34f9d Thread entries relay touches to thread 2024-10-24 19:27:55 -06:00
Jose Farias 4e3eee57f5 map -> pluck 2024-10-24 18:16:41 -06:00
Jose Farias 2387abbe7c Merge branch 'main' into threadables
* main:
  Stub bookmark buttons
  Move delete to filters index
  Move edit to the index
2024-10-24 18:15:54 -06:00
Jose Farias 78232fabf8 map -> pluck 2024-10-24 18:15:23 -06:00
Jose Farias f5b01415aa Bubble events can be deleted 2024-10-24 18:01:32 -06:00
Jose Farias b16d2ed2d8 Pull out .#isBoosted() in rollup-controller 2024-10-24 17:53:36 -06:00
Jose Farias 652ec68e9c Threadables should thread entry 2024-10-24 17:48:32 -06:00
Jose Farias 2a4a07f00a Typo in rollup-controller 2024-10-24 17:45:35 -06:00
Jose Farias 3db14a117c Store stage ids in event particulars 2024-10-24 17:36:40 -06:00
Jose Farias 2dd719e94b Don't summarize boosts if there are none 2024-10-24 17:36:26 -06:00
Jose Farias c57f18c20c Materialize abstract thread
The domain language is clearer if we just persist a thread. Also rename some models so their purpose is clear.
2024-10-24 17:36:14 -06:00
Jose Farias 3543121d3d thread-controller -> created-by-current-user-controller 2024-10-24 16:00:09 -06:00
Jose Farias ad88f90302 Fine not to denormalize user names in events 2024-10-24 15:50:00 -06:00
Jose Farias e2f608eb71 Remove *_names accessors for bucket views 2024-10-24 15:47:39 -06:00
Jose Farias 08184d0ec8 Give rollups a min height 2024-10-24 15:14:19 -06:00