 David Heinemeier Hansson
|
3ff7a88294
|
Style
|
2025-11-02 18:11:00 +01:00 |
|
|
David Heinemeier Hansson
|
fd61b4426c
|
Conventional to do includes first
|
2025-11-02 18:09:30 +01:00 |
|
|
David Heinemeier Hansson
|
828ac5d2c1
|
Conventional order of actions
|
2025-11-02 18:08:49 +01:00 |
|
|
David Heinemeier Hansson
|
43069b1ea4
|
Extract Users::JoinsController from overloaded UsersController
Good code smell is when the before_action callbacks stack up but can't
be shared across actions
|
2025-11-02 17:49:25 +01:00 |
|
|
David Heinemeier Hansson
|
bced7405df
|
Extract events loading from overloaded UsersController
|
2025-11-02 17:31:28 +01:00 |
|
|
David Heinemeier Hansson
|
6a62df470c
|
No longer used
|
2025-11-02 16:34:29 +01:00 |
|
|
David Heinemeier Hansson
|
877e62dec5
|
No CR when there are only two statements
|
2025-11-02 16:30:49 +01:00 |
|
|
David Heinemeier Hansson
|
02bd57089d
|
Use before_action to pull up account assignment
|
2025-11-02 16:04:44 +01:00 |
|
|
David Heinemeier Hansson
|
c834cce504
|
Simplify join code creation and validation and test controller
cc @monorkin
|
2025-11-02 15:58:33 +01:00 |
|
|
David Heinemeier Hansson
|
f09183bc9a
|
Don't want to balloon txn, but also don't want to end up with a state with broken data
|
2025-11-02 15:46:05 +01:00 |
|
|
David Heinemeier Hansson
|
2c9845eb62
|
No need to hide that the top-level entropy is tied to the Account
|
2025-11-02 15:24:55 +01:00 |
|
|
David Heinemeier Hansson
|
a1543f2660
|
Inline anemic helper method with no additional explaining purpose
|
2025-11-02 14:20:07 +01:00 |
|
|
David Heinemeier Hansson
|
d6c88736bd
|
No need for validation when we have rely on update!/create! on db constraints
|
2025-11-02 14:19:26 +01:00 |
|
|
David Heinemeier Hansson
|
0af74bfa11
|
Style
|
2025-11-02 14:17:46 +01:00 |
|
|
David Heinemeier Hansson
|
966aa51a37
|
Get rid of unnecessary touch jobs
touch_all on 10K cards took 6ms in testing
|
2025-11-02 14:15:53 +01:00 |
|
|
David Heinemeier Hansson
|
105585c26c
|
Merge pull request #1451 from basecamp/entropies
Entropy::Configuration -> Entropy
|
2025-11-02 13:59:43 +01:00 |
|
|
David Heinemeier Hansson
|
7052d6ecec
|
Fix style
|
2025-11-02 13:54:46 +01:00 |
|
|
David Heinemeier Hansson
|
2c4159d11a
|
Style
|
2025-11-02 13:29:07 +01:00 |
|
|
David Heinemeier Hansson
|
fb395c8b07
|
Keep all entropy definitions together in the concern
|
2025-11-02 13:17:55 +01:00 |
|
|
David Heinemeier Hansson
|
b3474ec97d
|
Rename Entropy::Configuration to just Entropy
|
2025-11-02 13:11:41 +01:00 |
|
|
David Heinemeier Hansson
|
d29e4dcdcf
|
No CR when there are only two statements in total
|
2025-11-02 12:49:54 +01:00 |
|
|
Jorge Manrubia
|
4e2f56f4c0
|
Extract concern, add tests
|
2025-11-02 09:44:50 +01:00 |
|
|
Jorge Manrubia
|
2ec5d37947
|
Add support for remote videos too
|
2025-11-02 09:38:48 +01:00 |
|
|
Jorge Manrubia
|
ac507aa754
|
Add support for remote images in the seeding system
|
2025-11-02 09:24:38 +01:00 |
|
|
David Heinemeier Hansson
|
e6459cede3
|
Use existing authorization method
|
2025-11-02 08:34:06 +01:00 |
|
|
David Heinemeier Hansson
|
8e48167774
|
Merge branch 'main' into events-daily-cut-off
|
2025-11-02 08:12:02 +01:00 |
|
|
Jorge Manrubia
|
b5c25cce2b
|
Redundant concat
|
2025-11-02 00:06:23 +01:00 |
|
|
Jorge Manrubia
|
e726335833
|
WIP for seeding accounts
|
2025-11-02 00:05:38 +01:00 |
|
|
Jorge Manrubia
|
8400bb0a82
|
Optimize: only do one loop to group the cards on the initial grouping
There can be many unread notifications. We want to keep the complexity lineal.
|
2025-11-01 17:49:48 +01:00 |
|
|
Jorge Manrubia
|
8947624524
|
Optimize: group on the initial rendering of the tray once, and then start grouping dynamically
Performance optimization to save loops
|
2025-11-01 17:31:48 +01:00 |
|
|
Jorge Manrubia
|
b21f6e1a6e
|
Group notifications for the same card as they show up
|
2025-11-01 17:31:48 +01:00 |
|
|
Jason Zimdars
|
b07345724a
|
Merge pull request #1438 from basecamp/profile-layout
Put profile boxes side-by-side
|
2025-10-31 17:11:30 -05:00 |
|
|
Jason Zimdars
|
56d30d6d97
|
Merge pull request #1439 from basecamp/event-title-style
Underline event titles
|
2025-10-31 17:09:04 -05:00 |
|
|
Jason Zimdars
|
693fe6bf50
|
Merge pull request #1435 from basecamp/bar-icon-align
Align bar shortcuts better
|
2025-10-31 17:07:49 -05:00 |
|
|
Jason Zimdars
|
2a8d361c5a
|
Merge pull request #1440 from basecamp/new-board-in-nav
Shift Add Board around in the nav
|
2025-10-31 17:05:48 -05:00 |
|
|
Jason Zimdars
|
b56ea485c0
|
Merge pull request #1442 from basecamp/new-card-hotkey
Add hotkey to create a new card
|
2025-10-31 17:04:02 -05:00 |
|
|
Jason Zimdars
|
62de1b4b55
|
Merge pull request #1445 from basecamp/animate-popups
Animate popups
|
2025-10-31 17:02:22 -05:00 |
|
|
Jason Zimdars
|
4b7cd8828f
|
Style notice
|
2025-10-31 16:58:21 -05:00 |
|
|
Jason Zimdars
|
ccbc7cd416
|
Need a special human name for this one, move to a method
|
2025-10-31 16:41:50 -05:00 |
|
|
Jason Zimdars
|
f851cf8ff3
|
Polish branding line
|
2025-10-31 16:29:48 -05:00 |
|
|
Jason Zimdars
|
54c4f09f0f
|
+ Newline EOF
|
2025-10-31 16:24:32 -05:00 |
|
|
Andy Smith
|
2cab272ee8
|
Remove unused class
|
2025-10-31 16:23:22 -05:00 |
|
|
Andy Smith
|
7ba686644c
|
Rename fizzy-menu to boxcar-menu
|
2025-10-31 16:22:08 -05:00 |
|
|
Jason Zimdars
|
f962368155
|
Treat the collection link like a back button rather than a title
|
2025-10-31 16:20:42 -05:00 |
|
|
Andy Smith
|
54e3c146d1
|
Animate all popups
|
2025-10-31 16:19:37 -05:00 |
|
|
Jason Zimdars
|
e6e6eb1404
|
Clean up account and collection settings screens
|
2025-10-31 16:13:12 -05:00 |
|
|
Andy Smith
|
5adc222079
|
Use C instead of A
|
2025-10-31 16:05:38 -05:00 |
|
|
Andy Smith
|
3ea5d4d632
|
Add hotkey to create a new card
|
2025-10-31 16:00:03 -05:00 |
|
|
David Heinemeier Hansson
|
91263556a9
|
Ensure there is a limit of 100 events per column per day
Otherwise these pages can get very heavy
|
2025-10-31 21:57:17 +01:00 |
|
|
Andy Smith
|
3dbb466ae7
|
Shift Add Board around in the nav
|
2025-10-31 15:42:28 -05:00 |
|