Commit Graph

7496 Commits

Author SHA1 Message Date
Jason Zimdars cde8634bfe Adjust the stages column sizing 2025-04-22 12:59:36 -05:00
Jason Zimdars 51ef76ff4b This was on the wrong element
Caused some pinned cards to be an irregular height
2025-04-22 12:04:53 -05:00
Jason Zimdars 4f87472e5a Restore clicks on pinned cards 2025-04-22 12:00:49 -05:00
Jorge Manrubia cdadc0373a Don't trigger unless the mentionable content changes
This is also needed to prevent incorrect triggering on cascade touches!
2025-04-22 18:10:27 +02:00
Mike Dalessio bcd6468dc7 Merge pull request #424 from basecamp/dependabot/bundler/nokogiri-1.18.8
Bump nokogiri from 1.18.7 to 1.18.8
2025-04-22 11:48:50 -04:00
Jorge Manrubia a567e662e2 Fix: wrong delegation 2025-04-22 17:23:47 +02:00
Jorge Manrubia 9b4fec936e Move mentions to comments
- It does not make sense to scan "event summaries" for notifications.
- Placing them at the message level prevents us from using the generic approach to extract the mentionable content
2025-04-22 16:17:37 +02:00
Jorge Manrubia 81961a3523 Fix unclosed tag 2025-04-22 15:30:03 +02:00
Jorge Manrubia c75d4cb329 Fix broken permalinks 2025-04-22 15:26:56 +02:00
David Heinemeier Hansson dcf135c003 Fix rubocop 2025-04-22 14:45:22 +02:00
David Heinemeier Hansson 3d28203224 Use singular staging resource and beef up testing 2025-04-22 14:44:55 +02:00
Jorge Manrubia 3bf73a0b71 Rename to match actual action 2025-04-22 14:22:23 +02:00
Jorge Manrubia beac61699c Not needed 2025-04-22 14:21:26 +02:00
Jorge Manrubia d5f0359338 Extract mentionable content using reflection to remove duplicated logic and the need for additional concerns 2025-04-22 14:19:45 +02:00
Jorge Manrubia 9db675e589 Format 2025-04-22 14:15:40 +02:00
Jorge Manrubia 22df208f9a Render proper content for mentions, don't send mentions to yourself 2025-04-22 14:11:21 +02:00
Jorge Manrubia 8aa99e34b4 Persist notification's creator
Instead of delegating. With a polymorphic relationship, relying on a certain
attribute implies doing things like aliasing "mentioner" to "creator" or similar.
2025-04-22 13:48:43 +02:00
David Heinemeier Hansson 5ea0ec8cb4 Test and fix setting workflow to nothing 2025-04-22 13:05:39 +02:00
David Heinemeier Hansson 8e35a3de9c Test workflowing updates card stages on change 2025-04-22 13:03:31 +02:00
David Heinemeier Hansson a7d17b38aa Be confident 2025-04-22 12:44:49 +02:00
David Heinemeier Hansson 827c00ce49 Extract Workflowing concern 2025-04-22 12:32:34 +02:00
David Heinemeier Hansson 20a2965181 Keep scopes together 2025-04-22 12:12:30 +02:00
David Heinemeier Hansson 7a46fd0948 Stick with open/close as a consistent pair instead of active/close 2025-04-22 12:08:56 +02:00
Jorge Manrubia 4f06473405 Notifications for mentions showing up 2025-04-22 12:02:48 +02:00
David Heinemeier Hansson 22abf0ba46 Remove anemic concern
Colors are a card concern.
2025-04-22 11:56:41 +02:00
David Heinemeier Hansson 268e367c6f Unused 2025-04-22 11:53:16 +02:00
David Heinemeier Hansson 2d5901fe1e Fix pin turbo stream response rendering 2025-04-22 11:48:19 +02:00
Jorge Manrubia aa3acfeaa8 Add plain text mentions 2025-04-22 11:26:56 +02:00
David Heinemeier Hansson 9b9acf36ae Events track due_date changes in particulars, not as a direct attribute 2025-04-22 11:21:09 +02:00
David Heinemeier Hansson 58c7eb41bb AI slop for the honcho seed data 2025-04-22 09:55:59 +02:00
dependabot[bot] 682da733da Bump nokogiri from 1.18.7 to 1.18.8
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.18.7 to 1.18.8.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.18.7...v1.18.8)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-version: 1.18.8
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-22 04:58:30 +00:00
Mike Dalessio 5b10b3a16e Merge pull request #421 from basecamp/flavorjones-dep-rails-e9ee790d
dep: update rails to `e9ee790d`
2025-04-21 13:05:52 -04:00
Mike Dalessio 01d741b3f4 dep: update rails 2025-04-21 13:03:49 -04:00
Jorge Manrubia 6d4691f32b Merge pull request #420 from basecamp/descriptions-fix
Add card's description field
2025-04-21 17:28:18 +02:00
Jorge Manrubia 4f0cf0f5cb Fix autosave working with the new description field 2025-04-21 17:05:35 +02:00
Jorge Manrubia 2c3ec3e806 Fix: Create new cards wasn't working 2025-04-21 17:00:25 +02:00
Jorge Manrubia 1680095266 Remove invalid " 2025-04-21 16:45:35 +02:00
Jorge Manrubia b0aae3ad9e Reapply "Add a description field for cards"
This reverts commit a4cc143b09.
2025-04-21 16:45:24 +02:00
Jorge Manrubia 6392180493 Merge pull request #419 from basecamp/revert-408-add-card-description
Revert "Add a description field for cards"
2025-04-21 16:42:09 +02:00
Jorge Manrubia a4cc143b09 Revert "Add a description field for cards" 2025-04-21 16:41:33 +02:00
David Heinemeier Hansson 4d1a1382e1 Fix seeds for new descriptions 2025-04-21 16:21:20 +02:00
Jorge Manrubia 9ecd7f7a60 Merge pull request #408 from basecamp/add-card-description
Add a description field for cards
2025-04-21 16:06:47 +02:00
Jorge Manrubia fb83b5e70e Merge branch 'main' into add-card-description
* main:
  Fix trailing empty line
  --skip-server in ci setup
  Enumerate all the options for logging in
  Have an empty first-run tenant too
  Convert to conventional Rails style
  Seed multiple seed accounts with basic DSL
  Stlye
  No need to run Solid Cache in development
  Use morphing to replace the card and exclude turbo frames from being replaced
  Name is already schema and UI required
  Cards have a not-null schema and collections destroy all cards on deletion
  No longer used
  Inline touch check thats only used once

# Conflicts:
#	app/views/cards/_container.html.erb
2025-04-21 16:04:06 +02:00
David Heinemeier Hansson 539b26c7df Small enough DSL to inline it 2025-04-21 16:01:01 +02:00
David Heinemeier Hansson 55789b7a34 Merge pull request #416 from basecamp/replace-with-morph
Use morphing in the stream replace the card container
2025-04-21 15:40:28 +02:00
David Heinemeier Hansson ad2c1ca8fc Merge pull request #418 from basecamp/seed-multiple-dev-accounts
Seed multiple seed accounts with basic DSL
2025-04-21 15:27:10 +02:00
David Heinemeier Hansson 581070b22c Fix trailing empty line 2025-04-21 15:26:47 +02:00
David Heinemeier Hansson e1b2b623e8 --skip-server in ci setup 2025-04-21 15:26:19 +02:00
David Heinemeier Hansson 29948d8881 Enumerate all the options for logging in 2025-04-21 15:23:31 +02:00
David Heinemeier Hansson dc12751192 Have an empty first-run tenant too 2025-04-21 15:23:18 +02:00