6fd5168c21
Merge pull request #409 from basecamp/read-zero-or-many-notifs-at-once
...
Read a card should dismiss all notifications
2025-04-17 09:49:24 +01:00
6c8fe164b3
Read a card should dismiss all notifications
...
Previous code assumed that there was a single notification to dismiss
for that card, but in practice there can be zero or many. If it's zero,
we need to avoid the crash. If it's many, we should dismiss them all.
Also re-rendering the notification stack after dismissing enables us to
remove all the removed cards, as well as reveal any older ones that were
previously outside the visible page size.
This reverts commit 6135909b7e
2025-04-17 09:40:59 +01:00
68d1c3cce5
Merge branch 'main' into add-card-description
...
* main:
Fix close card notch state
Add fizzy-app-102 as a replica
2025-04-16 19:09:45 -05:00
94ccbdb601
Fix close card notch state
2025-04-16 19:06:18 -05:00
47d0ae98a1
Remove DraftCommenting
2025-04-16 19:01:21 -05:00
d257cb5fb6
No longer used
2025-04-16 18:57:47 -05:00
7b3b5c471b
Add a description filed for cards
2025-04-16 18:53:26 -05:00
91df76928b
Add fizzy-app-102 as a replica
...
The setup here is a bit rough while we settle some of the details, but
the gist of it is:
- Define accessories to run the primary/replica processes
- Add a web-replica role, which is similar to web but has the
replication-side accessory
- Load the beamer extension on the app's primary tenanted database
Note that we aren't sending any traffic into the replica yet, but it
would be functional to do so. This stage is mainly about testing the
database replication.
2025-04-16 17:46:44 +01:00
622d7c396a
Merge branch 'main' into morning-updates
...
* main: (29 commits)
Copy edit
Change alignment
Clearer assignment icon
No longer used
Note that this need to be able to dynamically appear
Style
Slim it down
Trailing spaces
Clarify a bit
More natural to fetch that which will be shown first
Rely on caching of notifications
Card readings just need to remove the notification
Dont render inline
Explain this
Hide implementation detail of reading
Fixed up controller test
Allow for the footer frames to be hidden on the notifications page
Simplify the containers
Only broadcast creations
Dont turbo stream when coming from a read_all redirect
...
2025-04-16 10:40:18 -05:00
b5090c4b21
Copy edit
2025-04-16 10:39:24 -05:00
00dd312cd6
Change alignment
2025-04-16 10:39:24 -05:00
beae3d9a6b
Clearer assignment icon
2025-04-16 10:39:24 -05:00
5c4c06d74c
No longer used
2025-04-16 10:39:24 -05:00
bee27c9ce9
Whitespace
2025-04-16 10:37:46 -05:00
5eccad2659
Pluralize "Day"
2025-04-16 10:23:58 -05:00
5ccff34e6b
Add Closes Today styles
2025-04-16 10:20:16 -05:00
6fb69294a3
Smaller badge size
2025-04-16 10:14:24 -05:00
7c5a58bf4d
Note that this need to be able to dynamically appear
2025-04-16 17:12:31 +02:00
5dc6e0394f
Style
2025-04-16 17:12:20 +02:00
96cf3af022
Merge pull request #405 from basecamp/refactor-notifications
...
Refactor notifications
2025-04-16 17:10:11 +02:00
00cbe8101c
Slim it down
2025-04-16 17:07:43 +02:00
dd39d03398
Copy edit
2025-04-16 10:06:48 -05:00
d22bea8ac5
Change alignment
2025-04-16 10:05:02 -05:00
cfa2f2d1f9
Trailing spaces
2025-04-16 17:02:48 +02:00
2ced8e643d
Clarify a bit
2025-04-16 17:01:32 +02:00
d8ec2c3364
More natural to fetch that which will be shown first
2025-04-16 16:58:03 +02:00
5ce289642f
Rely on caching of notifications
2025-04-16 16:57:54 +02:00
78fb19789c
Clearer assignment icon
2025-04-16 09:55:41 -05:00
6135909b7e
Card readings just need to remove the notification
...
No need to broadcast everything again
2025-04-16 16:51:18 +02:00
7f944b601f
Remove unused DaysUntilFormatter
2025-04-16 09:49:42 -05:00
2757cd8e62
Dont render inline
2025-04-16 16:49:16 +02:00
98401b9536
Explain this
2025-04-16 16:44:04 +02:00
134e7f5d6e
No longer used
2025-04-16 09:41:48 -05:00
4bb9085737
Hide implementation detail of reading
2025-04-16 16:41:22 +02:00
91194d1b66
Fixed up controller test
2025-04-16 16:37:06 +02:00
ac3307ee23
Allow for the footer frames to be hidden on the notifications page
...
Otherwise you will have multiple notification dom elements with the same
id.
2025-04-16 16:23:05 +02:00
158b694d31
Simplify the containers
...
Need to use CSS to hide headings in empty containers
2025-04-16 16:22:36 +02:00
397fc1d2bd
Only broadcast creations
2025-04-16 16:21:54 +02:00
8ff71b2650
Dont turbo stream when coming from a read_all redirect
2025-04-16 16:21:31 +02:00
5932bf9316
This is rare enough that a redirect is fine
2025-04-16 16:21:16 +02:00
f9952e0fd6
Style
2025-04-16 15:57:02 +02:00
d00a0433e9
Inline anemic method
2025-04-16 15:34:28 +02:00
13c44ba650
Actually need it for the lazy load of course
2025-04-16 12:00:54 +02:00
980345d176
Drop the frame, we will do it with streams
2025-04-16 12:00:11 +02:00
3fc34257c4
No longer used
2025-04-16 11:59:58 +02:00
50e4587dd9
Fix trailing spaces
2025-04-16 11:56:21 +02:00
375afeac7b
Fix test
2025-04-16 11:55:35 +02:00
f1dbe1bcaf
Better prop names
2025-04-15 13:26:41 -05:00
adad6dd657
Remind 7 days before auto close
2025-04-15 13:24:40 -05:00
eeadc1c494
Make it look like a stamp
2025-04-15 13:22:12 -05:00
Kevin McConnell