Commit Graph

7496 Commits

Author SHA1 Message Date
Jason Zimdars a458a90aaa Make these consist from view-to-view 2024-11-18 16:33:38 -06:00
Jason Zimdars 5158467275 Improve hover motion for meta bubbles 2024-11-18 15:57:49 -06:00
Jason Zimdars ecc277c104 No longer used 2024-11-18 15:32:45 -06:00
Jason Zimdars 79f5b4f603 Improve assignee bubble display, especially when there are multiple assignees 2024-11-18 12:38:19 -06:00
Jose Farias 8d05dd27a9 Merge pull request #138 from basecamp/link-chips
Turn filter chips into links
2024-11-18 12:17:08 -06:00
Jose Farias 0c51129e1e name -> key 2024-11-18 12:04:52 -06:00
Jose Farias 3d34bc0512 ** not required 2024-11-18 11:59:28 -06:00
Jose Farias 5c1f6dd5aa Swap one? and many? branches 2024-11-18 11:49:20 -06:00
Jose Farias f5a12ace68 Change title based on selected buckets 2024-11-18 11:48:28 -06:00
Jose Farias 20d4319744 Pass params directly into filter chip helper 2024-11-18 11:45:29 -06:00
Jose Farias 0995eee074 Turn filter chips into links 2024-11-18 11:34:44 -06:00
Jose Farias f17b060906 Move rescoring concerns to bubble 2024-11-15 19:48:53 -06:00
Jose Farias 8cd22a7f20 Merge branch 'main' into activity-score
* main:
  Truncate headings, too
  Polish filter menu
2024-11-15 18:33:35 -06:00
Jose Farias f1c8ae2f5f No need to pluck title
Was a debugging artifact
2024-11-15 18:21:39 -06:00
Jose Farias b4e8adca47 Pre-calculate comment counts and activity scores 2024-11-15 18:17:42 -06:00
Jason Zimdars 85e008e31d Truncate headings, too 2024-11-15 17:57:19 -06:00
Jason Zimdars 0b22305169 Polish filter menu 2024-11-15 17:44:46 -06:00
Jose Farias bf704d6d0f Simplify filter_hidden_field_tag 2024-11-14 22:39:55 -06:00
Jose Farias 0d42021f02 Merge pull request #136 from basecamp/simple-filters
Make filters into a simple form
2024-11-14 21:56:26 -06:00
Jose Farias a9913c28bd No need to call to_sym 2024-11-14 21:53:18 -06:00
Jose Farias fb04249209 Make filters into a simple form 2024-11-14 21:50:38 -06:00
Jason Zimdars b6c4ba3b32 Merge pull request #133 from basecamp/bubble-perma
Bubble perma UI improvements
2024-11-14 16:28:31 -06:00
Jason Zimdars d52f7e67e8 Add boosts feature from sidebar 2024-11-14 16:23:28 -06:00
Jason Zimdars 3147c26582 New flow for bubble background 2024-11-14 15:35:13 -06:00
Jason Zimdars 38faf6cb95 Rework tagging UI to use new menu lisdt 2024-11-14 15:10:47 -06:00
Jason Zimdars 19db41ef52 No need for modal 2024-11-14 14:42:47 -06:00
Jason Zimdars d33226a92b Apply colors in the sidebar 2024-11-14 14:04:35 -06:00
Jason Zimdars b4623b632c No need for turbo frames here either 2024-11-14 12:33:34 -06:00
Jason Zimdars f7d7ea6e49 No need for turbo frames after all 2024-11-14 12:30:05 -06:00
Jason Zimdars ba861544fc Tighten assignment flow 2024-11-14 12:22:30 -06:00
Jason Zimdars 0ff0291c18 More immediate flow for date picking 2024-11-14 11:48:02 -06:00
Jason Zimdars 25e929bb59 Escape param 2024-11-14 11:04:43 -06:00
Jason Zimdars c2df855211 Merge branch 'main' into bubble-perma
* main: (29 commits)
  Add assigners to filter summary
  Use `Current.user`'s name for filter chips
  Allow assigner ids param
  Sort filter params before hashing
  Fix tests
  Test field accessors
  Test filter chips controller
  Test filter terms
  Wire up assigner filters
  Spell out button_to params
  Use Filter class method to digest fixture params
  Add frame to search terms form
  Render each kind of filter in its own frame
  button -> chip
  No need to apply terms from the controller anymore
  Add terms to filter
  buttons -> chips
  Clean up Filter class methods
  KNOWN_PARAMS -> PERMITTED_PARAMS
  Remove most_active as index option
  ...
2024-11-14 10:43:21 -06:00
Jason Zimdars a23bbbd61a Stub new boost button, move pop back to navbar for now 2024-11-13 17:01:21 -06:00
Jose Farias 4a382b535a Merge pull request #131 from basecamp/new-filters
New filtering UI
2024-11-13 14:32:21 -06:00
Jose Farias a2092efc0a Add assigners to filter summary 2024-11-13 14:27:23 -06:00
Jose Farias 058c10d89f Use Current.user's name for filter chips
It'll use the name anyway (instead of "me") when re-rendering the perma after navigating.
2024-11-13 14:02:41 -06:00
Jose Farias cc2b799b1c Allow assigner ids param 2024-11-13 14:01:31 -06:00
Jose Farias 33d1f7f022 Sort filter params before hashing
So that param order doesn't matter
2024-11-13 13:55:46 -06:00
Jose Farias 4dfba46142 Fix tests 2024-11-13 13:55:30 -06:00
Jose Farias af1aa3fd62 Test field accessors 2024-11-13 13:51:54 -06:00
Jose Farias bef8882490 Test filter chips controller 2024-11-13 13:44:33 -06:00
Jose Farias a3fb92d506 Test filter terms 2024-11-13 13:39:04 -06:00
Jose Farias 458a6a1ac2 Wire up assigner filters 2024-11-13 13:34:51 -06:00
Jose Farias 72ddd18bcc Spell out button_to params 2024-11-13 13:23:12 -06:00
Jason Zimdars e9ada829fc Flip them back 2024-11-13 13:12:09 -06:00
Jason Zimdars eee2f8d516 Revert "Not using this after all"
This reverts commit 4137930616.
2024-11-13 12:51:34 -06:00
Jose Farias 768b48ea03 Use Filter class method to digest fixture params 2024-11-13 12:08:23 -06:00
Jason Zimdars 4137930616 Not using this after all 2024-11-12 21:00:23 -06:00
Jason Zimdars 619dcc171c Use turbo frame for assignments 2024-11-12 20:50:17 -06:00