Commit Graph

7496 Commits

Author SHA1 Message Date
David Heinemeier Hansson 992b149395 No longer used 2025-11-03 14:29:01 +01:00
David Heinemeier Hansson f9ff13cdc4 Add http caching for user events 2025-11-03 14:25:32 +01:00
David Heinemeier Hansson c25fcc087a Test avatars controller 2025-11-03 14:21:53 +01:00
David Heinemeier Hansson b05e7c04e1 Ensure you can only delete your own avatar or else you have to be admin 2025-11-03 14:21:48 +01:00
David Heinemeier Hansson 4c2f3ef0b8 Style 2025-11-03 14:21:25 +01:00
David Heinemeier Hansson 3ec9308345 Always bang for exceptions 2025-11-03 14:21:06 +01:00
David Heinemeier Hansson 2f1ee30a2b Remove duplicated nesting 2025-11-03 14:20:57 +01:00
David Heinemeier Hansson aeb23b691c Always use templates for turbo streaming to stay consistentn 2025-11-03 13:46:34 +01:00
David Heinemeier Hansson 0a9e1620a0 No longer needed 2025-11-03 13:46:22 +01:00
David Heinemeier Hansson 225a70fc52 Remove here too 2025-11-03 13:40:20 +01:00
David Heinemeier Hansson 38a7a14466 Remove vector extension that we are no longer using 2025-11-03 13:40:03 +01:00
Jorge Manrubia 3293300b20 Merge pull request #1454 from basecamp/refresh-perma-activity
Better card perma refreshing
2025-11-03 13:23:37 +01:00
Jorge Manrubia 37ce2c98d1 Refresh the cards perma dynamically with page refreshes 2025-11-03 13:04:21 +01:00
Jorge Manrubia 5f7feed6c4 Refresh activity-related bits in the card perma dynamically:
- Remove entropy bubble
- Refresh the auto close notice https://app.box-car.com/5986089/cards/2683
2025-11-03 12:48:57 +01:00
Jorge Manrubia d45f2fc4a9 Merge pull request #1453 from basecamp/steps-flickering
Remove flickering when adding steps
2025-11-03 11:01:06 +01:00
Jorge Manrubia da6d1011fd Replace card replacement with stream actions to prevent flickering when managing steps 2025-11-03 10:59:24 +01:00
Jorge Manrubia 1d6cc37bb4 Add missing blank content validation 2025-11-03 10:57:35 +01:00
Jorge Manrubia 30a825a634 Merge pull request #1450 from basecamp/drafts-rework
Remove "save as draft"
2025-11-03 09:34:56 +01:00
Jorge Manrubia 1df8d42811 Create cards with CTRL/CMD enter 2025-11-03 09:32:29 +01:00
Jorge Manrubia 9d4dd3b00e Remove "save as draft"
Removes the creating status completely as well as the abandoned cards system. It will
always resume drafts if they exist, for a given collection and user.

https://app.box-car.com/5986089/cards/2489
2025-11-03 09:32:29 +01:00
Jorge Manrubia efd5c1dba2 Merge pull request #1452 from basecamp/keep-search
Keep the last search in place
2025-11-03 09:30:54 +01:00
Jorge Manrubia ebe1617f42 Format 2025-11-03 09:29:43 +01:00
Jorge Manrubia b76ff27b96 Keep the last search in place
https://app.box-car.com/5986089/cards/2703
2025-11-03 09:25:46 +01:00
Jorge Manrubia 825184ab1b Memoize since these are invoked several times 2025-11-03 07:30:23 +01:00
Jorge Manrubia bc915c4b05 Extract partials 2025-11-03 07:29:00 +01:00
Jorge Manrubia 733bb4e6d7 Rename tests 2025-11-03 07:25:48 +01:00
Jorge Manrubia bfc0b75e6c Not used 2025-11-03 07:16:11 +01:00
David Heinemeier Hansson 9caf39ad2c Use modern strong params syntax 2025-11-02 20:26:12 +01:00
David Heinemeier Hansson e4cdc15b6a Fix tests 2025-11-02 20:25:11 +01:00
David Heinemeier Hansson 39dc2b6ab9 Prefer explicit turbo stream templates 2025-11-02 20:22:15 +01:00
David Heinemeier Hansson cf503bfba3 Prefer templates for turbo streams in all but the very simplest cases
(And probably even then)
2025-11-02 20:20:01 +01:00
David Heinemeier Hansson 3ccc93294f Style 2025-11-02 18:13:23 +01:00
David Heinemeier Hansson 3ff7a88294 Style 2025-11-02 18:11:00 +01:00
David Heinemeier Hansson fd61b4426c Conventional to do includes first 2025-11-02 18:09:30 +01:00
David Heinemeier Hansson 828ac5d2c1 Conventional order of actions 2025-11-02 18:08:49 +01:00
David Heinemeier Hansson 43069b1ea4 Extract Users::JoinsController from overloaded UsersController
Good code smell is when the before_action callbacks stack up but can't
be shared across actions
2025-11-02 17:49:25 +01:00
David Heinemeier Hansson ada599f6a2 Use latest Rails 2025-11-02 17:31:35 +01:00
David Heinemeier Hansson bced7405df Extract events loading from overloaded UsersController 2025-11-02 17:31:28 +01:00
David Heinemeier Hansson 6a62df470c No longer used 2025-11-02 16:34:29 +01:00
David Heinemeier Hansson 877e62dec5 No CR when there are only two statements 2025-11-02 16:30:49 +01:00
David Heinemeier Hansson 76c87f6b67 Test updating account settings 2025-11-02 16:04:51 +01:00
David Heinemeier Hansson 02bd57089d Use before_action to pull up account assignment 2025-11-02 16:04:44 +01:00
David Heinemeier Hansson c834cce504 Simplify join code creation and validation and test controller
cc @monorkin
2025-11-02 15:58:33 +01:00
David Heinemeier Hansson f09183bc9a Don't want to balloon txn, but also don't want to end up with a state with broken data 2025-11-02 15:46:05 +01:00
David Heinemeier Hansson 2c9845eb62 No need to hide that the top-level entropy is tied to the Account 2025-11-02 15:24:55 +01:00
David Heinemeier Hansson a1543f2660 Inline anemic helper method with no additional explaining purpose 2025-11-02 14:20:07 +01:00
David Heinemeier Hansson d6c88736bd No need for validation when we have rely on update!/create! on db constraints 2025-11-02 14:19:26 +01:00
David Heinemeier Hansson 0af74bfa11 Style 2025-11-02 14:17:46 +01:00
David Heinemeier Hansson 966aa51a37 Get rid of unnecessary touch jobs
touch_all on 10K cards took 6ms in testing
2025-11-02 14:15:53 +01:00
David Heinemeier Hansson 105585c26c Merge pull request #1451 from basecamp/entropies
Entropy::Configuration -> Entropy
2025-11-02 13:59:43 +01:00