Commit Graph

7496 Commits

Author SHA1 Message Date
Jorge Manrubia baadd484b4 Review triage 2025-11-20 21:28:41 +01:00
Mike Dalessio 20020043f1 Merge pull request #1662 from basecamp/flavorjones/fix-up-fk-migration
Make sure the migration to remove FK constraints is robust
2025-11-20 15:20:50 -05:00
Mike Dalessio fb742d6d29 Make sure the migration to remove FK constraints is robust
where we've already removed the constraints.
2025-11-20 15:16:26 -05:00
Jorge Manrubia 3f21ea2329 Revert "Revert "Add more detail to events summaries"" 2025-11-20 21:12:41 +01:00
Jorge Manrubia fd812cf862 Merge pull request #1660 from basecamp/revert-1659-notifications-copy
Revert "Add more detail to events summaries"
2025-11-20 21:12:37 +01:00
Jorge Manrubia 7200af879f Revert "Add more detail to events summaries" 2025-11-20 21:12:10 +01:00
Jorge Manrubia 4aef7230e5 Merge pull request #1659 from basecamp/notifications-copy
Add more detail to events summaries
2025-11-20 21:11:58 +01:00
Jorge Manrubia a48aa84f11 Remove legacy event 2025-11-20 21:11:02 +01:00
Jorge Manrubia 93a80ab8c2 Add more detail to events 2025-11-20 21:07:55 +01:00
Mike Dalessio 4804e1367c Merge pull request #1658 from basecamp/fizzy-remove-foreign-key-constraints
Drop all foreign key constraints
2025-11-20 15:06:00 -05:00
Mike Dalessio 6e67a7787a Drop all foreign key constraints
These have been a contributing cause to some deadlocks, but also this
makes some operational tasks harder (data loading, data truncation)
and has some performance impact on insert/update/delete operations.

The team consensus is that we aren't relying on them, and so we're
comfortable with the referential integrity risk.
2025-11-20 15:01:25 -05:00
Mike Dalessio 23c310e154 Merge pull request #1657 from basecamp/fizzy-admin-stats-20251120
Add total counts and restructure admin stats dashboard
2025-11-20 14:40:40 -05:00
Mike Dalessio 1341830ed2 Add total counts and restructure admin stats dashboard
- Add total counts for accounts and identities alongside 7-day and 24-hour metrics
- Change layout from horizontal to vertical stacking

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-20 14:39:19 -05:00
Jason Zimdars 133a17a75e Just pass the column name string, no need to both with numbers 2025-11-20 11:43:17 -06:00
Andy Smith 75a978e972 Merge pull request #1655 from basecamp/hide-title-scrollbar
Add hide-scrollbar utility and use on card titles
2025-11-20 11:37:17 -06:00
Mike Dalessio 8ce97e85b2 Merge pull request #1652 from basecamp/flavorjones/3062-draft-card-creation-time
Change "ADDED" to "DRAFTED" when rendering draft cards
2025-11-20 12:17:30 -05:00
Andy Smith 7fe2ea203d Add hide-scrollbar utility and use on card titles 2025-11-20 11:03:10 -06:00
Andy Smith 3469965f7a Merge pull request #1644 from basecamp/fix-too-large-filters
Remove special Safari hack
2025-11-20 10:48:22 -06:00
Stanko Krtalić c33802d37b Fix attachemnts (#1627)
* Load keys from tenanted dbs

* Implement sgid swapping

* Fix sgid generation

* Flip the logic to do lookups by tenant and id

* Create missing blobs

* Copy over variations

* fix-active-storage-links: fix mentions

* Fix variant generation

* Fix avatars

* Fix avatars

---------

Co-authored-by: Mike Dalessio <mike@37signals.com>
2025-11-20 11:47:49 -05:00
Jason Zimdars fd3b32fd15 Merge pull request #1643 from basecamp/account-to-cache-key
Add `Current.account` to cache key
2025-11-20 10:27:59 -06:00
Mike Dalessio 7ba4d7ed73 Merge pull request #1653 from basecamp/flavorjones/claude-md
Add a CLAUDE.md and a STYLE.md
2025-11-20 11:18:15 -05:00
Mike Dalessio 7ef7a8e49b Add a CLAUDE.md and a STYLE.md
The CLAUDE.md file is a stripped-down version of a file originally
generated by Claude.

The STYLE.md file is inspired by an internal 37signals style guide.
2025-11-20 10:20:02 -05:00
Mike Dalessio 71f2ffbf59 Change "ADDED" to "DRAFTED" when rendering draft cards
ref: https://app.fizzy.do/5986089/cards/3062
2025-11-20 09:32:42 -05:00
Stanko Krtalić 4217984f1b Merge pull request #1651 from basecamp/add-retries-to-activestorage-analzejob
Retry file analisys on FileNotFoundError
2025-11-20 15:27:25 +01:00
Mike Dalessio 88750a3498 Prefer Time.current to Time.now 2025-11-20 09:13:17 -05:00
Stanko K.R. e8a7b19647 Retry file analisys on FileNotFoundError 2025-11-20 15:09:43 +01:00
Jorge Manrubia 7c0fb3c79b Fix: activate only when the option is set 2025-11-20 14:13:59 +01:00
Jorge Manrubia ccfc1b6058 Support containing actionable items to focused items in the navigable list 2025-11-20 14:03:00 +01:00
Jorge Manrubia eb51edac1c Rename properties 2025-11-20 13:56:27 +01:00
Jorge Manrubia cc4f696a00 Remove trace 2025-11-20 13:46:57 +01:00
Jorge Manrubia c472825a55 Move comment 2025-11-20 13:42:33 +01:00
Jorge Manrubia 20a0e2be9b Extract method 2025-11-20 13:42:25 +01:00
Jorge Manrubia e6918d0726 Highlight cards inside selected columns only 2025-11-20 13:33:01 +01:00
Jorge Manrubia 62d85f9b3b Extract helper for common code across columns 2025-11-20 13:32:50 +01:00
Jorge Manrubia 77613a1c63 Remove debug CSS 2025-11-20 13:06:13 +01:00
Jorge Manrubia 3247841c2d Expanding columns and selection working 2025-11-20 13:00:59 +01:00
Jorge Manrubia 95b2d6ffe6 Make cards activable via keyboard 2025-11-20 11:41:37 +01:00
Jorge Manrubia 0726da2708 Things more or less working 2025-11-20 11:29:09 +01:00
Stanko Krtalić f6cfb5fde4 Merge pull request #1648 from basecamp/fix-user-avatars-in-notification-bundles
Fix missing avatars in notification bundle emails
2025-11-20 11:19:13 +01:00
Stanko K.R. 8a1cbdd0ae Fix links in previews 2025-11-20 10:49:29 +01:00
Kevin McConnell 5aa960b243 Merge pull request #1649 from basecamp/switch-accounts-in-same-window
Don't open account links in new window
2025-11-20 09:45:23 +00:00
Kevin McConnell 4fc85883ee Don't open account links in new window
This allows switching account in-place inside the same PWA or browser
tab.
2025-11-20 09:36:18 +00:00
Stanko K.R. cc41a42221 Fix missing avatars in notification bundle emails 2025-11-20 10:33:42 +01:00
Kevin McConnell e37038c0a6 Merge pull request #1647 from basecamp/avoid-notification-deadlocks
Process notification recipients in consistent order
2025-11-20 09:27:57 +00:00
Kevin McConnell bc73cf692d Process notification recipients in consistent order
We've seen some cases of deadlock when processing notifications, because
locks are gathered on the users in different orders. Let's try sticking
to a consistent order instead, which should cause the jobs to serialize
rather than deadlock.
2025-11-20 09:20:48 +00:00
Jorge Manrubia 3bfab09795 Add keyboard navigation support for board columns
- Add horizontal/vertical navigation configuration options to navigable_list controller
- Support nested navigation (columns contain lists of cards)
- Disable horizontal navigation within individual columns
- Enable horizontal navigation at the column level
- Refactor selection logic into reusable methods

This allows users to navigate between columns with left/right arrow keys
and between cards within a column using up/down arrow keys.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-20 09:34:08 +01:00
Jorge Manrubia 09f18a2087 Navigate columns with the keyboard 2025-11-20 09:21:42 +01:00
Mike Dalessio 19d8e41b38 Merge pull request #1646 from basecamp/flavorjones/improve-search-results
Improve search results
2025-11-19 18:09:18 -05:00
Mike Dalessio 99fe5ff934 Make sure that comments show up in search properly
when the search term appears in both the comment and the card description
2025-11-19 18:02:36 -05:00
Mike Dalessio 378705a30d Deduplicate filter results
when both a card and that card's comments match the search term, we
don't want to show it multiple times.

ref: https://app.fizzy.do/5986089/cards/3030
2025-11-19 17:51:38 -05:00