Commit Graph

362 Commits

Author SHA1 Message Date
David Heinemeier Hansson a8aa2c4f80 Clean up the controller 2025-04-11 16:49:55 +02:00
David Heinemeier Hansson f4ce57e308 Move comments under cards 2025-04-11 16:21:44 +02:00
David Heinemeier Hansson 64b529ce94 Fix indention 2025-04-11 16:12:18 +02:00
Jorge Manrubia 17aa9b97e9 Monkey patch a prepend_order method 2025-04-11 10:28:12 +02:00
Jorge Manrubia eae1669ac3 Touch 2025-04-11 10:20:30 +02:00
Jorge Manrubia 806609e77b Use gild/ungild 2025-04-11 10:20:06 +02:00
Jorge Manrubia b4297ab852 Format 2025-04-11 09:57:45 +02:00
Jorge Manrubia 5360b4ccb4 Add comment 2025-04-11 09:57:45 +02:00
Jason Zimdars 5560976091 Merge branch 'main' into gold-cards
* main:
  Try a segmented toggle for engagement
  Fix tests
  Rework min card design and meta section for all cards
  Move `title` to the `img` element so we get hover in both cases
  Remove sorting filter UI
  Sort Considering and Doing by `updated_at`
  Restore comment action icon
  Fix dot escaping container
  Seen cards should be flat
  Ensure overflow cards are hidden
  Arrow needs to match derived color
  Dialog target needs to be present
  This isn't necessary in the mini card template
  Revert "The button and dialog need not render in previews"
2025-04-10 16:42:45 -05:00
Jason Zimdars 0c107c5894 Fix that cards which were Drafted or in Considering were also being displayed in Doing
CC: @jorgemanrubia
2025-04-10 16:42:40 -05:00
Jason Zimdars 1387ad2581 Sort Considering and Doing by updated_at 2025-04-10 11:06:55 -05:00
Jorge Manrubia fac2fce3d5 Rename scope 2025-04-10 17:18:02 +02:00
Jorge Manrubia 9747d590ea Not used 2025-04-10 17:16:36 +02:00
Jorge Manrubia 2e5b25a30c Always place golden cards first 2025-04-10 17:05:30 +02:00
Jorge Manrubia 7406a1039f Add models to track gold cards and implement basic toggle behavior 2025-04-10 16:48:12 +02:00
Jorge Manrubia c7b3b45977 Merge pull request #391 from basecamp/cards-pagination-2
Paginate collection cards
2025-04-10 15:10:54 +02:00
Jorge Manrubia 695247ae9b Paginate collection cards 2025-04-10 15:09:56 +02:00
Jorge Manrubia c6b2e5461b Simplify conditions to pick up a color 2025-04-10 12:40:14 +02:00
Jason Zimdars acba58f802 Ensure card.color returns default value when there is no stage 2025-04-09 17:06:36 -05:00
Jason Zimdars c1ef706f59 Remove concern 2025-04-09 17:03:39 -05:00
Jason Zimdars e02feece1c Move concern out from under Card and rename
`Colored` is a little icky
2025-04-09 15:42:33 -05:00
Jason Zimdars c55501a6c8 Remove unused display count feature 2025-04-09 14:54:53 -05:00
Jorge Manrubia 473fa1dafd Rename constant 2025-04-09 21:28:29 +02:00
Jorge Manrubia 221bbb3247 Fix renames that the scripts missed 2025-04-09 14:56:59 +02:00
Jorge Manrubia 723e6d94f5 Rename bubbles => cards 2025-04-09 14:50:58 +02:00
Jorge Manrubia 2106fb464a Revert "Scope searches by user"
This reverts commit 47552dd8d7.
2025-04-07 13:42:57 +02:00
Jorge Manrubia 47552dd8d7 Scope searches by user 2025-04-07 13:42:27 +02:00
Jorge Manrubia 9b4169c7ca Scope data by account
With a single database this problem is not as bad, but it feels
safer to do things right. Also, not everyone in an account has access
to all the bubbles.
2025-04-07 13:09:49 +02:00
Jorge Manrubia f403ed070c Downcase tag titles 2025-04-07 10:43:23 +02:00
Jorge Manrubia 99584a17f4 Ignore case when trying to match tags 2025-04-07 06:01:43 +02:00
David Heinemeier Hansson eb0614c44f Use a more ergonomic API for watching
Passing a boolean vs using explicit on/off methods feel too low level
and doesnt read right in most of these cases.
2025-04-06 19:17:26 +02:00
David Heinemeier Hansson 78c82584cf Reads nicer now that we are using long form operations 2025-04-06 18:45:58 +02:00
David Heinemeier Hansson 21211cedca These really are anemic too 2025-04-06 18:16:47 +02:00
David Heinemeier Hansson cc0c88d999 Remove anemic finder 2025-04-06 18:15:13 +02:00
David Heinemeier Hansson eb047aec4d Neater 2025-04-06 13:30:20 +02:00
David Heinemeier Hansson 5e78a1dab1 Make it clearer that this takes a title string not a tag object 2025-04-06 13:28:52 +02:00
David Heinemeier Hansson a58fcd3123 Nicer API 2025-04-06 13:26:10 +02:00
David Heinemeier Hansson cdd78b41ee Tag exclusively by title 2025-04-06 13:19:22 +02:00
David Heinemeier Hansson ee22e69e6e Move taggings to bubbles 2025-04-05 22:19:12 +02:00
David Heinemeier Hansson 6990f1eb05 Alpha sort regardless of capitalization 2025-04-05 16:27:22 +02:00
David Heinemeier Hansson e4c6fe4b55 Shape up pinning API and broadcast in the controller 2025-04-05 15:15:48 +02:00
David Heinemeier Hansson f063116df4 Group related associations together 2025-04-05 13:19:30 +02:00
David Heinemeier Hansson aefbac9c14 Get rid of single-use and slight awkward model scope
Really dont like that raw Arel.sql wrapping that is required.
2025-04-05 13:17:42 +02:00
David Heinemeier Hansson 821f4c43d8 Excess CR 2025-04-05 12:49:19 +02:00
David Heinemeier Hansson 1463fa68f4 Sessions only depend on user and have no callback, so use the faster delete_all 2025-04-05 12:48:52 +02:00
David Heinemeier Hansson 8ff017fc5b Only one invocation of this, not carrying the worth of its indirection
Generally I am wary of including global state checks in the belly of
models. It is one thing to do it as a default parameter, but I think it
is too far to do it inside an actual method.
2025-04-05 12:40:08 +02:00
David Heinemeier Hansson d237885bd4 Extract User::Assignee role
Keep slimming down that User
2025-04-05 12:37:18 +02:00
David Heinemeier Hansson 17bdfb5df5 Already included in the Avatar concern 2025-04-05 12:35:41 +02:00
David Heinemeier Hansson 92ce80cc32 Extract User::Accessor concern
Our User model is getting overloaded
2025-04-05 12:34:39 +02:00
Jorge Manrubia 6512b8c726 Only consider in doing/considering published cards 2025-04-04 17:58:27 +02:00