Commit Graph

241 Commits

Author SHA1 Message Date
Jorge Manrubia 77e9e4b05f Merge pull request #353 from basecamp/sort-completed
Sort completed bubbles by most recently completed first
2025-04-04 17:12:05 +02:00
Jorge Manrubia a7fc325184 Format 2025-04-04 17:01:30 +02:00
Jorge Manrubia 4ac2511771 Remove turbo frame for editing stages 2025-04-04 16:59:51 +02:00
Jorge Manrubia 6eb9240993 Move card preview templates to its own folder 2025-04-04 16:26:51 +02:00
Jorge Manrubia f437aecf00 Sort completed bubbles by most recently completed first 2025-04-04 15:39:00 +02:00
Jorge Manrubia 0e3f756a27 Merge pull request #351 from basecamp/close-with-label
Close as...
2025-04-04 15:09:47 +02:00
Jorge Manrubia 977199e189 Sort by newest first by default
https://37s.fizzy.37signals.com/buckets/693169850/bubbles/999008839
2025-04-04 14:21:06 +02:00
Jorge Manrubia 77d0cd5e7f Close as working with default fallback label 2025-04-04 10:59:53 +02:00
Jorge Manrubia dbae700554 Merge pull request #346 from basecamp/two-columns-refactor
Refactor collections perma + support for doing/considering
2025-04-04 08:29:17 +02:00
Jorge Manrubia 05fc73e2ae Merge pull request #334 from basecamp/user-admins
Add admin role and animate admin toggle
2025-04-04 08:29:03 +02:00
Jason Zimdars 1ea70d7d3b Merge branch 'main' into two-columns-refactor
* main:
  Fix image icons
  Revert "Merge pull request #345 from basecamp/cascade-layers"
  Fine tune notifications states
  Remove empty helper
  Use an icon for the button
  Show button on collection page and notif settings
  Add involvement types to accesses
  Extract a couple components
  Add cascade layers to all CSS files
2025-04-03 19:30:37 -05:00
Jorge Manrubia cfe91c25c9 Add admin role, make sure only admins can remove and promote other users 2025-04-03 17:43:29 +02:00
Kevin McConnell 0820badcc3 Add involvement types to accesses
This provides a way to set the level of involvement that a user has with
a collection, and from which we determine the level of notifications to
send. Users can be access-only, watching, or being notified about
everything.

If you're access-only, you won't get an notifications. If you're
watching, you'll only get notifications for the items you're watching
(which includes the items you've been assigned, have commented on, etc).
If you're set to everything you'll get notifications about all activity
in that collection.

This change replaces our previous concept of subscriptions. Where
previously you'd subscribe to a collection to get notifications in it,
now you'll simply set the notification level on your access.
2025-04-03 16:35:13 +01:00
Jorge Manrubia 41b6f437b0 Update workflow stages with streams 2025-04-03 14:14:28 +02:00
Jorge Manrubia 17c1b2051f Add toggles to switch between doing/considering 2025-04-03 13:46:29 +02:00
Jorge Manrubia 49ef811d25 Load queries asynchronously to leverage concurrency 2025-04-03 13:28:14 +02:00
Jorge Manrubia 5a2b7c5abd Rework buckets index using proper queries and tidy up 2025-04-03 13:26:16 +02:00
Jason Zimdars f7e2d04808 Rework the flow for closing and moving between columns 2025-04-02 17:27:34 -05:00
Mike Dalessio b7c2369988 Fix setting the workflow on a collection
The previous implementation would delete all accesses if the bucket
was not all_access.

I think it's simpler to move the bucket workflow into a separate
Buckets::WorkflowsController, rather than deal with different sets of
params from different forms in the existing BucketsController.
2025-03-30 09:24:56 -04:00
Jason Zimdars 1cf2e24bcc Set buckets at the workflow level
- All bubbles inherit the bucket's set workflow
2025-03-27 14:35:07 -05:00
Mike Dalessio 91de604815 Move event activity loading into Events::DaysController 2025-03-26 07:46:56 -04:00
Mike Dalessio b7e5ca780c Extract the EventsTimeline controller concern 2025-03-26 07:37:42 -04:00
Mike Dalessio 23e4fd9b1c Remove the buckets#index action and view
and have bucket#destroy redirect to root_path
2025-03-25 13:40:36 -04:00
Mike Dalessio a66dc2a789 Move tags and assignments partials out of "bubbles/sidebar"
They're part of the card now, let's name them that way.

Also, rename the "tag" partial to "tagging", following the naming
convention established by the controller.
2025-03-24 17:11:58 -04:00
Mike Dalessio 5ae87d8140 Ensure the tags dropdown is not subject to the cached card fragment
- Rearrange the _tags and _tag partial, so they are properly nested concerns
- Add turbo frames for _tags and _tag
- Load _tag in a separate request, so it's not cached with the card
- Cache _tag using the bubble and the account
- New model behavior: touch Account when tags are added or removed
- New controller action: "new" for taggings toggles, which renders the _tag partial
- Updating taggings responds with a turbo stream response that updates the _tags frame

This is very much a parallel change to what was done with assignments
in #317.
2025-03-24 16:48:11 -04:00
Mike Dalessio df377861fc Merge pull request #317 from basecamp/flavorjones-assignee-card-cache
Assignee dropdown no longer subject to the card fragment cache
2025-03-24 15:27:53 -04:00
Jason Zimdars 4bc125c7eb Load the form in a turbo frame so focused field doesn't intercept hotkeys 2025-03-24 14:15:28 -05:00
Jason Zimdars 9b9e09601e Introduce text-based UI 2025-03-24 11:33:04 -05:00
Mike Dalessio 44650cc36e Reload the assignees turbo frame when assigments are updated
Also, add a cache around the dropdown keyed on [bubble, bucket].
2025-03-21 17:53:41 -04:00
Jason Zimdars 8e26106a07 Reorder and rename activity columns; include system popped events 2025-03-19 13:35:17 -05:00
Jason Zimdars 28a569c49b Tickets 2025-03-17 21:24:08 -05:00
Kevin McConnell f50a880d6b Avoid double render in Avatars#show
After sending the conditional 304 response, we were still attempting to
render the response, which is unnecessary.
2025-03-12 09:05:50 +00:00
Kevin McConnell 49fa8b21a6 Move current user check to controller
This is necessary to a) ensure people can't edit/delete comments they
don't own, and b) make the comment partial cacheable.
2025-03-03 17:04:16 +00:00
Kevin McConnell 942dd27e5c Sort buckets on notification settings 2025-02-27 12:17:32 +00:00
Kevin McConnell ab27371115 Include self in watcher list 2025-02-27 10:51:59 +00:00
Kevin McConnell 385e299db7 Simplify param 2025-02-26 10:53:03 +00:00
Kevin McConnell a802b8de5a Allow managing bucket subscriptions 2025-02-26 10:53:03 +00:00
Kevin McConnell f22742c431 watched_by? should reflect subscriptions too 2025-02-26 10:53:03 +00:00
Kevin McConnell 694783e5f3 Allow toggling watch preference
We use a true/false preference so we can tell the difference between
disabling the watch vs never having the watch. This is so we can toggle
off and on the preferences for a container (like the bucket) without
losing any bubble-specific preferences.
2025-02-26 10:53:03 +00:00
Jason Zimdars d73d3a9daa Constrain boost events 2025-02-24 17:12:46 -06:00
Jason Zimdars 5a4d2a72c8 Remove uniqueness constraint
I'm not sure if this was inadvertent or an artifact of an earlier design but I'm fairly certain we want a more comprehensive list of events here. Especially comments, for example. We should show all the comments that happen in a particular hour on the timeline. There may be places were we need to dial back but for now I'm going to lift the constraint and see how it feels.
2025-02-24 17:01:43 -06:00
Jason Zimdars 530b6e4a90 Stub notifications settings screen 2025-02-21 17:25:44 -06:00
Jason Zimdars 28bdc531b0 Mark individual notifications as read 2025-02-21 16:39:50 -06:00
Jason Zimdars 190e046479 Mark all notifications as read from the index 2025-02-21 12:12:00 -06:00
Jason Zimdars 8cde1883a6 Filter activity by bucket 2025-02-19 18:05:12 -06:00
Jason Zimdars 000bd158eb Reactions on comments 2025-02-18 17:08:56 -06:00
Jason Zimdars 783af287db Don't allow creating duplicate tags 2025-02-14 11:44:52 -06:00
Jason Zimdars edd7e55313 Prevent using # in the stored tag name 2025-02-14 11:23:08 -06:00
Kevin McConnell 483c6cdbe6 Allow updating draft comment with bubble 2025-02-13 14:39:33 +00:00
Kevin McConnell a24817ffb7 Don't show system events in Activity view 2025-02-12 14:31:29 +00:00