4e092407ab
Fix crash due to missing partial
2025-12-10 18:47:00 +01:00
6c73049261
Merge pull request #2053 from basecamp/flavorjones/fix-system-comment-injection
...
Prevent HTML injection into system comments (card activity feed)
2025-12-10 11:01:34 -05:00
e0c821f69b
Autolinking is more robust
...
and handles URLs with CGI params, recognizes more (and multiple)
trailing punctuation marks including entity-encoded punctuation like
`"`.
2025-12-10 10:42:24 -05:00
c5721b8187
Avoid unescaping characters when auto-linking
...
which could lead to Nokogiri unintentionally parsing tags from a
previously-escaped text node.
2025-12-10 10:38:43 -05:00
83360ec6f3
Escape the names used to generate system comments
...
including user names, board titles, column names, and card titles.
2025-12-10 10:38:42 -05:00
fa118a7d83
Add validation for the join code usage limit
...
which is preferred to generating a database error
2025-12-10 10:10:08 -05:00
5ce71bf941
Move Identities to My::Identities
2025-12-10 15:13:35 +01:00
79e77a3780
Handle user update failures
2025-12-10 09:23:53 +01:00
7b30ca203e
Add index actions for Comments and Columns
...
Also, fix crash when a deactivated user is serialized (they don't have
an identity).
2025-12-10 09:23:52 +01:00
bf51950007
Add API for reading notifications
2025-12-10 09:23:52 +01:00
1a24c1373c
Add API for creating and updating boards
2025-12-10 09:23:52 +01:00
f3ff0c605e
Add pagination to most places and fix cards pagination
2025-12-10 09:23:52 +01:00
ba30a301dc
Add API for updating and deactivating users
2025-12-10 09:23:52 +01:00
7a0554774c
Add API for columns
2025-12-10 09:23:52 +01:00
d16b3756de
Add API for reactions
2025-12-10 09:23:52 +01:00
eeed2a8416
Add API for watching cards
2025-12-10 09:23:52 +01:00
ed1002f6c5
Add API for card triage
2025-12-10 09:23:52 +01:00
8a84785056
Add API for tagging cards
2025-12-10 09:23:52 +01:00
c517ef6063
Add API for CRUD actions on steps
2025-12-10 09:23:52 +01:00
8a61ca2a79
Add API for postponing cards
2025-12-10 09:23:52 +01:00
52e65b3c08
Add API for removing card images
2025-12-10 09:23:52 +01:00
1caeea541d
Add API for gilding cards
2025-12-10 09:23:52 +01:00
41115eaf87
Add API for comments CRUD
2025-12-10 09:23:52 +01:00
b4012dfb40
Add API for closing and opening cards
2025-12-10 09:23:52 +01:00
cf52982b8b
Add API for mobing cards between boards
2025-12-10 09:23:52 +01:00
23e6f3b095
Add API for assigning cards
2025-12-10 09:23:52 +01:00
235a94355e
Add card update & delete actions
2025-12-10 09:23:52 +01:00
ae03f2b283
Move tests into their controller tests
2025-12-10 09:23:52 +01:00
259707bf70
Fix identity tests
2025-12-10 09:23:52 +01:00
26fc9ecad4
Add an /identity.json endpoint to obtain the identity accounts and users
2025-12-10 09:23:52 +01:00
3f393c1423
Include card description and tags
2025-12-10 09:23:52 +01:00
a8dc4fb310
Excess whitespace
2025-12-10 09:23:52 +01:00
680f9c0c4d
Add top-level API index support for tags
2025-12-10 09:23:52 +01:00
5ad7b973cb
Add API support for users
2025-12-10 09:23:52 +01:00
983a19fd8a
Create cards via API
2025-12-10 09:23:52 +01:00
f0c0a87c74
Return json URLs for API actions
2025-12-10 09:23:52 +01:00
129b81984f
Creating a new board will return the location header
2025-12-10 09:23:52 +01:00
0ce3a85778
Only allow writing when the access token has permission
2025-12-10 09:23:52 +01:00
96b62d6ec4
Only allow new token to be viewed within 10 seconds
2025-12-10 09:23:52 +01:00
895b0e13b8
Drop the need for access tokens to have a session
2025-12-10 09:23:52 +01:00
db29562c4c
Tie access token directly to session
...
We need to present them differently in the session list and prevent them
from being deleted
2025-12-10 09:23:52 +01:00
b53c0a5385
Correct
2025-12-10 09:23:52 +01:00
d384971ea2
Test the boards API
2025-12-10 09:23:52 +01:00
a81c681a8d
Add access token authentication via HTTP AUTHORIZATION bearer header
2025-12-10 09:23:52 +01:00
d60643f5ef
Allow chromium unstable endpoint
2025-12-09 20:24:09 -05:00
85bd5c2df5
Rails seeded parallel tests ( #2037 )
...
Enable work stealing by default for a tiny speedup at the cost of small
loss in reproducibility.
References https://github.com/rails/rails/pull/56175
2025-12-09 15:50:01 -08:00
94c59a2399
Merge pull request #2033 from basecamp/limit-webhook-response-size
...
Stream response in webhook request manually to check size
2025-12-09 12:16:42 +01:00
29c7926307
Stream response in webhook request manually to check size
...
This addresses a DoS vulnerability where the response might be massive
leading to OOM errors, as the response is read in full in memory by
default.
To prevent this, we need to read the body in chunks, checking the
size of the chunks we've read and raising if we go over a certain limit.
I've set the limit to 100 KB because the responses to these requests
should be fairly small or even empty, and we only care about the status
code in the end.
2025-12-09 11:25:12 +01:00
ea8a78cc22
Fix stale-read race when creating push subscriptions
...
(Caught one such uniqueness exception in the wild)
* 200 OK -> 204 No Content, default status
* No need to touch the subscription when found
* Drop superflous test
2025-12-09 01:34:37 -08:00
b23a5d0b7c
Fix flaky tests caused by leaky show_exceptions twiddling ( #2028 )
...
Rails memoizes `@app_env_config`, so running push subscriptions test
after join codes test will result in running with `show_exceptions:
:none`, causing RecordInvalid to raise instead of returning 422 status.
References #1996
2025-12-08 23:27:36 -08:00
Stanko K.R.