Commit Graph

359 Commits

Author SHA1 Message Date
Jason Zimdars 4433e80691 Make steps non-interactive 2025-07-09 10:56:32 -05:00
Jason Zimdars 9ac5f46875 This shouldn't ever appear on the index, we have a preview partial 2025-07-09 10:44:53 -05:00
Jason Zimdars f1337048bd This shouldn't need to be here, it would never be displayed and does nothing 2025-07-09 10:42:03 -05:00
Jason Zimdars 8f7a373aad Public card templates 2025-07-09 10:16:39 -05:00
Andy Smith fdbb9c185e Merge branch 'main' into collection-nav
* main: (203 commits)
  Re-write help content, try a modal-like display
  Move to internal registry
  Show date instead of time for notifications older than 1 day
  Ensure checks are visible for tags and assignments
  Adjust padding so card number isn't cut off
  Don't color the collection header in considering
  Golden cards bubble to the top of Considering, too
  Adjust card collection header when colored golden
  Allow cards in Considering to gilded
  Hide focus ring on new card titles and step inputs
  Add hover effect for comment edit button
  Add hover effect to overflow button
  Improve multi-account behavior of the PWA
  Remove unneeded *
  Rename test
  Review the code to move cards
  Update editor
  Generalize and delete mentions too
  Remove unused code
  Make sure we don't remove accesses if collection is accessible
  ...
2025-07-08 15:34:01 -05:00
Andy Smith 00d68a482c Move Add Card button to header 2025-07-08 15:30:43 -05:00
Jason Zimdars 98f9ba5512 Allow cards in Considering to gilded 2025-07-07 15:14:33 -05:00
Andy Smith 6e2eacd3d8 Hide focus ring on new card titles and step inputs 2025-07-07 13:23:19 -05:00
Andy Smith f9c7862fc1 Add hover effect for comment edit button 2025-07-07 10:12:32 -05:00
Andy Smith 95dac275fd Add hover effect to overflow button 2025-07-07 10:07:56 -05:00
Andy Smith 84d5f64d1f Merge pull request #695 from basecamp/focus-hover-styles
Focus hover styles
2025-07-07 09:49:08 -05:00
Andy Smith 757ff4ff2b Merge branch 'main' into focus-hover-styles 2025-07-03 15:14:14 -05:00
Jason Zimdars 8f42086703 Truncation for comment author line 2025-07-03 15:06:15 -05:00
Andy Smith 5c2997422f Address PR feedback 2025-07-03 15:00:12 -05:00
Jason Zimdars 5d34cb3f51 Adjust screen for screen readers 2025-07-03 14:37:31 -05:00
Jason Zimdars 645d4b3497 Fix broken page title 2025-07-03 09:35:24 -05:00
Andy Smith 4bc1b36d3d Clean up --hover variables 2025-07-02 16:14:34 -05:00
Jason Zimdars aff0a38b37 Move to scope and inline method 2025-07-02 16:14:25 -05:00
Jason Zimdars 25a33fb9c8 Merge branch 'main' into card-steps
* main: (22 commits)
  Fix that stage should be visible above card background
  Indicate opens menu
  Hide dialog targets from screen readers when closed
  Mark up as heading for screen reader navigation
  Copy for screen readers
  Don't hide the input so it's accessible to screen readers
  Point skip links to correct anchor, don't navigate with turbo
  There aren't any `li` children so just use `div`
  Use headings for screen reader navigation
  Use `h3` for individual cards in collection view
  Make collection title `h1` for screen reader navigation
  Esc should not propagate when closing dialogs
  squash! Remove session controller actions other than delete
  Screen reader: Use heading for comments navigation
  Remove the invitation codes for now
  Remove session controller actions other than delete
  Correct label for field
  Style
  Screen reader: De-duplicate links for each person in account settings
  Account.signal_account is no longer optional
  ...
2025-07-02 16:09:49 -05:00
Jason Zimdars 10893b8fa2 Don't hide the input so it's accessible to screen readers 2025-07-02 15:02:37 -05:00
Jason Zimdars 70d6a7190f Use h3 for individual cards in collection view 2025-07-02 14:42:53 -05:00
Jason Zimdars db99e5928c Make collection title h1 for screen reader navigation 2025-07-02 14:38:29 -05:00
Jason Zimdars 985337a91c Esc should not propagate when closing dialogs 2025-07-02 14:29:15 -05:00
Jason Zimdars 91aa8be4fc Screen reader: Use heading for comments navigation 2025-07-02 14:22:16 -05:00
Jason Zimdars f02215c5b7 Add steps to cards 2025-07-01 20:05:20 -05:00
Andy Smith 624dc823c4 Make card column filters interactive 2025-07-01 17:16:09 -05:00
Jason Zimdars ffb422ac61 This attribute is no longer needed 2025-06-30 17:31:07 -05:00
Jason Zimdars 3af949edca Merge branch 'main' into filter-ignore-diacritics
* main:
  Clear the comments cache
  Add context for search screens
  Needs changed for both states
  Use lighter icon and update asset
  Add btn--circle class to user edit form
  Organize button variants
  Untangle `avatar btn` crossover styles
  Remove redundant classes and styles for avatars
  Adjust footer line height
  Tweak padding
2025-06-30 17:01:43 -05:00
Andy Smith c7eeb56cfa Clear the comments cache 2025-06-30 16:47:08 -05:00
Andy Smith be003cd3f7 Remove redundant classes and styles for avatars 2025-06-30 14:00:59 -05:00
Jason Zimdars 2678f8c099 Convert diacritics to approximations before filtering
- Introduces a helper method for setting the filterable value
- Updates `filter_controller.js` to use `data-filter-text-value` attribute populated with converted content. This was previous `data-value` in the earlier implementation but ignored in the current on.
- Also uses the same helper to make @mentions diacritic insensitive
2025-06-30 13:53:50 -05:00
Andy Smith 4b026c443d Merge branch 'main' into collection-nav
* main: (54 commits)
  Remove creation and closure params
  Support viewing user profiles and activity
  Support downcase
  refresh fixtures
  Always downcase names
  Remove vcr_record call
  Support closing soon and falling back soon via natural language
  Add scopes and filters for falling back soon and auto closing soon
  Fix label
  Add chip filters for the new time window filters
  Fix: creator_ids is an array, not a single value
  Add support for filtering by creation or completion windows of times
  Adjust spacing
  Use new logo placeholder
  Update logo assets
  Need to return all collections so it's not blank
  Button to add a new filter
  Update test for new redirect
  Comparing params is fragile, use `id` for saved filters
  Update summary tests
  ...
2025-06-30 12:57:10 -05:00
Andy Smith d455537392 Remove home button 2025-06-30 12:56:56 -05:00
Jason Zimdars fe8e73015c Adjust spacing 2025-06-26 20:14:22 -05:00
Jason Zimdars d81e8b9118 Merge branch 'main' into logo-placeholder-update
* main:
  Need to return all collections so it's not blank
  Button to add a new filter
  Update test for new redirect
  Comparing params is fragile, use `id` for saved filters
  Update summary tests
  Improve summary display in menu
  Add keyboard navigation and filtering to quick filters
  Copy
  Keep stage when clearing
  Keep the current filter params after deleting a saved filter so you can change your mind
  Update test because we now drop all filters on destroy
  New UI for exposing filter options and saving/deleting them
  Unnecessary
  These aren't actually in the events namespace, use utility class
2025-06-26 20:08:54 -05:00
Jason Zimdars 3129b6e205 Use new logo placeholder 2025-06-26 20:08:48 -05:00
Andy Smith a27331409e Consolidate Add card buttons 2025-06-26 15:32:33 -05:00
Andy Smith 8308151500 Use header component everywhere 2025-06-26 14:54:27 -05:00
Andy Smith efdf82244c Add header component 2025-06-26 14:35:59 -05:00
Jason Zimdars 8229ba194b Merge branch 'main' into custom-views
* main:
  Add help entry
  Format
  Add command to create new cards
  Support visiting certain pages
  More prompt tweaks
  Lots of prompts improvements and tightening
  Only intercept when string is composed of numbers
  Set temperature to 0
2025-06-26 10:55:24 -05:00
Jorge Manrubia c760393ed3 Add command to create new cards 2025-06-26 17:14:47 +02:00
Jason Zimdars c5e384cc68 These aren't actually in the events namespace, use utility class 2025-06-25 14:38:23 -05:00
Jason Zimdars c240259631 Order by recently visited in the Fizzy menu 2025-06-24 22:55:14 -05:00
Andy Smith c087ceee52 Properly close the span 2025-06-24 15:29:41 -05:00
Jorge Manrubia f5688175fa Merge pull request #629 from basecamp/prompts-init
Prompts for mentions and links
2025-06-20 14:34:50 +02:00
Jorge Manrubia 9ddb18792b Only offer users accessible in the collection 2025-06-20 10:44:42 +02:00
Jason Zimdars c2b92fd4f5 DRY this up 2025-06-19 20:42:11 -05:00
Jason Zimdars 8b9ee506a5 DRY up, tweak look 2025-06-19 20:24:02 -05:00
Jason Zimdars c59a99fa68 Only display workflows when the card is in Doing 2025-06-19 13:35:20 -05:00
Jorge Manrubia 2dbb53da1f Add prompts to the rest of rich text editors 2025-06-19 13:34:44 +02:00