Commit Graph

822 Commits

Author SHA1 Message Date
Jorge Manrubia 693c0c0fb2 Redirect to root to avoid changing the path by default 2025-11-05 19:00:50 +01:00
Jorge Manrubia 2af7a9f402 Merge pull request #1498 from basecamp/rename-boards
Rename collections => boards
2025-11-05 18:50:49 +01:00
Jorge Manrubia 3b34703db3 Make sure that only admins or card creators can delete cards 2025-11-05 16:37:43 +01:00
Jorge Manrubia de8e861712 Make sure only admins or collection creators can toggle the individual access settings 2025-11-05 16:04:25 +01:00
Jorge Manrubia 193cc26a98 Make sure only admins or collection creators can toggle the all access setting 2025-11-05 15:51:19 +01:00
Jorge Manrubia b2e2a5d959 Invalidate HTTP cache 2025-11-05 13:49:26 +01:00
Jorge Manrubia 39ec6cf062 Replace collection with board in the code, tests green 2025-11-05 13:41:12 +01:00
Jorge Manrubia 03a345609e Baseline replacing collection with board across code 2025-11-05 13:31:54 +01:00
Stanko K.R. cfdd7ab1cb Prohibit duplicate memberships 2025-11-05 11:57:40 +01:00
Jorge Manrubia 10d14b5774 Don't choke when no collections 2025-11-05 08:31:42 +01:00
Mike Dalessio 739d77e0c6 Only include active users in Lexxy prompts
Specifically, exclude users that are inactive or with role "system".

ref: https://app.fizzy.do/5986089/cards/2760
ref: https://app.fizzy.do/5986089/cards/2789
2025-11-04 18:48:59 -05:00
Stanko K.R. 875515b51d Skip the menu screen if there is just one account 2025-11-04 17:52:31 +01:00
Jorge Manrubia 2bb90eab13 Use the sole collection as the root for a better onboarding experience for new accounts 2025-11-04 17:09:35 +01:00
Stanko K.R. 87d9c3cd01 Make unauthenticated access permit unauthorized access 2025-11-04 09:02:36 +01:00
Stanko K.R. 5f26690aa1 Redirect to the account you joined after sign in 2025-11-04 07:20:16 +01:00
Jorge Manrubia 8aead31200 Fix: mark all as read wasn't refreshing in the notifications screen 2025-11-04 06:12:30 +01:00
David Heinemeier Hansson f3c602da21 Use etag for collections/edit 2025-11-03 17:28:16 +01:00
David Heinemeier Hansson 56e4cdabd6 Use etag for taggings/new 2025-11-03 17:24:59 +01:00
David Heinemeier Hansson 887559d1a3 Be consistent about using turbo stream templates 2025-11-03 17:23:37 +01:00
David Heinemeier Hansson 6570f5fc04 Use etag for assignments/new 2025-11-03 17:22:38 +01:00
David Heinemeier Hansson d3cb3a3a2d Use etags for my pins 2025-11-03 17:17:45 +01:00
David Heinemeier Hansson 1d00a53400 Provide etag for pins too 2025-11-03 16:53:49 +01:00
David Heinemeier Hansson 418548b9ba More efficient query for watched_by? and use etag for the status 2025-11-03 16:51:21 +01:00
David Heinemeier Hansson f5977522cb Use shared callback to set card 2025-11-03 16:51:21 +01:00
Jorge Manrubia f2d702fb54 Merge pull request #1457 from basecamp/assignee-update
A couple of fixes for updating cards:
2025-11-03 16:12:38 +01:00
Jorge Manrubia 24da4066b7 Refresh the full meta area so that the assignee name gets updated too 2025-11-03 16:11:53 +01:00
Jorge Manrubia 00818697ef Use page refreshes with morphing to avoid flickering
Replacing the card container will reload the frame. Also, see
https://github.com/basecamp/fizzy/commit/5b70320a6b64adf2d1e0be4bd7dc221a5ba80c95
2025-11-03 16:11:53 +01:00
David Heinemeier Hansson fcad4518da Split callbacks for easier overwriting 2025-11-03 16:00:35 +01:00
David Heinemeier Hansson 6678d0e4fc No longer used 2025-11-03 15:58:36 +01:00
David Heinemeier Hansson 65d04f681a DRY up the public controllers by introducing a shared base class 2025-11-03 15:56:25 +01:00
David Heinemeier Hansson 393e5fd3d4 Don't want to ship with this wart
cc @monorkin
2025-11-03 15:30:44 +01:00
David Heinemeier Hansson 42ebdf9ac1 More natural conditional 2025-11-03 15:29:20 +01:00
David Heinemeier Hansson 9913853cc6 Remove anemic concern 2025-11-03 15:27:12 +01:00
David Heinemeier Hansson 3116cea6a1 Stick with turbo stream templates for everything 2025-11-03 15:18:04 +01:00
David Heinemeier Hansson 3ed5c53b31 Use existing CollectionScoped
It enforces access restrictions on collections too
2025-11-03 15:12:38 +01:00
David Heinemeier Hansson 8d28c25a7b Unnecessary 2025-11-03 15:06:41 +01:00
David Heinemeier Hansson ed9259fa1a Ivar not used 2025-11-03 15:04:03 +01:00
David Heinemeier Hansson 995dcfe8e6 Simplify setup and pull query-prevention into model 2025-11-03 15:00:15 +01:00
David Heinemeier Hansson 2bf95f5b9a Just stick to default 2025-11-03 14:49:01 +01:00
David Heinemeier Hansson f9ff13cdc4 Add http caching for user events 2025-11-03 14:25:32 +01:00
David Heinemeier Hansson b05e7c04e1 Ensure you can only delete your own avatar or else you have to be admin 2025-11-03 14:21:48 +01:00
David Heinemeier Hansson 4c2f3ef0b8 Style 2025-11-03 14:21:25 +01:00
David Heinemeier Hansson 3ec9308345 Always bang for exceptions 2025-11-03 14:21:06 +01:00
David Heinemeier Hansson aeb23b691c Always use templates for turbo streaming to stay consistentn 2025-11-03 13:46:34 +01:00
David Heinemeier Hansson 0a9e1620a0 No longer needed 2025-11-03 13:46:22 +01:00
Jorge Manrubia da6d1011fd Replace card replacement with stream actions to prevent flickering when managing steps 2025-11-03 10:59:24 +01:00
Jorge Manrubia 9d4dd3b00e Remove "save as draft"
Removes the creating status completely as well as the abandoned cards system. It will
always resume drafts if they exist, for a given collection and user.

https://app.box-car.com/5986089/cards/2489
2025-11-03 09:32:29 +01:00
Jorge Manrubia ebe1617f42 Format 2025-11-03 09:29:43 +01:00
David Heinemeier Hansson 9caf39ad2c Use modern strong params syntax 2025-11-02 20:26:12 +01:00
David Heinemeier Hansson 39dc2b6ab9 Prefer explicit turbo stream templates 2025-11-02 20:22:15 +01:00