f166b30f2f
Fix: dismiss mention notifications in cards and comments when reading a card
2025-04-24 12:19:20 +02:00
b08326ccbe
Merge branch 'main' into plain-text-mentions
...
* main: (48 commits)
Improve layout and truncation
This is annoying
Fix summary
Remove index columns
Same treatment for the events index
New menu filters and navigates
Don't test for _Added by_ events
Indention
@collection is always available when card scoped
Style
Remove check for _Added by..._ line
The placeholder attribute is on the `house-md` element
Duh, no before destroy commit, but this is still not right!
No long transactions!
Don't display published event in threads
But feels more essentially part of the User, so list first
Not related to the other two
Missing controller
Style
Errant `bubbles` => `cards` replacement
...
# Conflicts:
# app/models/card.rb
# app/models/user.rb
# db/schema.rb
# db/schema_cache.yml
2025-04-23 17:24:01 +02:00
3d28203224
Use singular staging resource and beef up testing
2025-04-22 14:44:55 +02:00
2d5901fe1e
Fix pin turbo stream response rendering
2025-04-22 11:48:19 +02:00
aa3acfeaa8
Add plain text mentions
2025-04-22 11:26:56 +02:00
f3000a02c5
Follow render_card_replacement pattern
...
And clean up the rest of the implementation a tad.
2025-04-18 15:20:38 +02:00
7395d4e034
Removing the image can also just be done as a card replacement
2025-04-18 15:14:36 +02:00
ac9cbad4f9
I like this even better
2025-04-17 15:32:09 +02:00
62088b66d1
Suffix qualifier is unnnecessary
2025-04-17 15:30:55 +02:00
4dbd8205ce
Fix trailing space
2025-04-17 15:21:14 +02:00
7adbd8d634
Use card rerendering instead of redirects
2025-04-17 15:20:27 +02:00
547e5ea24f
Rerender instead of redirect
2025-04-17 14:54:29 +02:00
4d0dddec46
No need to loop through a job when this is the sole point of the action
2025-04-17 14:31:28 +02:00
87ce4a623b
Even clearer about where these pins are going
2025-04-17 14:31:02 +02:00
1437bcb3b7
Clearer about where these are being sent
2025-04-17 14:29:12 +02:00
fc0cf3917f
Pin without redirect
...
Use turbo stream response to save on the redirect latency
2025-04-17 14:05:26 +02:00
07e801b74c
Fix pinning to tray
...
They need to have a complete dom element that is unique
2025-04-17 13:52:55 +02:00
a5de4863fa
Allow for multiple notifications to be read
...
cc @kevinmcconnell
2025-04-17 11:39:37 +02:00
6c8fe164b3
Read a card should dismiss all notifications
...
Previous code assumed that there was a single notification to dismiss
for that card, but in practice there can be zero or many. If it's zero,
we need to avoid the crash. If it's many, we should dismiss them all.
Also re-rendering the notification stack after dismissing enables us to
remove all the removed cards, as well as reveal any older ones that were
previously outside the visible page size.
This reverts commit 6135909b7e
2025-04-17 09:40:59 +01:00
6135909b7e
Card readings just need to remove the notification
...
No need to broadcast everything again
2025-04-16 16:51:18 +02:00
d00a0433e9
Inline anemic method
2025-04-16 15:34:28 +02:00
a88264ed0a
Merge branch 'main' into consolidate-cards
...
* main: (94 commits)
Source order seems to be significant
Use `card.title`
Nicer flow
Fix string interpolation
Fix constant
Use record lookup
Always use sole
Explained less and extracted nothing of value
Weird double negative
Remove anemic and indirect method that explained nothing
Can use record lookup for workflows
Access control has already been done through the card
Style
Use _path in all cases where we are not potentially changing the domain
Clearer
Spacing
Get rid of card_title
Join the two users controllers but split out role setting
Ensure user is returned
We are not using the parameter
...
2025-04-14 09:40:22 -05:00
cfb345bc32
Nicer flow
2025-04-13 20:39:09 +02:00
e8a730c239
Fix constant
2025-04-13 20:36:07 +02:00
7b60748796
Clearer
2025-04-13 08:11:25 +02:00
4ef46ccd19
Spacing
2025-04-13 08:10:47 +02:00
6bbf68a4f9
The tenanted db is the account scope
2025-04-12 20:06:34 +02:00
760cbb6c99
Drop boosts
...
Killed by design.
2025-04-12 18:52:54 +02:00
e8a839d5f6
We have a callback dependency to do this actually
2025-04-12 11:47:08 +02:00
63c05220ce
Clearer naming
2025-04-12 11:09:55 +02:00
27d90abbd6
Reduce the direct knowledge of comments inside the card
2025-04-12 11:04:16 +02:00
24b02c42fd
Comments are dependents of messages, so need to destroy the latter to get the former
2025-04-12 10:59:59 +02:00
47974b5e3b
Fix failing pin test
2025-04-11 16:14:56 -05:00
aefae634c3
Anemic params method
...
Wont ever get reused here since there is no update
2025-04-11 18:21:44 +02:00
8d36f13fab
No longer needing that extra local
2025-04-11 18:20:28 +02:00
06a636bd8d
Did need to separate them out for the broadcast
2025-04-11 18:19:33 +02:00
5fa8007397
Loaded directly in the partial
2025-04-11 18:19:10 +02:00
7861b7c087
Just open one turbo stream per card
...
Per comment is excessive and needless
2025-04-11 17:58:11 +02:00
79700162fc
Use correct stream name
...
comment, :comments makes no sense for a stream for the reactions
2025-04-11 17:47:35 +02:00
eec76d0d4f
Use modern params#expect
2025-04-11 17:43:31 +02:00
f9bb779b61
Use local vars so ivar dependency is only from before actions
2025-04-11 17:42:30 +02:00
3ecf150636
Use proper access control
...
Otherwise you could react to any comment on the entire account. And then
you might as well just do Comment.find.
2025-04-11 17:41:28 +02:00
5084bbf3b7
Use modern params#expect syntax
2025-04-11 17:01:19 +02:00
8a4a087a00
Fine to let destroying something destroyed be a no-op
...
Would be an edge-casey race condition, but its possible
2025-04-11 17:00:08 +02:00
256d536009
Always use _path unless we are changing domains
2025-04-11 16:58:56 +02:00
16c1583133
Usually the order comes last
2025-04-11 16:58:47 +02:00
5ecf0ce3f6
Stick with one term
2025-04-11 16:57:03 +02:00
a8aa2c4f80
Clean up the controller
2025-04-11 16:49:55 +02:00
f4ce57e308
Move comments under cards
2025-04-11 16:21:44 +02:00
4f3f322528
Rename inconsistency: go with goldness
2025-04-11 10:22:18 +02:00
Jorge Manrubia