Commit Graph

54 Commits

Author SHA1 Message Date
Jorge Manrubia b08326ccbe Merge branch 'main' into plain-text-mentions
* main: (48 commits)
  Improve layout and truncation
  This is annoying
  Fix summary
  Remove index columns
  Same treatment for the events index
  New menu filters and navigates
  Don't test for _Added by_ events
  Indention
  @collection is always available when card scoped
  Style
  Remove check for _Added by..._ line
  The placeholder attribute is on the `house-md` element
  Duh, no before destroy commit, but this is still not right!
  No long transactions!
  Don't display published event in threads
  But feels more essentially part of the User, so list first
  Not related to the other two
  Missing controller
  Style
  Errant `bubbles` => `cards` replacement
  ...

# Conflicts:
#	app/models/card.rb
#	app/models/user.rb
#	db/schema.rb
#	db/schema_cache.yml
2025-04-23 17:24:01 +02:00
Jorge Manrubia f258b05b23 Delegate target to the notifiable objects 2025-04-23 16:19:50 +02:00
Jorge Manrubia 970a51db28 No need for it! 2025-04-23 15:49:22 +02:00
Jorge Manrubia 6f98f2f573 Order methods 2025-04-23 15:32:22 +02:00
Jorge Manrubia e8e95bd511 Use it 2025-04-23 15:27:25 +02:00
Jorge Manrubia 4bef466df2 1-line 2025-04-23 15:22:41 +02:00
Jorge Manrubia 469fb9f049 Simplify the logic to determine action text changes 2025-04-23 15:02:31 +02:00
Jorge Manrubia 696732a90a Rename mentions' container => source 2025-04-23 13:41:34 +02:00
Jorge Manrubia 043230394e Tidy up event helper code
Also, revert to using a helper method to determine the event action, since this is purely a view concern. Keep method at the event model to identify initial assignments.
2025-04-23 13:35:09 +02:00
Jorge Manrubia 755c9b45c7 Rename and fix problem where after_touch was overriding the saved content 2025-04-23 12:38:33 +02:00
Jorge Manrubia 8ebb3f2fa9 We need to remember on after_touch so that the mechanism triggers when touch-cascading records automatically via associations 2025-04-23 11:38:34 +02:00
Jorge Manrubia 8b6cfccded Rename to clarify usage 2025-04-23 11:20:33 +02:00
Jorge Manrubia b510ca0318 Don't choke for nil values 2025-04-23 10:56:00 +02:00
Jorge Manrubia af8701567a Extract method 2025-04-23 10:35:18 +02:00
Jorge Manrubia c3cd873588 Rename collect => create 2025-04-23 10:30:30 +02:00
David Heinemeier Hansson 5048e9c970 Duh, no before destroy commit, but this is still not right! 2025-04-22 21:40:30 +02:00
David Heinemeier Hansson 134333ae44 Dont do a lot of work inside a single transaction
Especially with sqlite3!
2025-04-22 21:01:11 +02:00
David Heinemeier Hansson 78d186bebd Really liking the new it-style yields in many places 2025-04-22 20:59:49 +02:00
Jorge Manrubia cdadc0373a Don't trigger unless the mentionable content changes
This is also needed to prevent incorrect triggering on cascade touches!
2025-04-22 18:10:27 +02:00
Jorge Manrubia a567e662e2 Fix: wrong delegation 2025-04-22 17:23:47 +02:00
Jorge Manrubia 9b4fec936e Move mentions to comments
- It does not make sense to scan "event summaries" for notifications.
- Placing them at the message level prevents us from using the generic approach to extract the mentionable content
2025-04-22 16:17:37 +02:00
Jorge Manrubia beac61699c Not needed 2025-04-22 14:21:26 +02:00
Jorge Manrubia d5f0359338 Extract mentionable content using reflection to remove duplicated logic and the need for additional concerns 2025-04-22 14:19:45 +02:00
Jorge Manrubia aa3acfeaa8 Add plain text mentions 2025-04-22 11:26:56 +02:00
Jorge Manrubia 695247ae9b Paginate collection cards 2025-04-10 15:09:56 +02:00
Jason Zimdars c55501a6c8 Remove unused display count feature 2025-04-09 14:54:53 -05:00
Jorge Manrubia 723e6d94f5 Rename bubbles => cards 2025-04-09 14:50:58 +02:00
Kevin McConnell 0820badcc3 Add involvement types to accesses
This provides a way to set the level of involvement that a user has with
a collection, and from which we determine the level of notifications to
send. Users can be access-only, watching, or being notified about
everything.

If you're access-only, you won't get an notifications. If you're
watching, you'll only get notifications for the items you're watching
(which includes the items you've been assigned, have commented on, etc).
If you're set to everything you'll get notifications about all activity
in that collection.

This change replaces our previous concept of subscriptions. Where
previously you'd subscribe to a collection to get notifications in it,
now you'll simply set the notification level on your access.
2025-04-03 16:35:13 +01:00
Jason Zimdars 28a569c49b Tickets 2025-03-17 21:24:08 -05:00
Kevin McConnell a802b8de5a Allow managing bucket subscriptions 2025-02-26 10:53:03 +00:00
Kevin McConnell f22742c431 watched_by? should reflect subscriptions too 2025-02-26 10:53:03 +00:00
Kevin McConnell d29e999552 Make Buckets subscribable 2025-02-26 10:53:03 +00:00
Kevin McConnell 8a51597408 Add direct linking to comments 2025-01-13 14:21:47 +00:00
Kevin McConnell 22be073a92 Sanitize search terms 2025-01-08 16:49:40 +00:00
Jose Farias fdea6d4248 Merge branch 'main' into house
* main:
  Update test
  Wire up comment deletion
  Whitespace
  Wire up editing comments
  Open the title field for editing after creating a new bubble
2024-12-17 00:34:00 -06:00
Jason Zimdars 33d2d098f1 Wire up comment deletion 2024-12-16 17:46:01 -06:00
Jose Farias 45e94e4484 Support search on markdown fields 2024-11-29 14:28:37 -06:00
Jose Farias 12ce07639d Add tests 2024-11-06 17:49:14 -06:00
Jose Farias 3d9d169477 Many-to-many relationship for filters and filterables 2024-11-05 21:21:46 -06:00
Jose Farias f9712ea53f Messageables don't belong to bubble directly 2024-10-27 11:57:33 -06:00
Jose Farias 46c2b450da has_one allows for touch: true 2024-10-25 15:25:57 -06:00
Jose Farias 85d47a35ab threadables -> messageables 2024-10-25 15:03:31 -06:00
Jose Farias 652ec68e9c Threadables should thread entry 2024-10-24 17:48:32 -06:00
Jose Farias c57f18c20c Materialize abstract thread
The domain language is clearer if we just persist a thread. Also rename some models so their purpose is clear.
2024-10-24 17:36:14 -06:00
Jose Farias 28a024b1da Pull out Threadable::TYPES 2024-10-24 11:36:24 -06:00
Jose Farias 042bc2c10e Use Proc for Threadable after_create 2024-10-24 11:31:06 -06:00
Jose Farias e3db8e8700 Inline thread entry creation 2024-10-24 11:25:50 -06:00
Jose Farias 804be0a971 Create thread entry in a callback 2024-10-24 10:38:59 -06:00
Jose Farias 567dec2197 Simplify threadable<>bubble relationships 2024-10-23 17:29:24 -06:00
Jose Farias ae497aae85 Clear up dependency destruction chain
Buckets destroy their bubbles, which destroy their thread entries, which destroy their threadables, which is how comments end up destroyed, and then rollups end up deleting their events
2024-10-23 14:51:12 -06:00