Commit Graph

1289 Commits

Author SHA1 Message Date
Jorge Manrubia cb1ee9eabd Format 2025-06-05 08:54:42 +02:00
Jorge Manrubia b9dd7fe808 Tidy up code 2025-06-05 08:54:31 +02:00
Jason Zimdars 6eece93f10 Merge branch 'knobs' into entropy-settings-ui
* knobs:
  Add comment
  Properly parameterize the field name
  Remove leftover console.log
  Correct the reserved area math
  Better a11y
  Connect the range slider
  Basic radio input working
  Expose button so you can delete drafts
  Save button should match card color
  `x` interferes with string entry, try `SHIFT+ENTER` to toggle checkboxes
  Remove unnecessary param and update condition
2025-06-04 20:34:04 -05:00
Jason Zimdars e42c6548b0 Wire up knob UI design 2025-06-04 20:28:20 -05:00
Jason Zimdars 10224c2698 Extract the header so we can explain in context 2025-06-04 15:30:19 -05:00
Jason Zimdars 638bc16b4b Display users and invite on account/settings 2025-06-04 15:16:24 -05:00
Jason Zimdars cc03a3dcb4 Link to workflows 2025-06-04 14:58:09 -05:00
Jason Zimdars 24f4589c02 Link to account settings 2025-06-04 14:57:09 -05:00
Jason Zimdars 9872f35c2a Update to use two-column layout, add title and nav 2025-06-04 14:56:30 -05:00
Andy Smith b4e283ab6a Properly parameterize the field name 2025-06-04 13:49:18 -05:00
Andy Smith 04551d859e Better a11y 2025-06-04 13:06:43 -05:00
Andy Smith 80b1ac8cc9 Connect the range slider 2025-06-04 12:49:32 -05:00
Andy Smith 68ac1f80ec Basic radio input working 2025-06-04 12:10:28 -05:00
Jorge Manrubia 5dc33c304c Restore reminder period I replaced by mistake 2025-06-04 17:17:47 +02:00
Jorge Manrubia a6ffbf7ec6 Rename method 2025-06-04 14:56:19 +02:00
Jorge Manrubia db86d17880 Refactor to introduce an entropy model
Instead of keeping two tracks of similar logic (auto-reconsider / auto-close).
2025-06-04 14:40:02 +02:00
Jorge Manrubia e8249d2405 Consider the new default settings for previews 2025-06-04 13:13:45 +02:00
Jorge Manrubia 3c61fc3cdf Add screen to edit account settings to tweak default entropy configuration 2025-06-04 11:25:10 +02:00
Jorge Manrubia 91787a3523 Revamp entropy configuraiton
- Move both settings to its dedicated model entropy configuration
- A collection can have an entropy configuration, or will default to the account if not
2025-06-04 10:41:08 +02:00
Jason Zimdars 7355b09382 Expose button so you can delete drafts 2025-06-03 17:48:08 -05:00
Jason Zimdars 029daece9b Save button should match card color 2025-06-03 16:46:09 -05:00
Jason Zimdars 37dc14c0c6 x interferes with string entry, try SHIFT+ENTER to toggle checkboxes 2025-06-03 16:35:55 -05:00
Jason Zimdars 56b32e6f52 No explicit stalled setting for now
Stalled will be determined by the system
2025-06-03 15:57:11 -05:00
Jason Zimdars 678fb66f17 Stub UI for independent settings for Considering and Doing 2025-06-03 15:51:37 -05:00
Jason Zimdars ff403021cc Wire-up keyboard navigation
- Introduces a distinct controller and individual forms for each option so they behave like other pop-ups
- Adds `filter` and `navigable-list` behaviors
2025-06-03 11:05:39 -05:00
Jason Zimdars acfc7da551 Merge pull request #548 from basecamp/change-collection
Change collection
2025-06-03 08:56:00 -05:00
Jason Zimdars 98c1f32e1c Spell it all out for now 2025-06-03 08:54:37 -05:00
Jason Zimdars 6045b7a736 Correct hotkey 2025-06-03 08:49:03 -05:00
Jorge Manrubia 199a78ee08 Merge branch 'main' into filter-revamp
* main:
  `event.assignees` collection doesn't include `event.creator` when self-assigning
  Consistent verb forms
  Autolinking shouldn't include final punctuation.
  dep: update kamal to edge
  No need to delegate auto_closing? anymore
  Extract common method to query when entropy is cleaned
  Invalidate card caches when editing workflows

# Conflicts:
#	app/javascript/controllers/navigable_list_controller.js
2025-06-03 06:12:34 +02:00
Jason Zimdars 2c75c9e746 Let's try it without the explicit submit
Later on we could consider adding an explicit button that only shows up when the filter has no matches and there is something typed in the filter input
2025-06-02 16:37:58 -05:00
Jason Zimdars f796b62aa8 Update markup to match assignments list
Drifted due to neglect (I guess)
2025-06-02 16:28:47 -05:00
Jason Zimdars de8fce5eee Prefer ul for a11y 2025-06-02 16:12:34 -05:00
Jason Zimdars 63808ff567 Just say "Filter…", since it can match other things 2025-06-02 16:09:18 -05:00
Jason Zimdars 84b52f8fae Ensure these can be matched by the filter, too 2025-06-02 15:56:46 -05:00
Jason Zimdars dc5c8d17a4 Handle these special case options a different way 2025-06-02 15:49:44 -05:00
Jorge Manrubia 61fbad218b Make tag filters selectable/navigable too 2025-06-02 18:39:44 +02:00
Jorge Manrubia c0cd5e1967 Merge pull request #566 from basecamp/fix-caching
Invalidate card caches when editing workflows
2025-06-02 18:09:52 +02:00
Jorge Manrubia 08c5abfbdb Extract common method to query when entropy is cleaned
We were always quering auto_close_at
https://37s.fizzy.37signals.com/collections/2/cards/743
2025-06-02 18:04:14 +02:00
Jorge Manrubia 5c31ef1aa6 Make dialog close on ESC 2025-06-02 17:17:13 +02:00
Jason Zimdars 3ab0cb7422 Down arrow glyph 2025-06-02 10:02:27 -05:00
Jason Zimdars 902a99ca56 Merge branch 'main' into change-collection
* main: (25 commits)
  Add controller to retarget links
  Use more complete regexp
  dep: bundle update
  refactor: Extract a Card::Entropy concern
  Autolink emails and URLs at rendering time
  Remove the "mirror" storage service
  Update production storage to write to the Pure blob store
  Clean up the purestorage config, and add explanatory comments.
  Drop the action_text_markdowns table
  Mount mission control under `/admin/jobs`
  dep: add mission_control-jobs
  Flip the storage mirror to write to Pure as the primary
  Production mirrors Active Storage to `:purestorage`
  Make sure Sentry is configured for the beta env.
  Update lexical
  update lexical
  update lexical
  Create a distinct "beta" environment
  Revert "Patch for cards missing description"
  Add a kamal "ssh" alias
  ...
2025-06-02 09:34:01 -05:00
Jorge Manrubia b10ab3063b Add class I lost by mistake 2025-06-02 15:32:39 +02:00
Jorge Manrubia ca40e36a79 Make dialog to assign users searchable and navigable 2025-06-02 15:30:55 +02:00
Jorge Manrubia 10ee5611c9 Make collection's filter searchable too 2025-06-02 15:22:34 +02:00
Jorge Manrubia 29c1f3133d Remove unused classes from controller 2025-06-02 15:08:34 +02:00
Jorge Manrubia 37fd2b248d Revamp filters menu (WIP)
- Make them navigable by keyboard (UP, DOWN, ENTER to activate option).
- Filter based on the actual text in the element, use containment condition instead of CSS selector on value prefix.
- Make all the elements in the filter searchable and reachable by keyboard.
2025-06-02 14:51:03 +02:00
Jorge Manrubia 51dcf8b25f Invalidate card caches when editing workflows
https://37s.fizzy.37signals.com/collections/2/cards/607
2025-06-02 13:08:54 +02:00
Jorge Manrubia db9ee1b3b2 Merge pull request #564 from basecamp/auto-link-render
Autolink emails and URLs at rendering time
2025-06-02 12:12:39 +02:00
Jorge Manrubia d7c06702e3 Add controller to retarget links
So that internal links can skip turbo frames, and external links
open in new pages
2025-06-02 12:04:43 +02:00
Mike Dalessio 28ed744d0c refactor: Extract a Card::Entropy concern
to encompass behavior related to auto-closing and auto-reconsidering.

Note that putting this code in a single place reveals an asymmetry
between the actions:

- Auto-closing period is an optional attribute of a collection
- Auto-reconsidering period is hard-coded to 30 days for all collections
2025-06-01 16:50:12 -04:00