d019e282ae
Better name
2025-04-17 15:00:14 +02:00
770029c26d
Stick with domain language
2025-04-17 14:59:15 +02:00
547e5ea24f
Rerender instead of redirect
2025-04-17 14:54:29 +02:00
ab1835294d
Style
2025-04-17 14:53:45 +02:00
f24287915f
Extract partials that can be rerendered
2025-04-17 14:52:35 +02:00
4d0dddec46
No need to loop through a job when this is the sole point of the action
2025-04-17 14:31:28 +02:00
87ce4a623b
Even clearer about where these pins are going
2025-04-17 14:31:02 +02:00
1437bcb3b7
Clearer about where these are being sent
2025-04-17 14:29:12 +02:00
8fe8241069
Reuse create template
2025-04-17 14:14:08 +02:00
bddd624e41
Match template name to container id
2025-04-17 14:14:03 +02:00
fc0cf3917f
Pin without redirect
...
Use turbo stream response to save on the redirect latency
2025-04-17 14:05:26 +02:00
07e801b74c
Fix pinning to tray
...
They need to have a complete dom element that is unique
2025-04-17 13:52:55 +02:00
0c743d27a8
There is no more/less flicker with morphing
...
Where did you see the flickering that this solved, @jorgemanrubia?
2025-04-17 13:42:49 +02:00
b5d6d40462
Use domain language termn
2025-04-17 13:42:23 +02:00
bf99da8914
Style
2025-04-17 13:33:45 +02:00
a5de4863fa
Allow for multiple notifications to be read
...
cc @kevinmcconnell
2025-04-17 11:39:37 +02:00
6c8fe164b3
Read a card should dismiss all notifications
...
Previous code assumed that there was a single notification to dismiss
for that card, but in practice there can be zero or many. If it's zero,
we need to avoid the crash. If it's many, we should dismiss them all.
Also re-rendering the notification stack after dismissing enables us to
remove all the removed cards, as well as reveal any older ones that were
previously outside the visible page size.
This reverts commit 6135909b7e
2025-04-17 09:40:59 +01:00
94ccbdb601
Fix close card notch state
2025-04-16 19:06:18 -05:00
b5090c4b21
Copy edit
2025-04-16 10:39:24 -05:00
00dd312cd6
Change alignment
2025-04-16 10:39:24 -05:00
beae3d9a6b
Clearer assignment icon
2025-04-16 10:39:24 -05:00
5c4c06d74c
No longer used
2025-04-16 10:39:24 -05:00
7c5a58bf4d
Note that this need to be able to dynamically appear
2025-04-16 17:12:31 +02:00
5dc6e0394f
Style
2025-04-16 17:12:20 +02:00
00cbe8101c
Slim it down
2025-04-16 17:07:43 +02:00
cfa2f2d1f9
Trailing spaces
2025-04-16 17:02:48 +02:00
2ced8e643d
Clarify a bit
2025-04-16 17:01:32 +02:00
d8ec2c3364
More natural to fetch that which will be shown first
2025-04-16 16:58:03 +02:00
5ce289642f
Rely on caching of notifications
2025-04-16 16:57:54 +02:00
6135909b7e
Card readings just need to remove the notification
...
No need to broadcast everything again
2025-04-16 16:51:18 +02:00
2757cd8e62
Dont render inline
2025-04-16 16:49:16 +02:00
98401b9536
Explain this
2025-04-16 16:44:04 +02:00
4bb9085737
Hide implementation detail of reading
2025-04-16 16:41:22 +02:00
ac3307ee23
Allow for the footer frames to be hidden on the notifications page
...
Otherwise you will have multiple notification dom elements with the same
id.
2025-04-16 16:23:05 +02:00
158b694d31
Simplify the containers
...
Need to use CSS to hide headings in empty containers
2025-04-16 16:22:36 +02:00
397fc1d2bd
Only broadcast creations
2025-04-16 16:21:54 +02:00
8ff71b2650
Dont turbo stream when coming from a read_all redirect
2025-04-16 16:21:31 +02:00
5932bf9316
This is rare enough that a redirect is fine
2025-04-16 16:21:16 +02:00
f9952e0fd6
Style
2025-04-16 15:57:02 +02:00
d00a0433e9
Inline anemic method
2025-04-16 15:34:28 +02:00
13c44ba650
Actually need it for the lazy load of course
2025-04-16 12:00:54 +02:00
980345d176
Drop the frame, we will do it with streams
2025-04-16 12:00:11 +02:00
3fc34257c4
No longer used
2025-04-16 11:59:58 +02:00
73f272f132
Use one controller for all notification readings
2025-04-15 19:14:50 +02:00
2ea898324f
We can just set the namespace directly in the class name
2025-04-15 16:36:40 +02:00
ac65f39c0d
Inline anemic partial
2025-04-15 16:32:56 +02:00
b9f5293231
Style
2025-04-15 16:15:13 +02:00
f30a9308d2
Line up scopes in order of the flow
2025-04-15 16:13:54 +02:00
8e479dddba
Clearer still
2025-04-15 16:04:11 +02:00
5d22809e29
No public use of this concept, so inline it
2025-04-15 16:03:14 +02:00
David Heinemeier Hansson