Commit Graph

6383 Commits

Author SHA1 Message Date
Andy Smith d31756fed3 Merge pull request #2549 from basecamp/fix-typo
Fix typo
2026-02-16 09:41:03 -06:00
Rosa Gutierrez b742963f7c Add account ownership check to import GID resolution
The convert_gids_to_sgids method resolved GIDs globally and minted
valid SGIDs without verifying the record belongs to the importing
account. This adds the same account_id check that the export path
already has, plus RecordNotFound handling for invalid GIDs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-16 11:49:00 +01:00
Andy Smith 1572e70b65 Fix typo 2026-02-13 17:45:58 -06:00
Andy Smith f2bf7c7460 Merge pull request #2547 from basecamp/import-export-clarification
Import export clarification
2026-02-13 17:40:35 -06:00
Andy Smith d7814792e3 Tweak language 2026-02-13 15:17:33 -06:00
Mike Dalessio dc492ef17e Merge pull request #2540 from basecamp/fix-quotes
Fix double-escaped HTML entities in basecamp and campfire webhook payloads
2026-02-13 09:26:00 -05:00
Samuel Péchèr 0ab88af118 Revert "Add temporary performance degradation message"
This reverts commit 2a1f9cd15b.
2026-02-13 10:05:22 +00:00
Mike Dalessio 0c10622672 Fix double-escaped HTML entities in webhook payloads
`Event::Description#to_plain_text` now returns an html-safe string to
prevent double-escaping when the ERB template renders the basecamp
and campfire payloads.

ref: https://3.basecamp.com/2914079/buckets/27/card_tables/cards/9574495379
2026-02-13 03:25:59 -05:00
Stanko K.R. 05042ed54a Fix crash when a notification is deleted while a bundle is being sent 2026-02-13 09:22:51 +01:00
Stanko K.R. ae3d277868 Fix race condition on notification creation 2026-02-13 09:14:24 +01:00
Andy Smith f77850f5be Update copy 2026-02-12 12:13:05 -06:00
Andy Smith 2a1f9cd15b Add temporary performance degradation message 2026-02-12 12:01:18 -06:00
Mike Dalessio 851f13a934 Render inline code in card titles (#2518)
* Remove unused marked JS dependency

* Remove unused redcarpet dependency

* Render inline code in card titles

Add card_html_title helper that HTML-escapes input then converts
backtick-wrapped text to <code> elements. Apply to card titles in
board preview, card detail, public views, and notification emails.
Style inline code elements in titles to match description styling.

Co-authored-by: Andy Smith <andy@37signals.com>

---------

Co-authored-by: Andy Smith <andy@37signals.com>
2026-02-12 12:07:40 -05:00
Adrien Maston 486da76a26 Merge pull request #2497 from basecamp/mobile/fix-stage-button-gap 2026-02-12 18:03:55 +01:00
Adrien Maston 8f924bd5d4 Merge pull request #2494 from basecamp/mobile/fix-truncated-comment-dates 2026-02-12 18:03:39 +01:00
Adrien Maston 07dfeedb7d Merge pull request #2521 from basecamp/mobile/tweak-card-draft-ui 2026-02-12 18:03:14 +01:00
Zoltan Hosszu 135fe128f7 Table style tweaks 2026-02-12 11:46:04 +01:00
Zoltan Hosszu ff80dfeb06 Fix dark mode colors 2026-02-12 11:37:08 +01:00
Stanko Krtalić 61144667fc Merge pull request #2512 from basecamp/server-side-notification-grouping
Stack notifications in all views
2026-02-12 10:33:12 +01:00
Stanko K.R. 36ee253a1a Stack notifications everywhere
We had client-side notification stacking in the tray since launch, but now we want to stack notifications in the notifications page, in API responses and in email bundles.
2026-02-12 10:29:50 +01:00
Zoltan Hosszu e0f8a182c5 HR fixes 2026-02-12 09:54:21 +01:00
Zoltan Hosszu 343bf016a3 Removing duplicate code language picker 2026-02-12 09:54:21 +01:00
Zoltan Hosszu 9a2e30b9c8 Regression fixes 2026-02-12 09:54:21 +01:00
Andy Smith 322de4217f Touch up link button hover styles 2026-02-12 09:54:21 +01:00
Zoltan Hosszu 0d45a42ebf Remove link dialog size limit 2026-02-12 09:54:21 +01:00
Zoltan Hosszu 374856f641 Fix toolbar dropdown icon background 2026-02-12 09:54:21 +01:00
Zoltan Hosszu a315af1090 Table tweaks 2026-02-12 09:54:21 +01:00
Andy Smith a4303dbe71 Use existing lexxy-content styles instead of rewriting everything 2026-02-12 09:54:21 +01:00
Andy Smith 4e5a5e1523 Use built-in lexxy styles and sprinkle in some overrides 2026-02-12 09:54:20 +01:00
Zoltan Hosszu a586f77a71 Use Lexxy's built in CSS for Lexxy 2026-02-12 09:54:20 +01:00
Andy Smith b786bf24e0 Clarify importing accounts 2026-02-11 16:36:09 -06:00
Stanko K.R. 37d7f5c569 Give more detail about why the import failed 2026-02-11 13:47:21 +01:00
Adrien Maston c992ac1be5 Extend background color 2026-02-10 17:22:31 +01:00
Adrien Maston 5785e2a5c1 Adjust space between title, description and steps 2026-02-10 17:22:20 +01:00
Alp Keser 03ed6df109 Merge pull request #2455 from basecamp/expose-has-attachment-for-card
Add json.has_attachments for the card
2026-02-10 11:36:30 +03:00
Andy Smith b3951564bc Only disable the current column if it's open 2026-02-09 16:02:02 -06:00
Andy Smith e1a70a330d Merge pull request #2513 from basecamp/truncate-account-menu
Truncate long account names in the menu
2026-02-09 10:51:02 -06:00
Mike Dalessio 8c5b47d774 Group notification emails by board (#2506)
* Group notification emails by board

Notification bundle emails now group items by board instead of
showing the board name redundantly for each card. Each board
section has a linked header and an <hr> separator.

* Adjust board title styles and remove rem units

* Sort board groups alphabetically

Sort notification email board sections alphabetically by name
(case-insensitive).

Also, rewrite mailer tests to use Nokogiri::HTML5 for precise DOM
assertions instead of regex matching.

---------

Co-authored-by: Andy Smith <andy@37signals.com>
2026-02-09 11:29:11 -05:00
Andy Smith 4127eaeacf Truncate long account names in the menu 2026-02-09 10:22:58 -06:00
Adrien Maston 2bfd54437c Use a px padding 2026-02-09 09:31:50 +01:00
Adrien Maston aa2f0e7fdc Fix unwanted divider 2026-02-06 17:45:09 +01:00
Adrien Maston 8f95a6f228 Add a little space around stage buttons 2026-02-06 17:32:55 +01:00
Adrien Maston 4f9cfa94b7 Allow comment author block to wrap on 2 lines 2026-02-06 12:30:28 +01:00
Adrien Maston a8676ada4c Merge pull request #2490 from basecamp/fix-hidden-filters-in-firefox
Fix hidden filters in Firefox
2026-02-06 11:01:54 +01:00
Andy Smith 8e93f9d45e Content overflow scrolling for users list 2026-02-05 13:20:01 -06:00
Adrien Maston 9c7afcbee8 Merge pull request #2484 from basecamp/mobile/fix-board-scroll-position
Mobile / Fix expanded column not being scrolled into view
2026-02-05 17:47:38 +01:00
Adrien Maston 4072688974 Use a dedicated link to bridge a "go to" board button 2026-02-05 17:36:48 +01:00
Adrien Maston fe555f751e Move "Edit" action to ellipsis menu 2026-02-05 17:33:29 +01:00
Adrien Maston 626b8aa8a6 Revert "Show "Go to" board button in card perma"
This reverts commit d689f560b4.
2026-02-05 17:31:37 +01:00
Adrien Maston 186d759672 Instant scrolling on restore, animated on user action 2026-02-05 17:17:49 +01:00