I went with placing htis logic at the command level since it plays well with the composite structure, where you don't know whether you are handling one command or many commands, and you want to aggregate all the errors. I didn't leverage the existing support with rails' model errors because that customizing those message is cumbersome (either i18n or using custom validation logic for everything).
- Introduces a helper method for setting the filterable value
- Updates `filter_controller.js` to use `data-filter-text-value` attribute populated with converted content. This was previous `data-value` in the earlier implementation but ignored in the current on.
- Also uses the same helper to make @mentions diacritic insensitive
* main:
The joke is better if 11 is last 🤘🏻
Filter here, too
Keep up with filtering controller changes
dep: update rack to 3.1.16
Try minus
Adjust icon and card header for events
Fix that flash notices invisibly overlapped navbar
Use card header in events
Cap height and scroll list
Fix that flash notices invisibly overlapped navbar
Use card header in events
Fix: update option when changing index
Cap height and scroll list
- Make them navigable by keyboard (UP, DOWN, ENTER to activate option).
- Filter based on the actual text in the element, use containment condition instead of CSS selector on value prefix.
- Make all the elements in the filter searchable and reachable by keyboard.
The problem was that after redirecting back with morphing, the autosave mechanism
would trigger an autosave call with an empty content.
This is a first patch. The editor shouldn't be triggering these "change" events
in the first place when loading the editor.
* main:
Don't choke when rendering commands where the card was deleted
Update tests
Rework system events
test: add missing assertions
dep: bump active_record-tenanted to fix URI support
Remove hyphen from "Un-do"
Prevent default when handling keyboard shortcuts
dep: update AR::Tenanted to support database URIs
Detect platform and label the correct hotkey shortcut
Things got too tight
Don't require TLS for Beamer at the moment
dep: update dependencies
# Conflicts:
# Gemfile
# Gemfile.lock
# app/assets/stylesheets/comments.css
Without this, any default action would still happen. With Chrome on
Linux, that causes browser features to be triggered with our CTRL+J and
CTRL+K actions.
Jason Zimdars