Commit Graph

611 Commits

Author SHA1 Message Date
Jason Zimdars 2f9fb2e20b Bring back a dedicated button for adding tags
Fixes and issue in which you couldn't add a new tag if there were any
matches so you couldn't created a tag named "blue" if there was already
one named "blueberry"
`
2025-10-16 20:02:57 -05:00
Jason Zimdars c3a3f157a2 Merge branch 'main' into remove-closure-reasons 2025-10-16 13:55:13 -05:00
Andy Smith de2a1a4aaf Oh yeah, add an aria label to the step input 2025-10-16 11:34:55 -05:00
Andy Smith 72a1fa075b Merge pull request #1333 from basecamp/steps-cant-be-empty
Check for empty values before submitting
2025-10-16 11:24:03 -05:00
Andy Smith 673e74d0de Check for empty values before submitting 2025-10-16 11:07:44 -05:00
Jorge Manrubia 8c8dbe888e Fix assorted issues when reloading pages with morphing and the pagination system
This patches 2 problems in Turbo/idiomorph that are causing problems when reloading the pagination frames:

- No remove callback in idiomorph when removing a node that had been mapped.
- Regression introduced by https://github.com/hotwired/turbo/pull/1311, where it won't prevent the removal of frames with refresh=morph

I will upstream both patches, this is temporary.

https://fizzy.37signals.com/5986089/cards/2291
2025-10-16 13:39:16 +02:00
Jason Zimdars da413e7540 Remove closure reasons 2025-10-15 16:15:56 -05:00
Jason Zimdars c1bcab96f0 They're all just *done* 2025-10-15 14:10:38 -05:00
Jason Zimdars a6c692affe Just close as done 2025-10-15 14:02:08 -05:00
Andy Smith fad74c1282 Add screen reader labels for card ID 2025-10-15 13:45:51 -05:00
Andy Smith 963f0dab15 Aria labels for preview card meta icons 2025-10-15 13:42:47 -05:00
Jorge Manrubia 4cc8ab829e Don't choke if no user 2025-10-15 15:06:16 +02:00
Jorge Manrubia 9263cff3d5 Store and show the user that postpones cards 2025-10-15 13:44:49 +02:00
Andy Smith 9f3b0755f1 Add stamp to Not Now (doesn't include the name, though) 2025-10-14 16:09:41 -05:00
Jason Zimdars a0520d34fc Merge pull request #1306 from basecamp/fix-postpones-copy
"Postpones" -> "Closes in"
2025-10-14 12:08:32 -05:00
Jason Zimdars 040c8a92c2 "Postpones" -> "Closes in" 2025-10-14 12:05:21 -05:00
Jorge Manrubia 956faaa67d More fine-grained approach to listen for broadcasted refresh signals
Only listen for collections actually involved in the view
2025-10-14 11:10:49 +02:00
Jorge Manrubia 6d434ec467 Reuse existing cache invalidation logic that replaced this helper 2025-10-14 11:02:15 +02:00
Jason Zimdars 940db09063 Refactor to remove workflows styles 2025-10-13 18:06:14 -05:00
Andy Smith 424a7795a9 Hide column list when creating a new card 2025-10-10 16:53:34 -05:00
Andy Smith fe842723b6 Nevermind about the default reason :) 2025-10-10 15:07:17 -05:00
Andy Smith 5ff50fd352 Change default reason from Completed to Done 2025-10-10 15:04:47 -05:00
Andy Smith 81ce61aa9e Match the column name in workflows 2025-10-10 14:56:25 -05:00
Jason Zimdars 3390cd95af Style 2025-10-08 17:11:42 -05:00
Jason Zimdars fcba8b6acb Add column color to cache keys
So cards change colors when you change the column color
2025-10-08 17:08:32 -05:00
Andy Smith 42aa213312 Remove aside and toolbar role from perma actions 2025-10-07 10:48:05 -05:00
Jorge Manrubia 1d1a3da9cf Cleanup workflow/stages
This was pending after moving to columns
2025-10-07 11:10:10 +02:00
Jorge Manrubia 6af27c91d8 Fix: anchor links to comments not working
The problem was having the turbo frames as targets: their display: contents would make
auto-scrolling not working!

https://fizzy.37signals.com/5986089/cards/2190
2025-10-07 10:11:05 +02:00
Andy Smith 7affff16fd Add proper radio functionality to column picker 2025-10-06 14:25:07 -05:00
Jorge Manrubia 38116f64e4 Higher fidelity for watching/unwatching cards 2025-10-06 10:48:31 +02:00
Jason Zimdars d591166f01 Merge pull request #1212 from basecamp/column-perma
Column perma
2025-10-03 16:09:42 -05:00
Jorge Manrubia a6383d0e43 Don't prepend yourself to the list if you are not watching 2025-10-03 19:03:26 +02:00
Jorge Manrubia e610bc981e Handle update with a page refresh so that both the list of subscribers and the bell update on the same operation
We can optimize with streams separately, this fixes a bug
2025-10-03 18:25:04 +02:00
Jorge Manrubia 4527dcbeda Remove unnecessary filtering code
After removing collections from the filtering menu, there was quite a good cleanup here pending
2025-10-03 10:56:34 +02:00
Andy Smith 8db9862eb1 Use hide avatars from tabindex on preview 2025-10-02 15:36:13 -05:00
Jorge Manrubia b986927e25 Add pagination to the list of filtered cards 2025-10-02 15:54:02 +02:00
Jorge Manrubia 0774101b0d Use the new required attribute that now Lexxy supports 2025-10-02 09:34:41 +02:00
Andy Smith 80e072f845 Use controller to disable empty comment submit 2025-10-01 16:56:55 -05:00
Jason Zimdars 1ecbc6d8ac This child of <ol> should be <li> 2025-09-30 18:11:24 -05:00
Jorge Manrubia 0347806ce1 Fix: Keep the previous filtering when navigating back from cards
https://fizzy.37signals.com/5986089/cards/1760/edit

This also adds a proper resource for filtered collections, instead of changing the URL to cards for filtering cards.
2025-09-30 15:48:56 +02:00
Andy Smith 58c0314c17 Merge branch 'main' into tooltip-orient
* main: (161 commits)
  Save expanded state to localStorage
  Update seeds to use the workflow stages
  Disable autocomplete when editing columns
  Reset column form and disable autocomplete
  Remove unused job
  Fix Stream workflow stage BG
  We need the grid layout when filtering events
  Fix: proper filtering by collection in the collection perma
  Fix test
  Fix test
  Position expander menu
  Use parent layout when using with_manual_pagination
  Reinstate gap to cards list
  Fix: include collection filter in the collection perma
  Add some basic caching for the new columns approach
  Format
  Fix tests
  No need to use extra method here
  Move actions to stream templates
  Prevent recursive loop now that we have nested frames
  ...
2025-09-29 13:55:33 -05:00
Andy Smith 5f0a6943ee Merge pull request #1183 from basecamp/filter-grid
We need the grid layout when filtering events
2025-09-29 13:09:52 -05:00
Andy Smith bd7ac0d510 Fix Stream workflow stage BG 2025-09-29 11:50:41 -05:00
Jorge Manrubia 17ec7a367a We need the grid layout when filtering events 2025-09-29 18:50:22 +02:00
Jorge Manrubia 4103e0c346 Adapt public collections/cards to the new columns model 2025-09-28 18:33:06 +02:00
Jorge Manrubia c4a23102e9 Remove unused code 2025-09-28 11:33:09 +02:00
Jorge Manrubia 5a90de8bcb Use aria-expanded instead of class 2025-09-28 11:31:03 +02:00
Jorge Manrubia 6a231b48f2 Fix: script should consider old considering cards as belonging to the stream now 2025-09-27 07:42:04 +02:00
Andy Smith 58b21ca695 Add card grid styles when they aren't in columns 2025-09-26 13:57:37 -05:00
Andy Smith 78f72cfbd9 Reconnect drag audio after latest updates 2025-09-26 13:27:04 -05:00