63c05220ce
Clearer naming
2025-04-12 11:09:55 +02:00
27d90abbd6
Reduce the direct knowledge of comments inside the card
2025-04-12 11:04:16 +02:00
24b02c42fd
Comments are dependents of messages, so need to destroy the latter to get the former
2025-04-12 10:59:59 +02:00
aefae634c3
Anemic params method
...
Wont ever get reused here since there is no update
2025-04-11 18:21:44 +02:00
8d36f13fab
No longer needing that extra local
2025-04-11 18:20:28 +02:00
06a636bd8d
Did need to separate them out for the broadcast
2025-04-11 18:19:33 +02:00
5fa8007397
Loaded directly in the partial
2025-04-11 18:19:10 +02:00
7861b7c087
Just open one turbo stream per card
...
Per comment is excessive and needless
2025-04-11 17:58:11 +02:00
79700162fc
Use correct stream name
...
comment, :comments makes no sense for a stream for the reactions
2025-04-11 17:47:35 +02:00
eec76d0d4f
Use modern params#expect
2025-04-11 17:43:31 +02:00
f9bb779b61
Use local vars so ivar dependency is only from before actions
2025-04-11 17:42:30 +02:00
3ecf150636
Use proper access control
...
Otherwise you could react to any comment on the entire account. And then
you might as well just do Comment.find.
2025-04-11 17:41:28 +02:00
5084bbf3b7
Use modern params#expect syntax
2025-04-11 17:01:19 +02:00
8a4a087a00
Fine to let destroying something destroyed be a no-op
...
Would be an edge-casey race condition, but its possible
2025-04-11 17:00:08 +02:00
256d536009
Always use _path unless we are changing domains
2025-04-11 16:58:56 +02:00
16c1583133
Usually the order comes last
2025-04-11 16:58:47 +02:00
5ecf0ce3f6
Stick with one term
2025-04-11 16:57:03 +02:00
a8aa2c4f80
Clean up the controller
2025-04-11 16:49:55 +02:00
f4ce57e308
Move comments under cards
2025-04-11 16:21:44 +02:00
1275abd99e
Fix recently completed order for good!
2025-04-11 11:37:02 +02:00
66b5732264
Place recently closed cards first
2025-04-11 11:27:38 +02:00
4f3f322528
Rename inconsistency: go with goldness
2025-04-11 10:22:18 +02:00
806609e77b
Use gild/ungild
2025-04-11 10:20:06 +02:00
492a42ba92
Not needed anymore
2025-04-11 09:57:45 +02:00
5560976091
Merge branch 'main' into gold-cards
...
* main:
Try a segmented toggle for engagement
Fix tests
Rework min card design and meta section for all cards
Move `title` to the `img` element so we get hover in both cases
Remove sorting filter UI
Sort Considering and Doing by `updated_at`
Restore comment action icon
Fix dot escaping container
Seen cards should be flat
Ensure overflow cards are hidden
Arrow needs to match derived color
Dialog target needs to be present
This isn't necessary in the mini card template
Revert "The button and dialog need not render in previews"
2025-04-10 16:42:45 -05:00
0c107c5894
Fix that cards which were Drafted or in Considering were also being displayed in Doing
...
CC: @jorgemanrubia
2025-04-10 16:42:40 -05:00
1387ad2581
Sort Considering and Doing by updated_at
2025-04-10 11:06:55 -05:00
fac2fce3d5
Rename scope
2025-04-10 17:18:02 +02:00
2e5b25a30c
Always place golden cards first
2025-04-10 17:05:30 +02:00
7406a1039f
Add models to track gold cards and implement basic toggle behavior
2025-04-10 16:48:12 +02:00
c7b3b45977
Merge pull request #391 from basecamp/cards-pagination-2
...
Paginate collection cards
2025-04-10 15:10:54 +02:00
695247ae9b
Paginate collection cards
2025-04-10 15:09:56 +02:00
f9fb633cba
Add colors to stages
2025-04-09 15:45:08 -05:00
c55501a6c8
Remove unused display count feature
2025-04-09 14:54:53 -05:00
221bbb3247
Fix renames that the scripts missed
2025-04-09 14:56:59 +02:00
723e6d94f5
Rename bubbles => cards
2025-04-09 14:50:58 +02:00
d111fb50c3
Default collection permissions to "all access"
...
ref: https://37s.fizzy.37signals.com/buckets/693169853/bubbles/999008744
2025-04-07 12:48:43 -04:00
23892296da
Move readings under bubbles and out of double nesting
2025-04-07 14:06:56 +02:00
fea5463642
Merge pull request #372 from basecamp/scope-accesses
...
Scope data by account
2025-04-07 13:35:44 +02:00
9b4169c7ca
Scope data by account
...
With a single database this problem is not as bad, but it feels
safer to do things right. Also, not everyone in an account has access
to all the bubbles.
2025-04-07 13:09:49 +02:00
40df93eed7
Max max age for your own avatar
...
So that you don't get confused when you don't see it update
after changing it.
2025-04-07 06:59:36 +02:00
565ee0f548
Dont have to spell this out when there are no other formats
2025-04-06 21:09:49 +02:00
c06802856e
Move boosts under bubbles
...
But also remove the need for a bucket nesting
2025-04-06 21:04:28 +02:00
4fd1472fae
Move bubble watch out from the needless bucket nesting
2025-04-06 19:22:40 +02:00
eb0614c44f
Use a more ergonomic API for watching
...
Passing a boolean vs using explicit on/off methods feel too low level
and doesnt read right in most of these cases.
2025-04-06 19:17:26 +02:00
95cd60b919
Style
2025-04-06 18:49:19 +02:00
b8bcfdee40
This is not just param extraction, we sanitize too
2025-04-06 13:29:43 +02:00
5e78a1dab1
Make it clearer that this takes a title string not a tag object
2025-04-06 13:28:52 +02:00
ee22e69e6e
Move taggings to bubbles
2025-04-05 22:19:12 +02:00
540316e639
Move taggings under bubbles
2025-04-05 21:54:48 +02:00
David Heinemeier Hansson