Commit Graph

384 Commits

Author SHA1 Message Date
David Heinemeier Hansson d8f9511e08 Unused 2025-04-12 11:34:56 +02:00
David Heinemeier Hansson 1a9a65fffb Unused 2025-04-12 11:31:50 +02:00
David Heinemeier Hansson 2f8a9bed0e There is only ever one account per database
So there is no protection in scoping things by account cc @jorgemanrubia
2025-04-12 11:30:28 +02:00
David Heinemeier Hansson 81a89dbda1 Comments should always have messages 2025-04-12 11:23:45 +02:00
David Heinemeier Hansson cef8899bda Comments are not currently used as notifiables 2025-04-12 11:18:59 +02:00
David Heinemeier Hansson 9f1c3ae046 Note my discontent 2025-04-12 11:17:01 +02:00
David Heinemeier Hansson 1c4e0d3ccc Not using the destroy callback 2025-04-12 11:11:30 +02:00
David Heinemeier Hansson 63c05220ce Clearer naming 2025-04-12 11:09:55 +02:00
David Heinemeier Hansson ecffdc2af4 Spacing 2025-04-12 11:07:27 +02:00
David Heinemeier Hansson 735a12abfc Better name 2025-04-12 11:07:02 +02:00
David Heinemeier Hansson 9f7bbbef58 Split draft commenting back out to a dedicated concern 2025-04-12 11:05:56 +02:00
David Heinemeier Hansson 27d90abbd6 Reduce the direct knowledge of comments inside the card 2025-04-12 11:04:16 +02:00
David Heinemeier Hansson b698eefa06 Messageables already have access to the card 2025-04-12 11:00:15 +02:00
David Heinemeier Hansson 60a0360203 Remove more activity scoring related to comments 2025-04-12 10:52:48 +02:00
David Heinemeier Hansson fb733b9a60 No more tracking commenting as an activity for sorting
We are doing away with all the automated activity scoring, but for now
lets just get rid of it for comments.
2025-04-12 10:50:25 +02:00
David Heinemeier Hansson 81f431d946 Comment-specific behavior needs to live in the comment
This really is a bit of a tangled mess. Everyone knows everything about
everyone else.
2025-04-12 10:39:56 +02:00
David Heinemeier Hansson bb64adfd1b Most important methods first 2025-04-12 10:39:19 +02:00
David Heinemeier Hansson 4d2ba5b432 Use the explicit method for now 2025-04-12 10:27:57 +02:00
David Heinemeier Hansson 80bc1dd163 Reactions dont have any callbacks so can just be deleted 2025-04-12 10:15:38 +02:00
David Heinemeier Hansson 6f3ac772ea Merge branch 'main' into comments-refactoring
* main:
  Show more of the summary before truncating
  Improve event summaries
  Add this for debugging empty event cards
  Some actions shouldn't be available to closed cards
  Nicer spacing when the large button isn't present
  Update `card-color` in a couple more places
  Don't show the engagement toggle on closed cards
  Show more of the summary before truncating
  Improve event summaries
  Remove shadows from notifications you can't see
  Add this for debugging empty event cards
  Some actions shouldn't be available to closed cards
  Nicer spacing when the large button isn't present
  Update `card-color` in a couple more places
  Don't show the engagement toggle on closed cards
  Style drafted cards
  Considering needs to include drafted cards or you'll never be able to see them
  This item makes no sense until it's saved
  Tighten engagement switch design, only display it for published cards
2025-04-12 09:56:28 +02:00
Jason Zimdars 5997ef2c70 Considering needs to include drafted cards or you'll never be able to see them 2025-04-11 12:08:05 -05:00
David Heinemeier Hansson 6f1c802292 Content being required via UI and db constraint is enough
We are not using/displaying model validations anywhere
2025-04-11 18:28:23 +02:00
David Heinemeier Hansson a8aa2c4f80 Clean up the controller 2025-04-11 16:49:55 +02:00
David Heinemeier Hansson f4ce57e308 Move comments under cards 2025-04-11 16:21:44 +02:00
David Heinemeier Hansson 64b529ce94 Fix indention 2025-04-11 16:12:18 +02:00
Jorge Manrubia 17aa9b97e9 Monkey patch a prepend_order method 2025-04-11 10:28:12 +02:00
Jorge Manrubia eae1669ac3 Touch 2025-04-11 10:20:30 +02:00
Jorge Manrubia 806609e77b Use gild/ungild 2025-04-11 10:20:06 +02:00
Jorge Manrubia b4297ab852 Format 2025-04-11 09:57:45 +02:00
Jorge Manrubia 5360b4ccb4 Add comment 2025-04-11 09:57:45 +02:00
Jason Zimdars 5560976091 Merge branch 'main' into gold-cards
* main:
  Try a segmented toggle for engagement
  Fix tests
  Rework min card design and meta section for all cards
  Move `title` to the `img` element so we get hover in both cases
  Remove sorting filter UI
  Sort Considering and Doing by `updated_at`
  Restore comment action icon
  Fix dot escaping container
  Seen cards should be flat
  Ensure overflow cards are hidden
  Arrow needs to match derived color
  Dialog target needs to be present
  This isn't necessary in the mini card template
  Revert "The button and dialog need not render in previews"
2025-04-10 16:42:45 -05:00
Jason Zimdars 0c107c5894 Fix that cards which were Drafted or in Considering were also being displayed in Doing
CC: @jorgemanrubia
2025-04-10 16:42:40 -05:00
Jason Zimdars 1387ad2581 Sort Considering and Doing by updated_at 2025-04-10 11:06:55 -05:00
Jorge Manrubia fac2fce3d5 Rename scope 2025-04-10 17:18:02 +02:00
Jorge Manrubia 9747d590ea Not used 2025-04-10 17:16:36 +02:00
Jorge Manrubia 2e5b25a30c Always place golden cards first 2025-04-10 17:05:30 +02:00
Jorge Manrubia 7406a1039f Add models to track gold cards and implement basic toggle behavior 2025-04-10 16:48:12 +02:00
Jorge Manrubia c7b3b45977 Merge pull request #391 from basecamp/cards-pagination-2
Paginate collection cards
2025-04-10 15:10:54 +02:00
Jorge Manrubia 695247ae9b Paginate collection cards 2025-04-10 15:09:56 +02:00
Jorge Manrubia c6b2e5461b Simplify conditions to pick up a color 2025-04-10 12:40:14 +02:00
Jason Zimdars acba58f802 Ensure card.color returns default value when there is no stage 2025-04-09 17:06:36 -05:00
Jason Zimdars c1ef706f59 Remove concern 2025-04-09 17:03:39 -05:00
Jason Zimdars e02feece1c Move concern out from under Card and rename
`Colored` is a little icky
2025-04-09 15:42:33 -05:00
Jason Zimdars c55501a6c8 Remove unused display count feature 2025-04-09 14:54:53 -05:00
Jorge Manrubia 473fa1dafd Rename constant 2025-04-09 21:28:29 +02:00
Jorge Manrubia 221bbb3247 Fix renames that the scripts missed 2025-04-09 14:56:59 +02:00
Jorge Manrubia 723e6d94f5 Rename bubbles => cards 2025-04-09 14:50:58 +02:00
Jorge Manrubia 2106fb464a Revert "Scope searches by user"
This reverts commit 47552dd8d7.
2025-04-07 13:42:57 +02:00
Jorge Manrubia 47552dd8d7 Scope searches by user 2025-04-07 13:42:27 +02:00
Jorge Manrubia 9b4169c7ca Scope data by account
With a single database this problem is not as bad, but it feels
safer to do things right. Also, not everyone in an account has access
to all the bubbles.
2025-04-07 13:09:49 +02:00