Commit Graph

75 Commits

Author SHA1 Message Date
Jorge Manrubia d533f05c7b Use vanilla resources for handling notifications 2025-09-10 09:17:57 +02:00
Jorge Manrubia cb67352275 Don't render HTML stripping the tags for comment bodies, use to_plain_text instead
This will prevent error when generating notification bundles such as:

Type	ActionView::Template::Error
Message	undefined method 'rails_blob_path' for an instance of #<Class:0x00007fbb7e0c2a88>

We could just use the _url variant but this feels better nevertheless
2025-09-08 08:41:18 +02:00
Jorge Manrubia 2adb4571e1 Copy 2025-08-28 12:03:49 +02:00
Jorge Manrubia 53144a379c Add option to change the bundled email notification frequency 2025-08-28 11:56:40 +02:00
Andy Smith c354ac4ac2 Fox wonky notification position 2025-08-19 10:33:36 -05:00
Jason Zimdars 133ef1405d Navigate the notifications list on the Index 2025-07-29 17:27:29 -05:00
Jason Zimdars 8c9d7d9d91 Update badge counts clientside because we can't count on pushes to remove badges 2025-07-24 14:43:51 -05:00
Jason Zimdars 046d66fbed Consistent with Mark as read 2025-07-23 17:45:12 -05:00
Jason Zimdars 250d38768f Rename helper since it now handles both actions 2025-07-23 17:44:52 -05:00
Jason Zimdars db92de7a27 data-controller = form needs to be on the form or it causes errors
- The whole reason we're using `form.submit` here is to prevent clicks on the card link
2025-07-23 17:43:15 -05:00
Jason Zimdars 4276aad5a7 Mark notifications as unread from the index 2025-07-23 17:01:59 -05:00
Mike Dalessio 3156fbd770 Fix notification rendering on card closure events
where the closure no longer exists, possibly due to being
reopened.

Previously, fragment caching generally prevented any problems, but if
the cache is busted for any reason (like Andy did in c7eeb56c), then
the previous logic would raise an exception like "undefined method
'reason' for nil".

So, if the closure no longer exists, let's just note that it was
closed, and by who.
2025-06-30 23:45:53 -04:00
Jason Zimdars 5163382bee Avoid visits to the card when marking as read 2025-06-19 15:02:24 -05:00
Jason Zimdars 538102419d Inline unread indicator so it aligns reliably 2025-06-17 14:14:29 -05:00
Jason Zimdars 23439509c5 Add meta to collection notification line, adjust content 2025-06-16 19:27:51 -05:00
Jason Zimdars 65d9ef25b4 Don't close notifications panel when navigating
- Allows you to power through them
2025-06-11 17:45:24 -05:00
Jorge Manrubia 84fdeb4a5e Track events when reopening cards 2025-06-04 17:18:01 +02:00
Jason Zimdars 8072a74562 event.assignees collection doesn't include event.creator when self-assigning 2025-06-02 22:37:58 -05:00
Jorge Manrubia fa04016cbe Revert "Revert "Replace House with Lexical"" 2025-05-29 14:25:16 +02:00
Jorge Manrubia 08d8b2e5ff Revert "Replace House with Lexical" 2025-05-29 14:22:27 +02:00
Jorge Manrubia 10b2aad647 Replace House with lexical-powered actiontext 2025-05-23 11:41:08 +02:00
Jason Zimdars 684f77c687 Can just inline this now 2025-05-21 15:45:52 -05:00
Mike Dalessio ecbe040e3e Implement Notification#card
Models now know how to find their cards, rather than trying to
implement this logic in a view helper.
2025-05-21 16:30:18 -04:00
Jason Zimdars 6ab166b439 We need to set card color on the notification 2025-05-21 14:29:43 -05:00
Jason Zimdars ccc83a9916 Some eventables are comments so we need to get to card.closed? via a different method 2025-05-21 14:07:25 -05:00
Jason Zimdars 92b4746edb Color closed notifications, too 2025-05-21 13:58:02 -05:00
Andy Smith 04d01d7d10 Merge notification styles into a card variant 2025-05-20 13:50:53 -05:00
Andy Smith 900fbef686 Add card header to notifications 2025-05-19 15:20:56 -05:00
Mike Dalessio c2c4def3b4 Ensure that cards with an empty title aren't mysterious in notifs
Use something like "Card 55" instead of it being blank or raising an exception.
2025-05-07 15:57:55 -04:00
Jason Zimdars c2a563c699 Need to name the assignee(s) 2025-05-06 15:45:28 -05:00
Andy Smith 4824597649 Larger click area for the clear notification button 2025-05-05 14:49:31 -05:00
Jorge Manrubia 27f6006b58 Does not belong here anymore 2025-04-24 13:48:53 +02:00
Jorge Manrubia 905ccb9b4b Make comments the event's host 2025-04-24 13:45:48 +02:00
Jorge Manrubia 18cc24e1d3 Add an event prefix named after the model now that events are generic 2025-04-24 13:20:09 +02:00
Jorge Manrubia 54f4bd5144 Generalize event's cards as eventable,add collection
Lots to tidy up but this is working
2025-04-24 12:28:16 +02:00
Jorge Manrubia 646e4a59bc Fix missing variable name 2025-04-23 18:45:55 +02:00
Jorge Manrubia 07d3447e7e Resolve notifications URLs 2025-04-23 14:34:59 +02:00
Jorge Manrubia 2eae58725a Remove notifications' resource relationship
Is confusing since "source" already captures the origin of the notifications. It's
needed to interpret things at rendering time, so we can query things as needed there.
2025-04-23 13:52:47 +02:00
Jorge Manrubia 7c0aff0680 Don't indent case 2025-04-23 13:36:39 +02:00
Jorge Manrubia 043230394e Tidy up event helper code
Also, revert to using a helper method to determine the event action, since this is purely a view concern. Keep method at the event model to identify initial assignments.
2025-04-23 13:35:09 +02:00
Jorge Manrubia 68e2e96076 Fix indentation 2025-04-23 10:44:42 +02:00
Jorge Manrubia 9b4fec936e Move mentions to comments
- It does not make sense to scan "event summaries" for notifications.
- Placing them at the message level prevents us from using the generic approach to extract the mentionable content
2025-04-22 16:17:37 +02:00
Jorge Manrubia 3bf73a0b71 Rename to match actual action 2025-04-22 14:22:23 +02:00
Jorge Manrubia 4f06473405 Notifications for mentions showing up 2025-04-22 12:02:48 +02:00
Jorge Manrubia aa3acfeaa8 Add plain text mentions 2025-04-22 11:26:56 +02:00
David Heinemeier Hansson 73f272f132 Use one controller for all notification readings 2025-04-15 19:14:50 +02:00
Kevin McConnell 028a43e652 Title is on the related card 2025-04-14 15:50:24 +01:00
David Heinemeier Hansson cf93da6886 Get rid of card_title
We can just set untitled on assignment of empty
2025-04-12 21:29:56 +02:00
Jason Zimdars 84276e85ba Ensure overflow cards are hidden 2025-04-10 09:43:09 -05:00
Jorge Manrubia 723e6d94f5 Rename bubbles => cards 2025-04-09 14:50:58 +02:00