cf9b07711a
Document left_joins_messageable smell
2024-10-28 10:27:50 -06:00
5cdf83163c
Document with_status name smell
2024-10-28 10:25:56 -06:00
dbad5a1a8c
Document intention to persist summary body
2024-10-28 10:24:43 -06:00
404755c9d9
Clean up Bubble#track_event
2024-10-28 10:20:39 -06:00
c571c4400d
Inline EventSummary#tallied_boosts
2024-10-28 10:07:25 -06:00
8b062b4432
Pull out Bubble#activity_count
2024-10-28 10:07:12 -06:00
46d1ce4702
Make it clear where the boost_count is coming from
2024-10-27 19:53:37 -06:00
2fb6ed76b3
Fix comments-dependent scopes
2024-10-27 19:50:06 -06:00
61d68bf79d
Account for event summaries with no boosts
2024-10-27 17:53:00 -06:00
287a956364
Let EventSummary do the work to summarize events
2024-10-27 17:41:48 -06:00
0727414017
Lean into delegated types APIs
2024-10-27 17:39:30 -06:00
f782b43ef5
find_or_create_next_summary -> find_or_create_active_summary
2024-10-27 12:36:37 -06:00
ede04d6d96
Fix search tests
2024-10-27 12:33:33 -06:00
993870c10c
Messageable concerns aren't actually dependent on Messages
2024-10-27 12:23:47 -06:00
45ba9b7a70
Use helpers instead of partials for events
2024-10-27 12:13:03 -06:00
f9712ea53f
Messageables don't belong to bubble directly
2024-10-27 11:57:33 -06:00
1b2df2200f
Unnecessary after_touch
2024-10-25 16:06:43 -06:00
a3edee6e58
Extract grouping of boosts
2024-10-25 16:06:34 -06:00
7b104287ba
Roll up boosts server-side
2024-10-25 15:39:54 -06:00
46c2b450da
has_one allows for touch: true
2024-10-25 15:25:57 -06:00
85d47a35ab
threadables -> messageables
2024-10-25 15:03:31 -06:00
3cd1d34f9d
Thread entries relay touches to thread
2024-10-24 19:27:55 -06:00
78232fabf8
map -> pluck
2024-10-24 18:15:23 -06:00
f5b01415aa
Bubble events can be deleted
2024-10-24 18:01:32 -06:00
652ec68e9c
Threadables should thread entry
2024-10-24 17:48:32 -06:00
3db14a117c
Store stage ids in event particulars
2024-10-24 17:36:40 -06:00
c57f18c20c
Materialize abstract thread
...
The domain language is clearer if we just persist a thread. Also rename some models so their purpose is clear.
2024-10-24 17:36:14 -06:00
ad88f90302
Fine not to denormalize user names in events
2024-10-24 15:50:00 -06:00
e2f608eb71
Remove *_names accessors for bucket views
2024-10-24 15:47:39 -06:00
28a024b1da
Pull out Threadable::TYPES
2024-10-24 11:36:24 -06:00
042bc2c10e
Use Proc for Threadable after_create
2024-10-24 11:31:06 -06:00
70ff52f883
Move inverse_of further up
2024-10-24 11:28:59 -06:00
e3db8e8700
Inline thread entry creation
2024-10-24 11:25:50 -06:00
c41da5837c
Add back bubble association to events
2024-10-24 11:22:23 -06:00
5fed37a8c4
Refactor Bubble::Thread#latest_rollup
2024-10-24 10:55:30 -06:00
a49c6dc3f6
Refactor Bubble#toggle_stage
2024-10-24 10:51:23 -06:00
804be0a971
Create thread entry in a callback
2024-10-24 10:38:59 -06:00
e1f03fb8fd
comment! -> comment
2024-10-23 19:13:35 -06:00
ca85326638
Simplify Bubble#comment!
2024-10-23 19:07:48 -06:00
a0c1c7d0ed
Move rollup param further up
2024-10-23 19:06:55 -06:00
208ace7214
Delegate Current.user to session
2024-10-23 18:49:40 -06:00
cf22fb454a
not_popped -> active
2024-10-23 18:32:27 -06:00
77e00488af
Move rollup further up
2024-10-23 18:09:32 -06:00
11efca5af9
Bubbles don't have events anymore
2024-10-23 18:08:01 -06:00
398baed6a6
Assignments should touch their bubbles
2024-10-23 17:29:49 -06:00
567dec2197
Simplify threadable<>bubble relationships
2024-10-23 17:29:24 -06:00
ae497aae85
Clear up dependency destruction chain
...
Buckets destroy their bubbles, which destroy their thread entries, which destroy their threadables, which is how comments end up destroyed, and then rollups end up deleting their events
2024-10-23 14:51:12 -06:00
35a31e3203
Model threadables
2024-10-23 14:10:04 -06:00
06ea38a9f7
Denormalize event data
2024-10-23 13:38:00 -06:00
0a5854e02e
Merge pull request #121 from basecamp/workflows-spike
...
Spike workflows
2024-10-22 11:32:44 -06:00
Jose Farias