Commit Graph

1175 Commits

Author SHA1 Message Date
Jorge Manrubia a1e3835eb8 Prevent 500 when running /search with empty string 2025-07-18 10:55:36 +02:00
Jorge Manrubia 44873e8ac4 More refinements 2025-07-18 06:50:13 +02:00
Jorge Manrubia d81568ff57 Filter by stage id, much better collection filtering 2025-07-18 05:50:22 +02:00
Jason Zimdars 4330cb4071 Ensure notifications link to the correct account 2025-07-17 22:20:16 -05:00
Jorge Manrubia b30bc85f4e Rework prompt to make it less ambiguous and better overall 2025-07-18 05:11:08 +02:00
Jason Zimdars 045460cd60 Revert "Use urls"
This reverts commit 74b5ac4244.
2025-07-17 20:12:06 -05:00
Jason Zimdars 74b5ac4244 Use urls 2025-07-17 19:54:29 -05:00
Jason Zimdars 6524363aec Merge branch 'main' into web-push
* main:
  Update dependencies
  dep: bump to ruby 3.4.5
  Switch to docker-dev
  Cache needs to include publication key
  First iteration on adding new users, from the console.
  Fix clear button position in Safari
  Give them screen reader labels
  Not needed
  Add missing `lang` attribute
  Restore missing aspect ratio on the perma
  Give the field more space when typing on mobile
  We're only concerned with truncating the placeholder, scope to that
  Make sure users can't login from launchpad if they're deactivated
  Destroy the SignalId::User when a user is deactivated
2025-07-17 14:31:05 -05:00
Jorge Manrubia 1486392b6b WIP 2025-07-17 13:32:37 +02:00
Jorge Manrubia 5f04696fe8 Rewrite prompt to be more accurate and example-driven 2025-07-17 13:32:36 +02:00
Mike Dalessio a099b4101a dep: bump to ruby 3.4.5
Also:

- bump bundler to 2.7.0
- work around the fix for https://bugs.ruby-lang.org/issues/21196 that appeared in 3.4.5
2025-07-16 19:13:39 -04:00
Jason Zimdars c8eb1c616d Need url helpers 2025-07-15 18:48:49 -05:00
Mike Dalessio e69023993c Make sure users can't login from launchpad if they're deactivated
Just in case the SignalId::User deletion failed.
2025-07-15 18:47:38 -04:00
Mike Dalessio 9f887e17f5 Destroy the SignalId::User when a user is deactivated 2025-07-15 18:30:23 -04:00
Jason Zimdars 38d13f78a3 Add pusher models and job 2025-07-15 13:16:18 -05:00
Jason Zimdars e59a994a0c Add db table and models 2025-07-14 19:57:30 -05:00
Jason Zimdars 97e20c5cd7 Make nil safe 2025-07-08 16:57:48 -05:00
Jason Zimdars 485e575c40 Merge branch 'main' into card-attachments
* main: (45 commits)
  Display tag counts in the filter menu
  Move Add Card button to header
  Re-write help content, try a modal-like display
  Move to internal registry
  Show date instead of time for notifications older than 1 day
  Ensure checks are visible for tags and assignments
  Adjust padding so card number isn't cut off
  Don't color the collection header in considering
  Golden cards bubble to the top of Considering, too
  Adjust card collection header when colored golden
  Allow cards in Considering to gilded
  Hide focus ring on new card titles and step inputs
  Add hover effect for comment edit button
  Add hover effect to overflow button
  Improve multi-account behavior of the PWA
  Remove unneeded *
  Rename test
  Review the code to move cards
  Update editor
  Generalize and delete mentions too
  ...
2025-07-08 16:04:14 -05:00
Jason Zimdars 27285a3dcb Display tag counts in the filter menu
- Provides a little information scent
- Prevents being surprised by "no results"
2025-07-08 15:57:29 -05:00
Jason Zimdars c66261d30f Golden cards bubble to the top of Considering, too 2025-07-07 15:35:05 -05:00
Jorge Manrubia 88074cc7ed Remove unneeded * 2025-07-04 21:57:18 +02:00
Jorge Manrubia 919211244b Review the code to move cards
- Scope accessed records
- Keep consistency by moving events too
2025-07-04 19:56:48 +02:00
Jorge Manrubia 3fb3e5b48e Generalize and delete mentions too 2025-07-04 19:08:29 +02:00
Jorge Manrubia cbeefc5b74 Remove unused code 2025-07-04 19:00:22 +02:00
Jorge Manrubia 9e0d668348 Make sure we don't remove accesses if collection is accessible 2025-07-04 18:56:30 +02:00
Jorge Manrubia c621cc6cc9 Destroy notifications when losing access to collection 2025-07-04 18:52:29 +02:00
Jorge Manrubia b8b4ef5463 Extract common concern to examine attachments 2025-07-04 17:53:37 +02:00
Jorge Manrubia 0191eb85dc Merge branch 'main' into card-attachments
* main:
  Don't create mentions from drafts until those are published
  Change Active Storage account slug extension to a to_prepare block
  dep: bump actiontext-lexical for previewable attachment fix
  Add assertion for composite command line
  Remove trace
  restore the right command
  Update action text
  The prompt confirmation system wasn't really working after moving to lexical
  Parse commands where it's just a gid properly
  Move inside concerns or the override won't work
  Truncation for comment author line
  Avoid duplicated queries and, instead, bump the last ones
  Adjust screen for screen readers
  Adjust icon sizing and uploading styles
2025-07-04 17:38:27 +02:00
Jorge Manrubia ec0c019967 Merge pull request #711 from basecamp/mentionable-published
Don't create mentions from drafts until those are published
2025-07-04 17:28:19 +02:00
Jorge Manrubia b9f7634457 Merge pull request #706 from basecamp/duplicated-seraches
Avoid duplicated queries and, instead, bump the last ones
2025-07-04 17:28:15 +02:00
Jorge Manrubia 17f9df8df3 Don't create mentions from drafts until those are published
https://fizzy.37signals.com/5986089/collections/2/cards/982
2025-07-04 17:25:39 +02:00
Jorge Manrubia 3ed7c940d9 Remove trace 2025-07-04 00:07:03 +02:00
Jorge Manrubia 2cd8df4975 restore the right command 2025-07-04 00:05:52 +02:00
Jason Zimdars 0539d366d7 Display attachments in events for comments 2025-07-03 16:48:43 -05:00
Jorge Manrubia c134df1bb8 Parse commands where it's just a gid properly 2025-07-03 23:10:19 +02:00
Jorge Manrubia 994560c1b7 Move inside concerns or the override won't work 2025-07-03 23:06:37 +02:00
Jason Zimdars cf4c6dba9c Indicate cards with attachments in the description 2025-07-03 15:56:25 -05:00
Jorge Manrubia 8071c7b522 Store the normalized line not the raw line! 2025-07-03 22:40:16 +02:00
Jorge Manrubia fd418b123e Always resolve rich text commands
I don't remember why I added this but we don't really need it. Also, this result
in potential ambiguity even when you use prompts for standalone tags and mentions
2025-07-03 22:21:50 +02:00
Jorge Manrubia fef9e74503 Avoid duplicated queries and, instead, bump the last ones 2025-07-03 21:52:58 +02:00
Mike Dalessio 53ebb509d8 Broadcast when all notifications are cleared
Then make the turbo response to clearing all notifications a no-op.

This has the bonus side effect of properly clearing the notifications
try on all open pages.

ref: https://fizzy.37signals.com/5986089/collections/2/cards/796
2025-07-03 12:05:41 -04:00
Mike Dalessio 19af7c7c50 Merge pull request #704 from basecamp/flavorjones/reconsider-resets-stalling
Cards' "stalled" metric is reset when reconsidered
2025-07-03 11:26:30 -04:00
Jorge Manrubia f18b79d464 Rename /add_card => /add 2025-07-03 17:23:56 +02:00
Mike Dalessio d376d7aa0c Cards' "stalled" metric is reset when reconsidered
Specifically, reconsidering removes the existing activity spike (if
one exists). This happens whether the card is reconsidered by entropy
or manually by a user.

ref: https://fizzy.37signals.com/5986089/collections/2/cards/916
2025-07-03 11:15:08 -04:00
Jorge Manrubia 702169384c Use composite commands even for single commands since they can carry custom titles, which is what we want with AI 2025-07-03 16:26:52 +02:00
Jorge Manrubia bd7b9a442e Merge branch 'main' into fizzy-do-prompts
* main: (57 commits)
  Untenanted access in authenticated controllers should request auth
  dep: bundle update
  dep: update Rails
  dep: bump AR::Tenanted
  Clean up the cable meta tag
  Fix activity feed pagination to fetch on demand
  Create a "published" event if a card is created published
  Scatter Honcho seeds over a 30 day period
  Fix the PWA manifest to use slugged URLs
  Collection publication edits render a turbo frame
  Collection workflow edits render a turbo frame
  Collection entropy config edits render a turbo frame
  Use automatic sizing where supported
  Introduce a separate controller for collection entropy config
  Add `card_id` to index
  Move to scope and inline method
  Prefer modern syntax
  Fix that stage should be visible above card background
  Indicate opens menu
  Hide dialog targets from screen readers when closed
  ...

# Conflicts:
#	db/schema.rb
#	db/schema_cache.yml
2025-07-03 16:11:00 +02:00
Jorge Manrubia 7794dd2fc4 More prompt tweaks 2025-07-03 16:07:21 +02:00
Jorge Manrubia f4147bda27 Support completed by via natural language 2025-07-03 15:52:11 +02:00
Jorge Manrubia cd9955d938 Add "close by" filter 2025-07-03 14:32:03 +02:00
Jorge Manrubia ac2400a657 Add /reopen command 2025-07-03 13:52:12 +02:00