Commit Graph

2143 Commits

Author SHA1 Message Date
Andy Smith 01c642e6a8 Restructure day containers 2025-05-12 15:29:33 -05:00
Mike Dalessio 5d84b16b36 Ensure dates are re-formatted on turbo frame load
ref: https://37s.fizzy.37signals.com/collections/693169850/cards/999009063
2025-05-12 15:52:19 -04:00
Mike Dalessio b859c26125 Render the "last active at" timestamp in the card meta
because this is what the "closing soon" bubbles et al are triggered on.
2025-05-12 15:49:13 -04:00
Jason Zimdars ebba9a11fb Merge branch 'main' into jz-5-8-25
* main:
  Fix the flashing notif tray
  Remove unused var
  Update bubble text when 0 days
  More yellow, less orange
  Don't run solid queue in dev by default
  Add more gold to the golden cards
  Remove outlined letters, only use mono for date
  Tweak stroke values for legibility
  Try monospace font
  Text stroke outlines
2025-05-08 17:26:46 -05:00
Mike Dalessio 725b38e6b3 Merge pull request #482 from basecamp/flavorjones/fix-flashing-notif-tray
Fix the flashing notif tray
2025-05-08 17:33:33 -04:00
Mike Dalessio 0219ad8c1f Fix the flashing notif tray
I think this is OK to make permanent again now that we're broadcasting
readings to keep the try in sync.

ref: https://37s.fizzy.37signals.com/collections/693169850/cards/999009042
2025-05-08 17:31:34 -04:00
Jason Zimdars 3bfb25ebc2 Close pinned cards when you click since the tray persists between page loads 2025-05-08 16:23:57 -05:00
Andy Smith 5281022ef3 Remove unused var 2025-05-08 15:44:48 -05:00
Andy Smith d6736a8bcf Update bubble text when 0 days 2025-05-08 15:43:56 -05:00
Andy Smith 0149f7daaa Merge pull request #467 from basecamp/completed-text-outline
Completed text outline
2025-05-08 14:36:44 -05:00
Jason Zimdars b1cd10afe7 Nudge people that / is for commands 2025-05-08 13:07:41 -05:00
Jason Zimdars d02501e008 Show help if you arrow-up but don't have any previous commands yet
- @jorgemanrubia this is a little fragile because it relies on CSS `:empty` which fails if any whitespace is present, which is why I needed to make the `<ul>` a one-liner. If we like this we may want to implement something more robust
2025-05-08 13:03:47 -05:00
Andy Smith 9a38c28858 Merge pull request #463 from basecamp/reaction-emojis
Reaction emojis
2025-05-08 11:00:26 -05:00
Jorge Manrubia 1662a8af82 Hide terminal menu when pressing ESC
This was only working when the focus was on the input
2025-05-08 11:37:30 +02:00
Jorge Manrubia 5cd71a7699 Don't dismiss on any key, only with N or ESC
Also, this reworks the system to rely on stimulus event handling. This cover cases like unbinding events automatically when the controller get disconnected and such.

See:
https://3.basecamp.com/2914079/buckets/37331921/todos/8617430347
2025-05-08 11:21:39 +02:00
Jorge Manrubia 86db634f7f Fix: selected item not showing up in Safari
It also handles auto selecting when an element is focus. E.g: if you tabulate to the next control in the navigable list, you want selection to update accordingly.
2025-05-08 10:41:51 +02:00
Jorge Manrubia 59303a4628 Merge branch 'main' into fizzy-do-3
* main: (29 commits)
  Ensure that a "reconsidered" card gets an updated timestamp
  Try a fresh activity design
  Log the authenticated user
  Remove leading space when avatar is hidden on pinned cards
  Display card number in notifications and events
  Ensure that cards with an empty title aren't mysterious in notifs
  bin/dev ensures puma runs solid queue
  Adjust selection color to feel more terminal-y
  Eliminate double-tab behavior
  Clear error state when you start editing
  Color terminal text on error
  Don't indicate spelling errors
  The command is lowercase
  Remind 7 days before, not 30
  Make the icon square
  Subtler bubble styles
  Variable bubble shapes
  Bubble CSS
  Rename 'badge' to 'bubble'
  Address PR feedback
  ...

# Conflicts:
#	app/javascript/controllers/terminal_controller.js
#	app/views/commands/_form.html.erb
2025-05-08 10:29:54 +02:00
Jorge Manrubia d10c45772e Add a clear command to clear filters 2025-05-08 10:20:57 +02:00
Jorge Manrubia 06ed269ef8 Add control to show and remove card id filters 2025-05-08 09:58:54 +02:00
Jason Zimdars 62b44cbb29 Polish help 2025-05-07 17:32:49 -05:00
Andy Smith 9eceeb2a2e Remove outlined letters, only use mono for date 2025-05-07 16:44:02 -05:00
Jason Zimdars d3cad768a1 Try a fresh activity design 2025-05-07 16:26:32 -05:00
Andy Smith 8d1a4ec73a Close ghost space when no reactions exist 2025-05-07 15:15:28 -05:00
Jason Zimdars d4d6a702f8 Remove leading space when avatar is hidden on pinned cards 2025-05-07 15:13:10 -05:00
Jason Zimdars dd5e45c93d Display card number in notifications and events 2025-05-07 15:09:47 -05:00
Andy Smith beda688d10 Show buttons depending on reaction presence 2025-05-07 15:06:40 -05:00
Andy Smith c69402a300 Get turboframes sorted out 2025-05-07 15:02:34 -05:00
Andy Smith 3710aa43e4 Stub out overflow reactions 2025-05-07 14:29:29 -05:00
Jason Zimdars fe48aecaae Eliminate double-tab behavior 2025-05-07 12:28:09 -05:00
Jason Zimdars 28659c1295 Clear error state when you start editing
- It feels wrong to persist the error state while you're fixing the command
2025-05-07 11:52:20 -05:00
Jason Zimdars 19a7972a46 Don't indicate spelling errors 2025-05-07 11:43:45 -05:00
Andy Smith 03473d8842 Merge pull request #406 from basecamp/closing-soon-badge
Closing soon badge
2025-05-07 11:13:35 -05:00
Andy Smith ae21bf2622 Try monospace font 2025-05-07 10:44:19 -05:00
Jorge Manrubia 2503524b7a Implement help menu command to show a help menu with the commands 2025-05-07 17:32:43 +02:00
Andy Smith 9ae0458e5f Text stroke outlines 2025-05-07 10:24:12 -05:00
Jorge Manrubia 6776e69ed8 Stop propagation so that it doesn't navigate back on ESC 2025-05-07 14:43:11 +02:00
Jorge Manrubia 87484dbca0 Add basic keyboard navigation support for the Fizzy do menu 2025-05-07 13:46:19 +02:00
Jorge Manrubia 0dcc6959da Extract constant to clarify regexp 2025-05-07 13:31:52 +02:00
Jorge Manrubia 4d2f2067ed Format 2025-05-07 12:13:45 +02:00
Jorge Manrubia 181e35b5b2 Restore command when clicking on it 2025-05-07 12:03:02 +02:00
Jorge Manrubia 8697cabbe2 Show confirmation when submitting certain commands
https://3.basecamp.com/2914079/buckets/37331921/todos/8617430347
2025-05-07 10:20:32 +02:00
Jorge Manrubia 22c3c33c0b Merge pull request #460 from basecamp/fizzy-do-initial
Fizzy Do (initial)
2025-05-07 08:57:37 +02:00
Jorge Manrubia 6f382b68e0 Rename command controller => terminal controller and name the error class after terminal 2025-05-07 08:53:25 +02:00
Jorge Manrubia 55ea460d3e Handle form errors with a stimulus class
We need to keep the focus in place when submitting the form. We are using a data-turbo-permanent for that. We were rendering the error form with a turbo stream. The problem was that turbo streams ignore permanent elements as per this https://github.com/hotwired/turbo/pull/688, so the system wasn't updating the input field as expected.

Handling this as the stimulus level will also help with managing additional error states (such as the one we need for confirmations).
2025-05-07 08:46:47 +02:00
Jason Zimdars 94e2ab25f9 Make command a button 2025-05-06 17:45:05 -05:00
Jason Zimdars 10890df97f Style undo button 2025-05-06 17:32:45 -05:00
Andy Smith 5b8f108316 Gentler react animation 2025-05-06 17:02:03 -05:00
Andy Smith 9034498f40 Fix hidden field value 2025-05-06 16:49:14 -05:00
Andy Smith 9b49606246 Consistently align and size all elements 2025-05-06 16:37:01 -05:00
Jason Zimdars 521351da16 Add a keyboard shortcut 2025-05-06 16:15:19 -05:00