David Heinemeier Hansson
883a225946
Use upstreamed assert_in_body
2025-04-19 10:08:08 +02:00
David Heinemeier Hansson
cacee0febb
Remove anemic scope
2025-04-18 17:18:13 +02:00
David Heinemeier Hansson
7c76bdd96d
Drop Scorable concern
2025-04-18 17:07:36 +02:00
David Heinemeier Hansson
1114679c20
Remove activity score columns
2025-04-18 17:05:17 +02:00
David Heinemeier Hansson
3003105ac9
Flesh out the rest of the controller tests
2025-04-18 16:16:04 +02:00
David Heinemeier Hansson
f6cd21f7cb
Extract default stages into something that will be created together with a new Workflow in the model
2025-04-18 16:07:01 +02:00
David Heinemeier Hansson
fd21838f88
Add assert_in_body helper
...
Coming upstream
2025-04-18 16:06:30 +02:00
Jason Zimdars
44a5215da7
Merge branch 'main' into add-card-description
...
* main:
Fix failing test (we're no longer redirecting here
Display the empty message via CSS when there are no unread notifications
Hide Previously Seen section when empty with CSS
2025-04-17 17:08:49 -05:00
Jason Zimdars
c61fa77d6b
Fix failing test (we're no longer redirecting here
...
See: #411
2025-04-17 17:03:18 -05:00
Jason Zimdars
04f9a0f83a
Merge branch 'main' into add-card-description
...
* main: (33 commits)
Run beamer accessories in production only
Less noisy logging in production
Inline perma to container partial
Use card replacement for card updates too
Extract helper method to keep partial at a uniform level of abstraction
Remove duplicated conditional
Style
Note that we dont want to keep reloading these frames
I like this even better
Suffix qualifier is unnnecessary
Group partials for container
Match domain language
Fix trailing space
Use card rerendering instead of redirects
Better name
Stick with domain language
Fix tests
Rerender instead of redirect
Style
Extract partials that can be rerendered
...
2025-04-17 16:40:23 -05:00
David Heinemeier Hansson
7adbd8d634
Use card rerendering instead of redirects
2025-04-17 15:20:27 +02:00
David Heinemeier Hansson
06da295f44
Fix tests
2025-04-17 14:56:53 +02:00
David Heinemeier Hansson
7b5a1c0232
Fix test
2025-04-17 14:32:26 +02:00
David Heinemeier Hansson
fc0cf3917f
Pin without redirect
...
Use turbo stream response to save on the redirect latency
2025-04-17 14:05:26 +02:00
David Heinemeier Hansson
a5de4863fa
Allow for multiple notifications to be read
...
cc @kevinmcconnell
2025-04-17 11:39:37 +02:00
Jason Zimdars
47d0ae98a1
Remove DraftCommenting
2025-04-16 19:01:21 -05:00
David Heinemeier Hansson
91194d1b66
Fixed up controller test
2025-04-16 16:37:06 +02:00
David Heinemeier Hansson
50e4587dd9
Fix trailing spaces
2025-04-16 11:56:21 +02:00
David Heinemeier Hansson
375afeac7b
Fix test
2025-04-16 11:55:35 +02:00
David Heinemeier Hansson
73f272f132
Use one controller for all notification readings
2025-04-15 19:14:50 +02:00
David Heinemeier Hansson
93178636cd
Flesh out all the tests
2025-04-15 15:41:01 +02:00
David Heinemeier Hansson
2e8df45680
Flesh out tests for users controller
2025-04-15 15:36:11 +02:00
David Heinemeier Hansson
dbf61f4fc3
Use _path in all cases where we are not potentially changing the domain
2025-04-13 08:17:36 +02:00
David Heinemeier Hansson
a106b1b6a7
Join the two users controllers but split out role setting
2025-04-12 20:30:47 +02:00
David Heinemeier Hansson
6bbf68a4f9
The tenanted db is the account scope
2025-04-12 20:06:34 +02:00
David Heinemeier Hansson
760cbb6c99
Drop boosts
...
Killed by design.
2025-04-12 18:52:54 +02:00
David Heinemeier Hansson
60a0360203
Remove more activity scoring related to comments
2025-04-12 10:52:48 +02:00
David Heinemeier Hansson
fb733b9a60
No more tracking commenting as an activity for sorting
...
We are doing away with all the automated activity scoring, but for now
lets just get rid of it for comments.
2025-04-12 10:50:25 +02:00
David Heinemeier Hansson
7861b7c087
Just open one turbo stream per card
...
Per comment is excessive and needless
2025-04-11 17:58:11 +02:00
David Heinemeier Hansson
79700162fc
Use correct stream name
...
comment, :comments makes no sense for a stream for the reactions
2025-04-11 17:47:35 +02:00
David Heinemeier Hansson
f4ce57e308
Move comments under cards
2025-04-11 16:21:44 +02:00
Jorge Manrubia
4f3f322528
Rename inconsistency: go with goldness
2025-04-11 10:22:18 +02:00
Jorge Manrubia
806609e77b
Use gild/ungild
2025-04-11 10:20:06 +02:00
Jorge Manrubia
f4b2bec5ce
Fix test
2025-04-11 09:57:45 +02:00
Jorge Manrubia
1bac0b84b3
Add tests
2025-04-11 09:36:24 +02:00
Jason Zimdars
ca067f7ca0
Fix tests
...
This is cheating a little because Doing and Considering are both always sorted by Latest at the moment. Keeping it like this while we vet this new direction
2025-04-10 14:42:42 -05:00
Jorge Manrubia
c7b3b45977
Merge pull request #391 from basecamp/cards-pagination-2
...
Paginate collection cards
2025-04-10 15:10:54 +02:00
Jorge Manrubia
695247ae9b
Paginate collection cards
2025-04-10 15:09:56 +02:00
Jorge Manrubia
468bbf1388
Add test
2025-04-10 13:15:29 +02:00
Jason Zimdars
aa7694ce7b
Update fixtures and test
2025-04-09 17:28:24 -05:00
Jorge Manrubia
473fa1dafd
Rename constant
2025-04-09 21:28:29 +02:00
Jorge Manrubia
221bbb3247
Fix renames that the scripts missed
2025-04-09 14:56:59 +02:00
Jorge Manrubia
723e6d94f5
Rename bubbles => cards
2025-04-09 14:50:58 +02:00
Kevin McConnell
9bbb59a166
Test for Bubbles::RecoversController
2025-04-07 14:30:05 +01:00
David Heinemeier Hansson
23892296da
Move readings under bubbles and out of double nesting
2025-04-07 14:06:56 +02:00
David Heinemeier Hansson
bcd6c6dd66
Move bubble stagings out from double nesting
2025-04-07 14:00:30 +02:00
David Heinemeier Hansson
481be72162
Move bubbles publish out from the double nesting
2025-04-07 13:55:12 +02:00
David Heinemeier Hansson
ce0c6146be
Move bubble pops out from double nesting
2025-04-07 13:45:51 +02:00
Jorge Manrubia
2106fb464a
Revert "Scope searches by user"
...
This reverts commit 47552dd8d7 .
2025-04-07 13:42:57 +02:00
Jorge Manrubia
47552dd8d7
Scope searches by user
2025-04-07 13:42:27 +02:00